Re: [Cluster-devel] [GFS2 PATCH] GFS2: Get a block reservation before resizing a file

2013-02-01 Thread Steven Whitehouse
Hi, Now in the -nmw tree. Thanks, Steve. On Fri, 2013-02-01 at 12:03 -0500, Bob Peterson wrote: > Hi, > > This patch allocates a block reservation structure before growing > or shrinking a file. Without this structure, the grow or shink code > can reference the bad pointer. > > Regards, > >

[Cluster-devel] GFS2: Split glock lru processing into two parts

2013-02-01 Thread Steven Whitehouse
The intent here is to split the processing of the glock lru list into two parts, so that the selection of glocks and the disposal are separate functions. The plan is then, that further updates can then be made to these functions in the future to improve the selection of glocks and also the efficie

Re: [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all()

2013-02-01 Thread Tejun Heo
Hello, David. On Fri, Feb 01, 2013 at 12:44:43PM -0500, David Teigland wrote: > I already tried my own version of this, but used idr_for_each_entry a > second time. Unfortunately, the number it found and printed did not match > recover_list_count. > > warning: recover_list_count 566 > > It prin

Re: [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all()

2013-02-01 Thread David Teigland
On Thu, Jan 31, 2013 at 04:18:41PM -0800, Tejun Heo wrote: > It looks a bit weird to me that ls->ls_recover_list_count is also > incremented by recover_list_add(). The two code paths don't seem to > be interlocke at least upon my very shallow glance. Is it that only > either the list or idr is in

[Cluster-devel] [GFS2 PATCH] GFS2: Get a block reservation before resizing a file

2013-02-01 Thread Bob Peterson
Hi, This patch allocates a block reservation structure before growing or shrinking a file. Without this structure, the grow or shink code can reference the bad pointer. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson --- fs/gfs2/bmap.c | 4 1 file changed, 4 inse

Re: [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all()

2013-02-01 Thread Tejun Heo
Hello, David. On Thu, Jan 31, 2013 at 03:53:20PM -0800, Tejun Heo wrote: > The function description is misleading. The function does search > inclusive range and needs explicit cursor increment to make progress. > Weird that it doesn't work. Looking into it. I'll write when I know > more. It l

Re: [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all()

2013-02-01 Thread Tejun Heo
Hello, David. Sorry about the delay. On Wed, Jan 30, 2013 at 04:24:18PM -0500, David Teigland wrote: > > Unfortunately, the list_for_each_entry doesn't seem to be clearing > > everything. I've seen "warning: recover_list_count 39" at the end of that > > function. > > I don't want to pretend to