Re: [Cluster-devel] GFS2: Pull request (fixes)

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 2:26 AM, Steven Whitehouse wrote: > Oops, forgot to sign this when I sent it first, so here is a signed copy of > it. Please sign the git tag instead of the email. There are no sane tools to check email signatures etc, but git signed tags not only check your pgp key signa

[Cluster-devel] [PATCH] libgfs2: Move the BLOCKMAP_* macros into fsck.gfs2

2013-08-19 Thread Andrew Price
These macros were only being used by fsck.gfs2 so they can safely be moved into gfs2/fsck/util.h Signed-off-by: Andrew Price --- gfs2/fsck/util.h | 4 gfs2/libgfs2/libgfs2.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gfs2/fsck/util.h b/gfs2/fsck/util.h in

[Cluster-devel] [PATCH] fsck.gfs2: Allocate enough space for the block map

2013-08-19 Thread Andrew Price
Building with gcc 4.8's address sanitizer and running the test suite throws up an issue where the block map allocated in fsck.gfs2 is not large enough when the required size is an odd number. For example, when the number of blocks is 3, the mapsize (number of chars to allocate memory for) would be

Re: [Cluster-devel] [PATCH] gfs2_lockcapture: Fixed rhbz#987019, modified option -o, added private option -R, removed lsof data capture.

2013-08-19 Thread Andrew Price
Hi Shane, The shortlog is far too long and references a bz#. Good shortlogs and commit logs are discussed in doc/README.contributing so please read that. On 19/08/13 15:10, sbrad...@redhat.com wrote: From: Shane Bradley Fix the header to use absolute path for rhbz#987019. The "-o" has been

Re: [Cluster-devel] [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions

2013-08-19 Thread Christoph Hellwig
> @@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct > sockaddr *rhs) > { I think your new sockaddr_equal should be equivalent to to this srcip_matches, that is it should warn about and return false for unknown address families.

[Cluster-devel] [PATCH] gfs2_lockcapture: Fixed rhbz#987019, modified option -o, added private option -R, removed lsof data capture.

2013-08-19 Thread sbradley
From: Shane Bradley Fix the header to use absolute path for rhbz#987019. The "-o" has been modified so that it takes a path that will be used to create the root directory of where the data will be written and will be location of the tarball that is created. Added undocumented(private) "-R" option

[Cluster-devel] [PATCH] gfs2-utils tests: Switch to autotest

2013-08-19 Thread Andrew Price
Replaces the custom tool_tests.sh test harness with the Autotest framework provided by Autoconf. See doc/README.tests for details. This is just a straight rework of the existing tests as Autotest test groups. Signed-off-by: Andrew Price --- .gitignore | 8 - configure.ac|

[Cluster-devel] [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions

2013-08-19 Thread Cong Wang
From: Cong Wang nfs and cifs define some helper functions for sockaddr, they can use the generic functions for union inet_addr/struct sockaddr too. Since some dlm code needs to compare ->sin_port, introduce a generic function inet_addr_equal_strict() for it. Cc: Steve French Cc: Christine Caul

[Cluster-devel] GFS2: Pull request (fixes)

2013-08-19 Thread Steven Whitehouse
Oops, forgot to sign this when I sent it first, so here is a signed copy of it. Hi, Please consider pulling the following changes, Steve. - Out of these five patches, the one for ensuring that the number of

[Cluster-devel] GFS2: Pull request (fixes)

2013-08-19 Thread Steven Whitehouse
Hi, Please consider pulling the following changes, Steve. - Out of these five patches, the one for ensuring that the number of revokes is not exceeded, and the one for checking the glock is not

[Cluster-devel] [PATCH 4/5] GFS2: alloc_workqueue() doesn't return an ERR_PTR

2013-08-19 Thread Steven Whitehouse
From: Dan Carpenter alloc_workqueue() returns a NULL on error, it doesn't return an ERR_PTR. Signed-off-by: Dan Carpenter Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 9435384..544a809 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -1838,14 +1838

[Cluster-devel] [PATCH 3/5] GFS2: don't overrun reserved revokes

2013-08-19 Thread Steven Whitehouse
From: Benjamin Marzinski When run during fsync, a gfs2_log_flush could happen between the time when gfs2_ail_flush checked the number of blocks to revoke, and when it actually started the transaction to do those revokes. This occassionally caused it to need more revokes than it reserved, causing

[Cluster-devel] [PATCH 2/5] GFS2: WQ_NON_REENTRANT is meaningless and going away

2013-08-19 Thread Steven Whitehouse
From: Tejun Heo dbf2576e37 ("workqueue: make all workqueues non-reentrant") made WQ_NON_REENTRANT no-op and the flag is going away. Remove its usages. This patch doesn't introduce any behavior changes. Signed-off-by: Tejun Heo Signed-off-by: Steven Whitehouse Cc: cluster-devel@redhat.com di

[Cluster-devel] [PATCH 5/5] GFS2: Check for glock already held in gfs2_getxattr

2013-08-19 Thread Steven Whitehouse
Since the introduction of atomic_open, gfs2_getxattr can be called with the glock already held, so we need to allow for this. Signed-off-by: Steven Whitehouse Reported-by: David Teigland Tested-by: David Teigland diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index a01b8fd..64915ee 100644 ---

[Cluster-devel] GFS2: Pre-pull patch posting (fixes)

2013-08-19 Thread Steven Whitehouse
Hi, Out of these fives patches, the one for ensuring that the number of revokes is not exceeded, and the one for checking the glock is not already held in gfs2_getxattr are the two most important. The latter can be triggered by selinux. The other three patches are very small and fix mostly fairly

[Cluster-devel] [PATCH 1/5] GFS2: Fix typo in gfs2_create_inode()

2013-08-19 Thread Steven Whitehouse
PTR_RET should be PTR_ERR Reported-by: Sachin Kamat Cc: Rusty Russell Signed-off-by: Steven Whitehouse diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index bbb2715..a01b8fd 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -594,7 +594,7 @@ static int gfs2_create_inode(struct inode *dir, st