Re: [Cluster-devel] [PATCH 14/18] xfs: use generic posix ACL infrastructure

2013-12-02 Thread Dave Chinner
On Sun, Dec 01, 2013 at 03:59:17AM -0800, Christoph Hellwig wrote: > Also create inodes with the proper mode instead of fixing it up later. > > Signed-off-by: Christoph Hellwig Nice cleanup work, Christoph. Reviewed-by: Dave Chinner -- Dave Chinner da...@fromorbit.com

Re: [Cluster-devel] [PATCH 12/18] ocfs2: use generic posix ACL infrastructure

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:15, Christoph Hellwig wrote: > This contains some major refactoring for the create path so that > inodes are created with the right mode to start with instead of > fixing it up later. > > Signed-off-by: Christoph Hellwig ... > -int ocfs2_acl_chmod(struct inode *inode) > -{ >

Re: [Cluster-devel] [PATCH 13/18] reiserfs: use generic posix ACL infrastructure

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:16, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/reiserfs/acl.h |4 +- > fs/reiserfs/file.c |1 + > fs/reise

Re: [Cluster-devel] [PATCH 08/18] ext2/3/4: use generic posix ACL infrastructure

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:11, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext2/acl.c | 176 - > fs/ext2/acl.h |

Re: [Cluster-devel] [Jfs-discussion] [PATCH 15/18] jfs: use generic posix ACL infrastructure

2013-12-02 Thread Dave Kleikamp
On 12/01/2013 05:59 AM, Christoph Hellwig wrote: > Copy the scheme I introduced to btrfs many years ago to only use the > xattr handler for ACLs, but pass plain attrs straight through. Looks good. > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Kleikamp > --- > fs/jfs/acl.c | 1

Re: [Cluster-devel] [PATCH 06/18] fs: make posix_acl_create more useful

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:09, Christoph Hellwig wrote: > Rename the current posix_acl_created to __posix_acl_create and add > a fully featured helper to set up the ACLs on file creation that > uses get_acl(). Looks good, you can add: Reviewed-by: Jan Kara

Re: [Cluster-devel] [PATCH 05/18] fs: make posix_acl_chmod more useful

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:08, Christoph Hellwig wrote: > Rename the current posix_acl_chmod to __posix_acl_chmod and add > a fully featured ACL chmod helper that uses the ->set_acl inode > operation. Looks good. You can add: Reviewed-by: Jan Kara

Re: [Cluster-devel] [PATCH 04/18] fs: add generic xattr_acl handlers

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:07, Christoph Hellwig wrote: > With the ->set_acl inode operation we can implement the Posix ACL > xattr handlers in generic code instead of duplicating them all > over the tree. Looks good. You can add: Reviewed-by: Jan Kara

Re: [Cluster-devel] [PATCH 03/18] fs: add a set_acl inode operation

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:06, Christoph Hellwig wrote: > This will allow moving all the Posix ACL handling into the VFS and clean > up tons of cruft in the filesystems. Looks good. Btw I'd merge this with the following patch... Anyway: Reviewed-by: Jan Kara

Re: [Cluster-devel] [PATCH 01/18] reiserfs: prefix ACL symbols with reiserfs_

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:04, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/reiserfs/xattr_acl.c | 20 ++-- > 1 file changed, 10 inserti

Re: [Cluster-devel] [PATCH 02/18] fs: add get_acl helper

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:05, Christoph Hellwig wrote: > Factor out the code to get an ACL either from the inode or disk from > check_acl, so that it can be used elsewhere later on. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara

Re: [Cluster-devel] [PATCH] fencing: Add support for ipmitool/amttool binaries during autoconf

2013-12-02 Thread Fabio M. Di Nitto
Thanks for doing it, we still need to change the agent to use IPMITOOL_PATH & co. :) Fabio On 12/02/2013 04:39 PM, Marek 'marx' Grac wrote: > Configuration of autoconf was extended to dynamically find ipmitool/amttool. > If the binary is not found on > the system then we will switch to default v

[Cluster-devel] [PATCH] fencing: Add support for ipmitool/amttool binaries during autoconf

2013-12-02 Thread Marek 'marx' Grac
Configuration of autoconf was extended to dynamically find ipmitool/amttool. If the binary is not found on the system then we will switch to default values (Fedora/RHEL). Path to binaries is exported and replaced in fencebuild using same processes as a version number or sbin/logdir. --- configur

Re: [Cluster-devel] [PATCH 10/18] hfsplus: use generic posix ACL infrastructure

2013-12-02 Thread Vyacheslav Dubeyko
On Dec 1, 2013, at 2:59 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/hfsplus/acl.h |9 +-- > fs/hfsplus/dir.c |1 + > fs/hfsplus/inode.c |3 +- > fs/hfsplus/posix_acl.c | 161 +--- > fs/hfsplus/xat