Re: [Cluster-devel] [GFS2 PATCH] GFS2: check NULL return value in gfs2_ok_to_move

2014-03-12 Thread Steven Whitehouse
Hi, On Wed, 2014-03-12 at 03:41 -0500, Abhi Das wrote: gfs2_lookupi() can return NULL if the path to the root is broken by another rename/rmdir. In this case gfs2_ok_to_move() must check for this NULL pointer and return error. Resolves: rhbz#1060246 Signed-off-by: Abhi Das a...@redhat.com

[Cluster-devel] [GFS2 PATCH] GFS2: Adjust lock reference count

2014-03-12 Thread Bob Peterson
Hi, This patch closes a small timing window whereby a request to hold the transaction glock can get stuck. The problem is that after the DLM has granted the lock, it can get into a state whereby it doesn't transition the glock to a held state, due to not having requeued the glock state machine to

[Cluster-devel] [GFS2 PATCH] GFS2: Re-add a call to log_flush_wait when flushing the journal

2014-03-12 Thread Bob Peterson
Hi, Upstream commit 34cc178 changed a line of code from calling function log_flush_commit to calling log_write_header. This had the effect of eliminating a call to function log_flush_wait. That causes the journal to skip over log headers, which results in multiple wrap points, which itself leads

Re: [Cluster-devel] [GFS2 PATCH] GFS2: check NULL return value in gfs2_ok_to_move

2014-03-12 Thread Steven Whitehouse
Hi, On Wed, 2014-03-12 at 06:59 -0400, Abhijith Das wrote: Err... a heads up: We might have to revise this patch. I just ran fsck on the fs after cleanly unmounting it and it came back with a bunch of errors complaining about inodes missing '.' and '..' directories. I haven't looked at the

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Adjust lock reference count

2014-03-12 Thread Steven Whitehouse
Hi, On Wed, 2014-03-12 at 10:32 -0400, Bob Peterson wrote: Hi, This patch closes a small timing window whereby a request to hold the transaction glock can get stuck. The problem is that after the DLM has granted the lock, it can get into a state whereby it doesn't transition the glock to a