Hi,
On 02/05/14 15:05, Bob Peterson wrote:
Hi,
This patch uses a completion to prevent dlm's recovery process from
referencing and trying to recover a journal before a journal has been
opened.
Regards,
Bob Peterson
Red Hat File Systems
There is one possible issue that I can see, which is the
The 'override' field wasn't being used at all and the 'quiet' field was
only being used by gfs2_jadd. Remove them in favour of keeping user
interface options in the apps themselves.
Signed-off-by: Andrew Price anpr...@redhat.com
---
gfs2/libgfs2/libgfs2.h | 2 --
gfs2/mkfs/main_jadd.c | 13
The utils were using the debug field to store their debug printing
options. Hide the debug field in a libgfs2-internal header to allow
switching on libgfs2 debugging output separately and switch the apps to
use their own debug options. In cases where apps were using sdp-debug
but not actually
mkfs.gfs2 and gfs2_jadd used struct gfs2_sbd.expert to put them into an
undocumented 'expert mode' but didn't really do anything useful in that
mode. Remove that field and other 'expert' references.
Signed-off-by: Andrew Price anpr...@redhat.com
---
gfs2/libgfs2/libgfs2.h | 2 --
In order to piece together the order in which fsck.gfs2 runs and
gfs2_edit savemeta were done it's useful to keep a log of the command
line options used and the fsck.gfs2 start and end times. Log these to
syslog.
Signed-off-by: Andrew Price anpr...@redhat.com
---
gfs2/fsck/main.c | 35
libgfs2 was exposing a logging API (log_info, etc.) but wasn't using it
itself. Remove the logging bits and move them into
gfs2/include/logging.h
Signed-off-by: Andrew Price anpr...@redhat.com
---
gfs2/convert/gfs2_convert.c | 2 ++
gfs2/edit/savemeta.c| 2 ++
gfs2/fsck/fs_recovery.c
Hi,
On 07/05/14 15:33, Andrew Price wrote:
In order to piece together the order in which fsck.gfs2 runs and
gfs2_edit savemeta were done it's useful to keep a log of the command
line options used and the fsck.gfs2 start and end times. Log these to
syslog.
Signed-off-by: Andrew Price
- Original Message -
mkfs.gfs2 and gfs2_jadd used struct gfs2_sbd.expert to put them into an
undocumented 'expert mode' but didn't really do anything useful in that
mode. Remove that field and other 'expert' references.
In the past, we've used mkfs.gfs2 expert mode to create certain
Hi,
Other patches in the series all look good to me,
Steve.
On 07/05/14 15:33, Andrew Price wrote:
libgfs2 was exposing a logging API (log_info, etc.) but wasn't using it
itself. Remove the logging bits and move them into
gfs2/include/logging.h
Signed-off-by: Andrew Price anpr...@redhat.com
