Re: [Cluster-devel] [PATCH][try6] VFS: new want_holesize and got_holesize buffer_head flags for fiemap

2014-10-22 Thread Christoph Hellwig
This looks like a big indicator that get_blocks is the wrong interface for fiemap.

Re: [Cluster-devel] [PATCH][try6] VFS: new want_holesize and got_holesize buffer_head flags for fiemap

2014-10-22 Thread Steven Whitehouse
Hi, On 22/10/14 07:04, Christoph Hellwig wrote: This looks like a big indicator that get_blocks is the wrong interface for fiemap. The question is then, what a better interface would look like? We could have get_hole as an extra operation I suppose. Not sure that I really see why thats

Re: [Cluster-devel] [PATCH][try6] VFS: new want_holesize and got_holesize buffer_head flags for fiemap

2014-10-22 Thread Bob Peterson
- Original Message - This looks like a big indicator that get_blocks is the wrong interface for fiemap. Hi Christoph, Yes, I thought about that. One of my early prototypes had a separate function used by fiemap. Function __generic_block_fiemap would call get_block() which returned an

Re: [Cluster-devel] [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports

2014-10-22 Thread Christoph Hellwig
On Tue, Oct 21, 2014 at 04:38:26PM +0200, Jan Kara wrote: Currently all filesystems supporting VFS quota support user and group quotas. With introduction of project quotas this is going to change so make sure filesystem isn't called for quota type it doesn't support by introduction of a

Re: [Cluster-devel] [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports

2014-10-22 Thread Jan Kara
On Wed 22-10-14 18:29:15, Christoph Hellwig wrote: On Tue, Oct 21, 2014 at 04:38:26PM +0200, Jan Kara wrote: Currently all filesystems supporting VFS quota support user and group quotas. With introduction of project quotas this is going to change so make sure filesystem isn't called for