[Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: Fix a use-after-free in pass2

2015-01-15 Thread Bob Peterson
Hi, This patch fixes a rare code path that's doing use-after-free I spotted in pass2. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com --- diff --git a/gfs2/fsck/pass2.c b/gfs2/fsck/pass2.c index 27b7336..4ea322a 100644 --- a/gfs2/fsck/pass2.c +++

Re: [Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: Reprocess nodes if anything changed

2015-01-15 Thread Abhijith Das
Hi, ACK. Cheers! --Abhi - Original Message - From: Bob Peterson rpete...@redhat.com To: cluster-devel cluster-devel@redhat.com Sent: Thursday, January 15, 2015 10:55:21 AM Subject: [Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: Reprocess nodes if anything changed Hi,

[Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: Reprocess nodes if anything changed

2015-01-15 Thread Bob Peterson
Hi, Before this patch, fsck.gfs2 called reprocess_inode in several places, especially when the number of blocks had changed from the original. That works in almost all cases. However, there's a corner case where a block may be deleted, due to errors (for example, a bad directory leaf), and

[Cluster-devel] [GFS2] fsck.gfs2: addendum to fix broken i_goal values in inodes

2015-01-15 Thread Abhi Das
This patch moves some code around and fixes some corner cases that the previous patches did not address. This patch also fixes some trailing whitespace and removes a test that is no longer valid from test/fsck.at Resolves: rhbz#1149516 Signed-off-by: Abhi Das a...@redhat.com ---

[Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: fix double-free bug

2015-01-15 Thread Bob Peterson
Hi, This patch fixes a double-free bug that can occur when errors are found in an inode and later, it's freed. The problem is that function free_metalist was using osi_list_del when removing buffer_heads from the inode in memory. It should be using osi_list_del_init so that the list head is