Re: [Cluster-devel] [PATCH 02/17] quota: Wire up -quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF}

2015-01-19 Thread Christoph Hellwig
On Fri, Jan 16, 2015 at 01:47:36PM +0100, Jan Kara wrote: Make Q_QUOTAON / Q_QUOTAOFF quotactl call -quota_enable / -quota_disable callback when provided. To match current behavior of ocfs2 ext4 we make these quotactls turn on / off quota enforcement for appropriate quota type.

Re: [Cluster-devel] [PATCH 01/17] quota: Split -set_xstate callback into two

2015-01-19 Thread Christoph Hellwig
On Fri, Jan 16, 2015 at 01:47:35PM +0100, Jan Kara wrote: Split -set_xstate callback into two callbacks - one for turning quotas on (-quota_enable) and one for turning quotas off (-quota_disable). That way we don't have to pass quotactl command into the callback which seems cleaner.

Re: [Cluster-devel] [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff

2015-01-19 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Cluster-devel] [PATCH 03/17] quota: Add -quota_{enable, disable} callbacks for VFS quotas

2015-01-19 Thread Christoph Hellwig
On Fri, Jan 16, 2015 at 01:47:37PM +0100, Jan Kara wrote: +EXPORT_SYMBOL(dquot_quota_enable); +EXPORT_SYMBOL(dquot_quota_disable); I can't find any modular users of this (in fact none outside this file), so I'd suggest to keep these local.

Re: [Cluster-devel] [PATCH 12/17] xfs: Convert to using -get_state callback

2015-01-19 Thread Christoph Hellwig
+static void xfs_qm_fill_state(struct qc_type_state *tstate, Normal xfs style would be to keep the static void on a separate line, as well as the arguments, e.g. static void xfs_qm_fill_state( struct qc_type_state*tstate, + struct xfs_mount *mp, +

Re: [Cluster-devel] [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing

2015-01-19 Thread Christoph Hellwig
On Fri, Jan 16, 2015 at 01:47:43PM +0100, Jan Kara wrote: Call -quota_sync method from Q_XQUOTASYNC for better userspace compatibility. Q_XQUOTASYNC never did the equivalent to -quota_sync, but rather was the equivalent to sys_syncfs which also happens to write out quotas. Unless you have a

Re: [Cluster-devel] [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff

2015-01-19 Thread Christoph Hellwig
On Fri, Jan 16, 2015 at 01:47:39PM +0100, Jan Kara wrote: Ocfs2 can just use the generic helpers provided by quota code for turning quotas on and off when quota files are stored as system inodes. The only difference is the feature test in ocfs2_quota_on() and that is covered by

Re: [Cluster-devel] [PATCH 14/17] quota: Remove -get_xstate and -get_xstatev callbacks

2015-01-19 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Cluster-devel] [PATCH 07/17] quota: Switch -get_dqblk() and -set_dqblk() to use bytes as space units

2015-01-19 Thread Christoph Hellwig
diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h index 18dc721ca19f..f718ba1f2ccb 100644 --- a/fs/xfs/libxfs/xfs_fs.h +++ b/fs/xfs/libxfs/xfs_fs.h @@ -559,18 +559,4 @@ typedef struct xfs_swapext /* XFS_IOC_GETFSUUID -- deprecated 140 */ -#ifndef

Re: [Cluster-devel] [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info

2015-01-19 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Cluster-devel] [PATCH 06/17] quota: Remove quota_on_meta callback

2015-01-19 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

[Cluster-devel] [fsck.gfs2 patch] fsck.gfs2: Rebuild system files if they don't have the SYS bit set

2015-01-19 Thread Bob Peterson
Hi, This patch checks for the GFS2_DIF_SYSTEM bit on system dinodes. If the bit is not set, the dinode is assumed to be corrupt and rebuilt. If the jindex is rebuilt, it needs to be re-read. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com --- diff

[Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: Check the integrity of the journal index

2015-01-19 Thread Bob Peterson
Hi, This patch checks the jindex system directory to make sure the entries all start with journal and so forth. If not, the jindex is deleted and rebuilt. As part of this patch, I moved where we read in the rindex file and rgrps to an earlier point in time, before the journals are replayed. This

[Cluster-devel] [fsck.gfs2 PATCH] fsck.gfs2: rgrp block count reform

2015-01-19 Thread Bob Peterson
Hi, In the past, pass5 has kept track of different counts for the different metadata types, but the counts did not correspond to the type in the bitmap. This patch changes pass5 so that it makes a little more sense. There should be a straightforward blockmap-to-bitmap conversion, and the counts