Re: [Cluster-devel] [PATCH 2/3] fsck.gfs2: Simplify bad_journalname

2015-01-28 Thread Bob Peterson
- Original Message - Remove the need for a temporary string and strncpy call by passing the length of the string to printf. Signed-off-by: Andrew Price anpr...@redhat.com --- gfs2/fsck/initialize.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [Cluster-devel] [PATCH 3/3] gfs2-utils build: Add a configure script summary

2015-01-28 Thread Bob Peterson
- Original Message - Print a nicely formatted summary of some of the more interesting configure options. Required some tweaking of earlier configure stages for accuracy. Signed-off-by: Andrew Price anpr...@redhat.com --- Hi, ACK Bob Peterson Red Hat File Systems

Re: [Cluster-devel] [PATCH 1/3] fsck.gfs2: Fix 'initializer element is not constant' build error

2015-01-28 Thread Bob Peterson
- Original Message - This error occurs when gfs2-utils is compiled with -std options more recent than gnu89: CC fsck_gfs2-main.o main.c:39:38: error: initializer element is not constant struct osi_root dup_blocks = (struct osi_root) { NULL, };

Re: [Cluster-devel] [PATCH 2/3] fsck.gfs2: Simplify bad_journalname

2015-01-28 Thread Andrew Price
On 28/01/15 13:13, Bob Peterson wrote: - Original Message - Remove the need for a temporary string and strncpy call by passing the length of the string to printf. Signed-off-by: Andrew Price anpr...@redhat.com --- gfs2/fsck/initialize.c | 8 ++-- 1 file changed, 2 insertions(+),