Re: [Cluster-devel] [PATCH] fs: record task name which froze superblock

2015-02-18 Thread Jan Kara
On Wed 18-02-15 10:34:55, Alexey Dobriyan wrote: On Mon, Feb 16, 2015 at 10:38:52AM +0100, Jan Kara wrote: On Sat 14-02-15 21:55:24, Alexey Dobriyan wrote: Freezing and thawing are separate system calls, task which is supposed to thaw filesystem/superblock can disappear due to crash or

Re: [Cluster-devel] [PATCH] fs: record task name which froze superblock

2015-02-18 Thread Steven Whitehouse
Hi, On 18/02/15 09:13, Jan Kara wrote: On Wed 18-02-15 10:34:55, Alexey Dobriyan wrote: On Mon, Feb 16, 2015 at 10:38:52AM +0100, Jan Kara wrote: On Sat 14-02-15 21:55:24, Alexey Dobriyan wrote: Freezing and thawing are separate system calls, task which is supposed to thaw

Re: [Cluster-devel] [PATCH 7/8] xfs: Add support for Q_SETINFO

2015-02-18 Thread Jan Kara
On Wed 18-02-15 08:54:12, Christoph Hellwig wrote: Looks fine except for the cosmetical argument alignment style issue. OK, fixed. Reviewed-by: Christoph Hellwig h...@lst.de Honza -- Jan Kara j...@suse.cz SUSE Labs, CR

Re: [Cluster-devel] [PATCH 8/8] quota: Hook up Q_XSETQLIM for id 0 to -set_info

2015-02-18 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Cluster-devel] [PATCH 7/8] xfs: Add support for Q_SETINFO

2015-02-18 Thread Christoph Hellwig
Looks fine except for the cosmetical argument alignment style issue. Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using -get_state callback

2015-02-18 Thread Christoph Hellwig
+static void +xfs_qm_fill_state( + struct qc_type_state *tstate, + struct xfs_mount *mp, + struct xfs_inode *ip, + xfs_ino_t ino) +/* + * Return quota status information, such as enforcements, quota file inode + * numbers etc. + */ +static int +xfs_fs_get_quota_state(

Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using -get_state callback

2015-02-18 Thread Jan Kara
On Wed 18-02-15 08:51:54, Christoph Hellwig wrote: +static void +xfs_qm_fill_state( + struct qc_type_state *tstate, + struct xfs_mount *mp, + struct xfs_inode *ip, + xfs_ino_t ino) +/* + * Return quota status information, such as enforcements, quota file inode + *

Re: [Cluster-devel] [PATCH 6/8] quota: Make -set_info use structure with neccesary info to VFS and XFS

2015-02-18 Thread Jan Kara
On Wed 18-02-15 08:53:34, Christoph Hellwig wrote: On Wed, Feb 18, 2015 at 02:47:52PM +0100, Jan Kara wrote: Change -set_info to take new qc_info structure which contains all the necessary information both for XFS and VFS. Convert Q_SETINFO handler to use this structure. ... +/* Structure

[Cluster-devel] [PATCH 0/8 v5] quota: Unify VFS and XFS quota interfaces

2015-02-18 Thread Jan Kara
Hello, these are outstanding patches in my series unifying VFS and XFS quota interfaces so that XFS quotactls work for filesystems with VFS quotas and vice versa. This is useful so that userspace doesn't have to care that much about which filesystem it is using at least when using basic

[Cluster-devel] [PATCH 3/8] xfs: Convert to using -get_state callback

2015-02-18 Thread Jan Kara
Convert xfs to use -get_state callback instead of -get_xstate and -get_xstatev. Signed-off-by: Jan Kara j...@suse.cz --- fs/xfs/xfs_qm.h | 4 -- fs/xfs/xfs_qm_syscalls.c | 176 --- fs/xfs/xfs_quotaops.c| 98 +++--- 3

[Cluster-devel] [PATCH 7/8] xfs: Add support for Q_SETINFO

2015-02-18 Thread Jan Kara
Add support to XFS so that time limits can be set through Q_SETINFO quotactl. Signed-off-by: Jan Kara j...@suse.cz --- fs/xfs/xfs_quotaops.c | 37 + 1 file changed, 37 insertions(+) diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c index

[Cluster-devel] [PATCH 1/8] quota: Make VFS quotas use new interface for getting quota info

2015-02-18 Thread Jan Kara
Create new internal interface for getting information about quota which contains everything needed for both VFS quotas and XFS quotas. Make VFS use this and hook it up to Q_GETINFO. Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Jan Kara j...@suse.cz --- fs/ext3/super.c | 2

[Cluster-devel] [PATCH 8/8] quota: Hook up Q_XSETQLIM for id 0 to -set_info

2015-02-18 Thread Jan Kara
Setting timers or warning counts for id 0 via Q_XSETQLIM is used to actually set time limits and warning limits for all users. Hook up -set_info to this so that VFS quota time limits get set the same way as XFS ones. When doing this Q_XSETQLIM for XFS is effectively split into two independent

[Cluster-devel] [PATCH 6/8] quota: Make -set_info use structure with neccesary info to VFS and XFS

2015-02-18 Thread Jan Kara
Change -set_info to take new qc_info structure which contains all the necessary information both for XFS and VFS. Convert Q_SETINFO handler to use this structure. Signed-off-by: Jan Kara j...@suse.cz --- fs/quota/dquot.c | 27 --- fs/quota/quota.c | 21

[Cluster-devel] [PATCH 4/8] gfs2: Convert to using -get_state callback

2015-02-18 Thread Jan Kara
Convert gfs2 to use -get_state callback instead of -get_xstate. Signed-off-by: Jan Kara j...@suse.cz --- fs/gfs2/quota.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 3e193cb36996..c76e031ccbb4 100644

[Cluster-devel] [PATCH 5/8] quota: Remove -get_xstate and -get_xstatev callbacks

2015-02-18 Thread Jan Kara
These callbacks are now unused. Remove them. Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Jan Kara j...@suse.cz --- fs/quota/quota.c | 14 -- include/linux/quota.h | 2 -- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/fs/quota/quota.c

[Cluster-devel] [PATCH 2/8] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with -get_state

2015-02-18 Thread Jan Kara
Add appropriate conversion functions so that filesystems supporting -get_state() method can be queried using Q_GETXSTATE and Q_GETXSTATV calls. Reviewed-by: Christoph Hellwig h...@lst.de Signed-off-by: Jan Kara j...@suse.cz --- fs/quota/quota.c | 138

Re: [Cluster-devel] [PATCH 4/8] gfs2: Convert to using -get_state callback

2015-02-18 Thread Bob Peterson
- Original Message - Convert gfs2 to use -get_state callback instead of -get_xstate. Signed-off-by: Jan Kara j...@suse.cz --- fs/gfs2/quota.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c