Re: [Cluster-devel] GFS2: Pull request (merge window)

2015-04-15 Thread Bob Peterson
- Original Message - On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson rpete...@redhat.com wrote: 12 files changed, 184 insertions(+), 95 deletions(-) Oh, and this was incorrect. You had apparently limited the statistics to the fs/gfs2 directory, and thus missed the changes to the

[Cluster-devel] GFS2: Patches pulled, linux-gfs2.git rebased

2015-04-15 Thread Bob Peterson
Hi, Linus has pulled the latest set of patches from the for-next branch of the linux-gfs2.git tree, so I rebased the tree based on Linus's master. So the current tree is back to having no unmerged GFS2 patches. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [GFS2] fsck.gfs2: replace recent i_goal fixes with simple logic

2015-04-15 Thread Abhi Das
This patch reverses the recent set of i_goal fixes for fsck.gfs2. This is because of two problems. 1. It is not possible to determine if a valid block within the fs is the correct goal block for a given inode. 2. Conversely, given an inode, it is also not possible to accurately determine what its

[Cluster-devel] [GFS2 PATCH] GFS2: Use average srttb value in congestion calculations

2015-04-15 Thread Bob Peterson
Hi, This patch changes function gfs2_rgrp_congested so that it uses an average srttb (smoothed round trip time for blocking rgrp glocks) rather than the CPU-specific value. If we use the CPU-specific value it can incorrectly report no contention when there really is contention due to the glock

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Use average srttb value in congestion calculations

2015-04-15 Thread Steven Whitehouse
Hi, On 15/04/15 15:39, Bob Peterson wrote: Hi, This patch changes function gfs2_rgrp_congested so that it uses an average srttb (smoothed round trip time for blocking rgrp glocks) rather than the CPU-specific value. If we use the CPU-specific value it can incorrectly report no contention when

Re: [Cluster-devel] [GFS2] fsck.gfs2: replace recent i_goal fixes with simple logic

2015-04-15 Thread Andrew Price
Hi Abhi, On 15/04/15 14:37, Abhi Das wrote: This patch reverses the recent set of i_goal fixes for fsck.gfs2. This is because of two problems. 1. It is not possible to determine if a valid block within the fs is the correct goal block for a given inode. 2. Conversely, given an inode, it is also

Re: [Cluster-devel] [PATCH] GFS2: make sure S_NOSEC flag isn't overwritten

2015-04-15 Thread Bob Peterson
Hi, - Original Message - At the end of gfs2_set_inode_flags inode-i_flags is set to flags, so we should be mondifying flags instead of inode-i_flags, so it isn't Patch looks good, but mondifying looks like a type and should probably be fixed. Regards, Bob Peterson Red Hat File

Re: [Cluster-devel] [PATCH] GFS2: add support for rename2 and RENAME_EXCHANGE

2015-04-15 Thread Bob Peterson
Hi, Looks good to me except for a few nits: (snip) Just a suggestion, but can you add a function comment at the start of this function? +static int gfs2_exchange(struct inode *odir, struct dentry *odentry, + struct inode *ndir, struct dentry *ndentry, +

[Cluster-devel] [PATCH] GFS2: make sure S_NOSEC flag isn't overwritten

2015-04-15 Thread Benjamin Marzinski
At the end of gfs2_set_inode_flags inode-i_flags is set to flags, so we should be mondifying flags instead of inode-i_flags, so it isn't overwritten. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com --- fs/gfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Cluster-devel] [PATCH] GFS2: add support for rename2 and RENAME_EXCHANGE

2015-04-15 Thread Benjamin Marzinski
gfs2 now uses the rename2 directory iop, and supports the RENAME_EXCHANGE flag (as well as RENAME_NOREPLACE, which the vfs takes care of). Signed-off-by: Benjamin Marzinski bmarz...@redhat.com --- fs/gfs2/inode.c | 192 +++- 1 file changed, 177

[Cluster-devel] [PATCH v2] GFS2: make sure S_NOSEC flag isn't overwritten

2015-04-15 Thread Benjamin Marzinski
At the end of gfs2_set_inode_flags inode-i_flags is set to flags, so we should be modifying flags instead of inode-i_flags, so it isn't overwritten. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com --- fs/gfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Cluster-devel] [PATCH v2] GFS2: add support for rename2 and RENAME_EXCHANGE

2015-04-15 Thread Benjamin Marzinski
gfs2 now uses the rename2 directory iop, and supports the RENAME_EXCHANGE flag (as well as RENAME_NOREPLACE, which the vfs takes care of). Signed-off-by: Benjamin Marzinski bmarz...@redhat.com --- fs/gfs2/inode.c | 205 +++- 1 file changed, 189

Re: [Cluster-devel] GFS2: Pull request (merge window)

2015-04-15 Thread Steven Whitehouse
Hi, On 15/04/15 00:16, Linus Torvalds wrote: On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson rpete...@redhat.com wrote: There's another that adds me as a GFS2 co-maintainer [...] So generally, when I start getting pull requests from different people, I'd like to see a previous separate