[Cluster-devel] [GFS2] gfs2: handle NULL rgd in set_rgrp_preferences

2015-05-05 Thread Abhi Das
The function set_rgrp_preferences() does not handle the (rarely returned) NULL value from gfs2_rgrpd_get_next() and this patch fixes that. The fs image in question is only 150MB in size which allows for only 1 rgrp to be created. The in-memory rb tree has only 1 node and when

Re: [Cluster-devel] [PATCH v2] GFS2: add support for rename2 and RENAME_EXCHANGE

2015-05-05 Thread Bob Peterson
- Original Message - gfs2 now uses the rename2 directory iop, and supports the RENAME_EXCHANGE flag (as well as RENAME_NOREPLACE, which the vfs takes care of). Signed-off-by: Benjamin Marzinski bmarz...@redhat.com Hi, Thanks. V2 patch is now in the upstream tree:

[Cluster-devel] [PATCH V3 linux-next] gfs2: convert simple_str to kstr

2015-05-05 Thread Fabian Frederick
-Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Thanks to Alexey Dobriyan for suggesting improvements in block_store() and wdack_store() Signed-off-by: Fabian Frederick f...@skynet.be --- V3: -Compare

Re: [Cluster-devel] [GFS2] gfs2: handle NULL rgd in set_rgrp_preferences

2015-05-05 Thread Bob Peterson
- Original Message - The function set_rgrp_preferences() does not handle the (rarely returned) NULL value from gfs2_rgrpd_get_next() and this patch fixes that. The fs image in question is only 150MB in size which allows for only 1 rgrp to be created. The in-memory rb tree has only 1

Re: [Cluster-devel] [PATCH V2 linux-next] gfs2: convert simple_str to kstr

2015-05-05 Thread Fabian Frederick
On 05 May 2015 at 15:56 Bob Peterson rpete...@redhat.com wrote: Hi, Comments below. - Original Message - -Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Thanks to Alexey

Re: [Cluster-devel] [PATCH v2] GFS2: make sure S_NOSEC flag isn't overwritten

2015-05-05 Thread Bob Peterson
- Original Message - At the end of gfs2_set_inode_flags inode-i_flags is set to flags, so we should be mondifying flags instead of inode-i_flags, so it isn't overwritten. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com --- Hi, The v2 version of the patch is now in the

Re: [Cluster-devel] [PATCH V3 linux-next] gfs2: convert simple_str to kstr

2015-05-05 Thread Bob Peterson
- Original Message - -Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Thanks to Alexey Dobriyan for suggesting improvements in block_store() and wdack_store() Signed-off-by: Fabian