Re: [Cluster-devel] [GFS2 PATCH] GFS2: Don't brelse rgrp buffer_heads every allocation

2015-06-16 Thread Bob Peterson
- Original Message - I'll see if I can track down why the rgrplvb option isn't performing as well. I suspect the matter goes back to my first comment above. Namely, that the slowdown goes back to the slowness of page cache lookup for the buffers of the rgrps we are using (not rejected

[Cluster-devel] [GFS2 PATCH] GFS2: Don't add all glocks to the lru

2015-06-16 Thread Bob Peterson
Hi, Regarding my previously posted patch: I decided it makes more sense not to single out rgrp glocks for exclusion from the lru list. It makes sense to also exclude the transaction glock, and non-disk glocks off the lru list as well. Therefore, I changed this to a generic glops flag so we could

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-16 Thread Guoqing Jiang
Hi David, David Teigland wrote: On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: Do you consider take the following clean up? If yes, I will send a formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Don't brelse rgrp buffer_heads every allocation

2015-06-16 Thread Steven Whitehouse
Hi, On 15/06/15 15:43, Bob Peterson wrote: - Original Message - I'm assuming that these figures are bandwidth rather than times, since that appears to show that the patch makes quite a large difference. However the reclen is rather small. In the 32 bytes case, thats 128 writes for each