Re: [Cluster-devel] [PATCH] nfsd: add a new EXPORT_OP_NOWCC flag to struct export_operations

2015-09-11 Thread Jeff Layton
On Fri, 11 Sep 2015 17:29:57 -0400 "J. Bruce Fields" wrote: > On Fri, Sep 11, 2015 at 06:20:30AM -0400, Jeff Layton wrote: > > With NFSv3 nfsd will always attempt to send along WCC data to the > > client. This generally involves saving off the in-core inode information > > prior to doing the oper

Re: [Cluster-devel] [PATCH] nfsd: add a new EXPORT_OP_NOWCC flag to struct export_operations

2015-09-11 Thread J. Bruce Fields
On Fri, Sep 11, 2015 at 06:20:30AM -0400, Jeff Layton wrote: > With NFSv3 nfsd will always attempt to send along WCC data to the > client. This generally involves saving off the in-core inode information > prior to doing the operation on the given filehandle, and then issuing a > vfs_getattr to it

[Cluster-devel] [PATCH] gfs2_lockcapture: Fix condition where dlm lockspaces parsing failed

2015-09-11 Thread sbradley
From: Shane Bradley The output of `dlm_tool ls` was not parsed correctly on dlm_tool version 3.0 or higher. The patch now parses correctly `dlm_tool ls` output from version 2.0 or higher. Signed-off-by: Shane Bradley --- gfs2/scripts/gfs2_lockcapture | 35 ++-

Re: [Cluster-devel] gfs2 on-disk headers in user space

2015-09-11 Thread Andrew Price
On 11/09/15 12:40, Andreas Grünbacher wrote: 2015-09-11 13:28 GMT+02:00 Andrew Price : That makes sense to me. I assume we would remove the #include from gfs2_ondisk.h and replace it with our own user space types header. I'm worried about clashes using the kernel type names though, so we might

Re: [Cluster-devel] gfs2 on-disk headers in user space

2015-09-11 Thread Andreas Grünbacher
2015-09-11 13:28 GMT+02:00 Andrew Price : > That makes sense to me. I assume we would remove the #include > from gfs2_ondisk.h and replace it with our own user space > types header. I'm worried about clashes using the kernel type names though, > so we might need to process the header somehow to ch

[Cluster-devel] [PATCH 1/2] fsck.gfs2: Really be quiet in quiet mode

2015-09-11 Thread Andrew Price
Using the -q option leaves some informational messages still printed as they're using log_warn. Switch them to log_notice so that they're not printed when -q is used. Signed-off-by: Andrew Price --- gfs2/fsck/initialize.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Cluster-devel] [PATCH 2/2] fsck.gfs2: Improve read ahead in pass1_process_bitmap

2015-09-11 Thread Andrew Price
The read ahead strategy in this function was pretty naive, it just read in all of the inode blocks, in block-sized reads, before doing any processing. In my tests with a full filesystem, removing this read ahead actually sped up the tests, presumably due to issuing a large number of small I/Os and

Re: [Cluster-devel] gfs2 on-disk headers in user space

2015-09-11 Thread Andrew Price
On 11/09/15 12:02, Andreas Gruenbacher wrote: 2015-09-11 12:45 GMT+02:00 Andrew Price : Yes, I think ideally we should have a set of userspace structures to keep things separate. Building gfs2-utils currently also depends on /usr/include/linux/gfs2_ondisk.h, so when building on an old system,

Re: [Cluster-devel] [PATCH 2/2] gfs2_edit: Include dirent.de_rahead in directory listings

2015-09-11 Thread Andreas Gruenbacher
2015-09-11 12:45 GMT+02:00 Andrew Price : > Yes, I think ideally we should have a set of userspace structures to keep > things separate. Building gfs2-utils currently also depends on /usr/include/linux/gfs2_ondisk.h, so when building on an old system, some features will be disabled. It would be mo

Re: [Cluster-devel] [PATCH 2/2] gfs2_edit: Add attribute printf for print_gfs2

2015-09-11 Thread Andrew Price
On 10/09/15 23:05, Andreas Gruenbacher wrote: Add the appropriate function attribute for the printf-style function print_gfs2 and clean up the resulting fallout. Both patches look good to me, thanks. I've pushed them both along with the savemeta speedup patch I posted last week. Andy Signe

Re: [Cluster-devel] [PATCH 2/2] gfs2_edit: Include dirent.de_rahead in directory listings

2015-09-11 Thread Andrew Price
On 10/09/15 23:04, Andreas Gruenbacher wrote: 2015-09-09 18:27 GMT+02:00 Andrew Price : It would be better to use %u for an unsigned int. We don't have __attribute__((format(printf...))) on print_gfs2 yet but it would catch that. I've tried adding the printf format attribute; it's quite a mess

[Cluster-devel] [PATCH] nfsd: add a new EXPORT_OP_NOWCC flag to struct export_operations

2015-09-11 Thread Jeff Layton
With NFSv3 nfsd will always attempt to send along WCC data to the client. This generally involves saving off the in-core inode information prior to doing the operation on the given filehandle, and then issuing a vfs_getattr to it after the op. Some filesystems (particularly clustered or networked