Re: [Cluster-devel] [PATCH] GFS2: Hold gl_hash_table bucket locks in glock_hash_walk

2015-11-13 Thread Andrew Price
On 12/11/15 20:38, Steven Whitehouse wrote: Hi, On 12/11/15 20:11, Bob Peterson wrote: - Original Message - This lockdep splat was being triggered on umount: [55715.973122] === [55715.980169] [ INFO: suspicious RCU usage. ] [55715.981021]

Re: [Cluster-devel] [PATCH v2] GFS2: Use rht_for_each_entry_rcu in glock_hash_walk

2015-11-13 Thread Steven Whitehouse
Hi, Looks good... Acked-by: Steven Whitehouse Steve. On 13/11/15 12:16, Andrew Price wrote: This lockdep splat was being triggered on umount: [55715.973122] === [55715.980169] [ INFO: suspicious RCU usage. ] [55715.981021]

Re: [Cluster-devel] [PATCH 2/2] gfs2: Extended attribute readahead optimization

2015-11-13 Thread Andreas Gruenbacher
On Thu, Nov 12, 2015 at 9:33 PM, Steven Whitehouse wrote: > That looks good to me, and I assume that it should be faster too? I did some tests with a directory tree with 3439 directories and 51556 files in it. In that tree, 47313 or 86% of the 54995 files and directories

Re: [Cluster-devel] [PATCH v2] GFS2: Use rht_for_each_entry_rcu in glock_hash_walk

2015-11-13 Thread Bob Peterson
- Original Message - > This lockdep splat was being triggered on umount: > > [55715.973122] === > [55715.980169] [ INFO: suspicious RCU usage. ] > [55715.981021] 4.3.0-11553-g8d3de01-dirty #15 Tainted: GW > [55715.982353] ---

Re: [Cluster-devel] [PATCH] GFS2: Delete an unnecessary check before the function call "iput"

2015-11-13 Thread Bob Peterson
- Original Message - > From: Markus Elfring > Date: Wed, 4 Nov 2015 21:23:43 +0100 > > The iput() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using

Re: [Cluster-devel] [PATCH 2/2] gfs2: Extended attribute readahead optimization

2015-11-13 Thread Bob Peterson
- Original Message - > Here is an updated version of this patch, please review. > > Thanks, > Andreas > > -- > > Instead of submitting a READ_SYNC bio for the inode and a READA bio for > the inode's extended attributes through submit_bh, submit a single READ > bio for both strough