Re: [Cluster-devel] [GFS2 PATCH v4 0/3] Fix erroneous ETXTBSY problems with GFS2

2015-11-25 Thread Steven Whitehouse
Hi, Looks good to me... Acked-by: Steven Whitehouse Steve. On 24/11/15 19:36, Bob Peterson wrote: Hi, On 19 November, I posted an earlier "v3" version of this 3-patch set. Since then, I've uncovered more problems in testing and re-reviewing. This is a revised version

Re: [Cluster-devel] [GFS2 PATCH 1/2] GFS2: Make gfs2_clear_inode() queue the final put

2015-11-25 Thread Steven Whitehouse
Hi, On 25/11/15 14:22, Bob Peterson wrote: - Original Message - Hi, On 19/11/15 18:42, Bob Peterson wrote: This patch changes function gfs2_clear_inode() so that instead of calling gfs2_glock_put directly() most of the time, it queues the glock to the delayed work queue. That avoids

Re: [Cluster-devel] [GFS2 PATCH 2/2] GFS2: Revert 35e478f Flush pending glock work when evicting an inode

2015-11-25 Thread Bob Peterson
Hi, - Original Message - > Hi, > > On 19/11/15 18:42, Bob Peterson wrote: > > Commit 35e478f was added because there were cases where > > the inode's glock still had pending delayed work. > > The theory is that the delayed work referenced the inode after it > > had been deleted from

Re: [Cluster-devel] [GFS2 PATCH 1/2] GFS2: Make gfs2_clear_inode() queue the final put

2015-11-25 Thread Bob Peterson
- Original Message - > Hi, > > On 19/11/15 18:42, Bob Peterson wrote: > > This patch changes function gfs2_clear_inode() so that instead > > of calling gfs2_glock_put directly() most of the time, it queues > > the glock to the delayed work queue. That avoids a possible > > deadlock where