Re: [Cluster-devel] [DLM PATCH 0/6] Misc DLM Improvements Regarding Socket Errors

2016-02-11 Thread David Teigland
On Thu, Feb 11, 2016 at 01:39:09PM -0500, Bob Peterson wrote: > The problem is: While testing the dlm in multiple recovery situations, > Nate and I discovered multiple problems. Until recently, no one has tried > to run recovery tests on an upstream DLM, (Let's distinguish tcp connection

[Cluster-devel] [DLM PATCH] DLM: Don't try to cancel pending work from free_conn

2016-02-11 Thread Bob Peterson
Hi, This patch changes function free_conn so that it calls function close_connection with the last two parameters false, false rather than true, true. These parameters indicate close_connection should cancel pending work on the send and receive workqueues respectively. The trouble is, free_conn

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Delay glock disposal by way of a rubbish list

2016-02-11 Thread Steven Whitehouse
Hi, On 10/02/16 19:59, Bob Peterson wrote: Hi, - Original Message - Hi, On 18/12/15 18:42, Bob Peterson wrote: Hi, This patch introduces a new glock workqueue, gfs2_glock_final. The workqueue merely does work to call dlm's unlock. This prevents gfs2_evict_inode from calling dlm

Re: [Cluster-devel] [DLM PATCH 6/6] DLM: save / restore all socket callbacks

2016-02-11 Thread Steven Whitehouse
Hi, On 10/02/16 18:55, Bob Peterson wrote: Before this patch, DLM was saving off the original error report callback before setting its own, but it never restored it. Instead, we should be saving off all four socket callbacks before changing them, and then restore them once we're done.

Re: [Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path

2016-02-11 Thread Andreas Gruenbacher
Bob, On Thu, Feb 11, 2016 at 6:59 PM, Bob Peterson wrote: > - Original Message - >> > +out_err: >> > + sock_release(sock); >> > + sock = NULL; >> > + con->sock = NULL; >> >> Consolidating the error paths makes sense, but con->sock shouldn't be >>

Re: [Cluster-devel] [DLM PATCH 2/6] DLM: Call original error report when socket is NULL

2016-02-11 Thread Andreas Gruenbacher
On Wed, Feb 10, 2016 at 7:55 PM, Bob Peterson wrote: > This patch removes a "return" statement from lowcomms_error_report. > It need to call the original error report in all paths through the > function. > > Signed-off-by: Bob Peterson Reviewed-by:

Re: [Cluster-devel] [DLM PATCH 6/6][try #2] DLM: save / restore all socket callbacks

2016-02-11 Thread Bob Peterson
Hi Steve, - Original Message - > Might be clearer to move the test for CF_IS_OTHERCON outside of these > functions and into the callers? > > Otherwise these patches look like a good set of clean ups, > > Steve. Good idea. Here's a replacement patch that implements your suggestion.

Re: [Cluster-devel] [DLM PATCH 5/6] DLM: Add locking to protect save callback assignments

2016-02-11 Thread Andreas Gruenbacher
On Wed, Feb 10, 2016 at 7:55 PM, Bob Peterson wrote: > This patch adds write_lock_bh locking to several places in the code > that save and restore the socket callbacks. > > Signed-off-by: Bob Peterson > --- > fs/dlm/lowcomms.c | 35

Re: [Cluster-devel] [DLM PATCH 0/6] Misc DLM Improvements Regarding Socket Errors

2016-02-11 Thread Andreas Gruenbacher
On Wed, Feb 10, 2016 at 7:55 PM, Bob Peterson wrote: > I've been doing a bunch of recovery testing with DLM and discovered some > issues. This collection of 6 patches addresses those issues. Some of them > are of my own making, introduced by the recent patches that made DLM >

Re: [Cluster-devel] [DLM PATCH 6/6][try #2] DLM: save / restore all socket callbacks

2016-02-11 Thread Andreas Gruenbacher
On Thu, Feb 11, 2016 at 5:43 PM, Bob Peterson wrote: > Hi Steve, > > - Original Message - >> Might be clearer to move the test for CF_IS_OTHERCON outside of these >> functions and into the callers? >> >> Otherwise these patches look like a good set of clean ups, >> >>

Re: [Cluster-devel] [DLM PATCH 4/6] DLM: Eliminate useless goto

2016-02-11 Thread Andreas Gruenbacher
On Wed, Feb 10, 2016 at 7:55 PM, Bob Peterson wrote: > This patch simply removes a goto from function sctp_listen_for_all. > The end result is the same, but makes the code more readable. > > Signed-off-by: Bob Peterson > --- > fs/dlm/lowcomms.c | 3 +--

Re: [Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path through tcp_create_listen_sock

2016-02-11 Thread Andreas Gruenbacher
On Wed, Feb 10, 2016 at 7:55 PM, Bob Peterson wrote: > Function tcp_create_listen_sock has two error paths. One of them > was setting con->sock to NULL. The other was not. This patch changes > it to be consistent and do the same thing for both error paths. > > Signed-off-by:

Re: [Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path through tcp_create_listen_sock

2016-02-11 Thread Bob Peterson
- Original Message - > > +out_err: > > + sock_release(sock); > > + sock = NULL; > > + con->sock = NULL; > > Consolidating the error paths makes sense, but con->sock shouldn't be > set here at all; the caller does that in add_sock(). > > Thanks, > Andreas > Hi Andreas,

Re: [Cluster-devel] [DLM PATCH 0/6] Misc DLM Improvements Regarding Socket Errors

2016-02-11 Thread David Teigland
On Wed, Feb 10, 2016 at 01:55:26PM -0500, Bob Peterson wrote: > I've been doing a bunch of recovery testing with DLM and discovered some > issues. This collection of 6 patches addresses those issues. Some of them > are of my own making, introduced by the recent patches that made DLM > print socket

Re: [Cluster-devel] [DLM PATCH 0/6] Misc DLM Improvements Regarding Socket Errors

2016-02-11 Thread Bob Peterson
- Original Message - > On Wed, Feb 10, 2016 at 01:55:26PM -0500, Bob Peterson wrote: > > I've been doing a bunch of recovery testing with DLM and discovered some > > issues. This collection of 6 patches addresses those issues. Some of them > > are of my own making, introduced by the recent