Re: [Cluster-devel] [GFS2 PATCH] GFS2: Fix up some sparse warnings

Hi Andy, Comments inline. - Original Message - | On Fri, Aug 18, 2017 at 10:20:56AM -0400, Bob Peterson wrote: | > Hi, | > | > This patch cleans up various pieces of GFS2 to avoid sparse errors. | > This doesn't fix them all, but it fixes several. The first error, | > in function

Re: [Cluster-devel] [PATCH 10/17] dlm: use schedule_timeout instead of schedule in dlm_recoverd

On Thu, Aug 17, 2017 at 11:40:13PM +, tsutomu@toshiba.co.jp wrote: > If you refer to other implementations in kernel, the following > modifications may be better. > The important thing is to call kthread_should_stop() after > set_current_state(TASK_INTERRUPTIBLE). How is this fix?

Re: [Cluster-devel] [PATCH] gfs2: Silence gcc format-truncation warning

- Original Message - | Enlarge sd_fsname to be big enough for the longest long lock table name | and an arbitrary journal number. This silences two -Wformat-truncation | warnings with gcc 7.1.1. | | Signed-off-by: Andreas Gruenbacher | --- Hi, Thanks. This is now

[Cluster-devel] [PATCH] gfs2: Silence gcc format-truncation warning

Enlarge sd_fsname to be big enough for the longest long lock table name and an arbitrary journal number. This silences two -Wformat-truncation warnings with gcc 7.1.1. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/incore.h | 2 +- fs/gfs2/ops_fstype.c | 6 +++--- 2