Re: [Cluster-devel] [GFS2 PATCH] gfs2: Return all reservations when rgrp_brelse is called

2018-07-13 Thread Steven Whitehouse
On 13/07/18 21:26, Bob Peterson wrote: Hi, Before this patch, function gfs2_rgrp_brelse would release its buffer_heads for the rgrp bitmaps, but it did not release its reservations. The problem is: When we need to call brelse, we're basically letting go of the bitmaps, which means our reserva

[Cluster-devel] [GFS2 PATCH] gfs2: Return all reservations when rgrp_brelse is called

2018-07-13 Thread Bob Peterson
Hi, Before this patch, function gfs2_rgrp_brelse would release its buffer_heads for the rgrp bitmaps, but it did not release its reservations. The problem is: When we need to call brelse, we're basically letting go of the bitmaps, which means our reservations are no longer valid: someone on anothe

[Cluster-devel] [PATCH v2] gfs2: Fix gfs2_testbit to use clone bitmaps

2018-07-13 Thread Bob Peterson
Hi, The previous version of my patch had a bug. Apparently function gfs2_check_blk_type does need to check the non-clone bitmap. The other two callers need to check the clone bitmap, if available. So this version adds a parameter to specify. Also, I got rid of function gfs2_get_block_type() in fav

[Cluster-devel] [PATCH 1/2] gfs2: Pass write offset to gfs2_write_calc_reserv

2018-07-13 Thread Andreas Gruenbacher
Pass the offset of the write to gfs2_write_calc_reserv so that we can then compute a better upper bound of the number of indirect blocks required. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/bmap.c | 4 ++-- fs/gfs2/bmap.h | 2 ++ fs/gfs2/file.c | 12 ++-- fs/gfs2/quota.c | 30 ++

[Cluster-devel] [PATCH 2/2] gfs2: Rewrite gfs2_write_calc_reserv

2018-07-13 Thread Andreas Gruenbacher
For normal writes, replace the existing version of gfs2_write_calc_reserv with one that takes the offset of the write into account. This allows to determine a lower bound for the maximum number of indirect blocks required. For __gfs2_fallocate, since gfs2_write_calc_reserv and calc_max_reserv are

[Cluster-devel] [gfs2:write-calc 6/6] fs//gfs2/bmap.c:2516:3: note: in expansion of macro 'do_div'

2018-07-13 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git write-calc head: d2bc11581b0f53bb8b1f6599b18485f1d51971f6 commit: d2bc11581b0f53bb8b1f6599b18485f1d51971f6 [6/6] gfs2: Rewrite gfs2_write_calc_reserv config: mips-allyesconfig (attached as .config) compiler: mips-linux-

Re: [Cluster-devel] [PATCH 5/6] iomap: add a page_done callback

2018-07-13 Thread Goldwyn Rodrigues
On 18:41 19/06, Christoph Hellwig wrote: > This will be used by gfs2 to attach data to transactions for the journaled > data mode. But the concept is generic enough that we might be able to > use it for other purposes like encryption/integrity post-processing in the > future. > > Based on a patch