Re: [Cluster-devel] [PATCH V10 02/19] block: introduce bio_for_each_bvec()

2018-11-18 Thread Ming Lei
On Fri, Nov 16, 2018 at 02:30:28PM +0100, Christoph Hellwig wrote: > > +static inline void __bio_advance_iter(struct bio *bio, struct bvec_iter > > *iter, > > + unsigned bytes, bool mp) > > I think these magic 'bool np' arguments and wrappers over wrapper > don't

Re: [Cluster-devel] [PATCH V10 01/19] block: introduce multi-page page bvec helpers

2018-11-18 Thread Ming Lei
On Sun, Nov 18, 2018 at 08:10:14PM -0700, Jens Axboe wrote: > On 11/18/18 7:23 PM, Ming Lei wrote: > > On Fri, Nov 16, 2018 at 02:13:05PM +0100, Christoph Hellwig wrote: > >>> -#define bvec_iter_page(bvec, iter) \ > >>> +#define mp_bvec_iter_page(bvec, iter)

Re: [Cluster-devel] [PATCH V10 01/19] block: introduce multi-page page bvec helpers

2018-11-18 Thread Jens Axboe
On 11/18/18 7:23 PM, Ming Lei wrote: > On Fri, Nov 16, 2018 at 02:13:05PM +0100, Christoph Hellwig wrote: >>> -#define bvec_iter_page(bvec, iter) \ >>> +#define mp_bvec_iter_page(bvec, iter) \ >>> (__bvec_iter_bvec((bvec), (iter))->bv_page)

Re: [Cluster-devel] [PATCH V10 01/19] block: introduce multi-page page bvec helpers

2018-11-18 Thread Ming Lei
On Thu, Nov 15, 2018 at 10:25:59AM -0800, Omar Sandoval wrote: > On Thu, Nov 15, 2018 at 04:52:48PM +0800, Ming Lei wrote: > > This patch introduces helpers of 'mp_bvec_iter_*' for multipage > > bvec support. > > > > The introduced helpers treate one bvec as real multi-page segment, > > which may

Re: [Cluster-devel] [PATCH V10 01/19] block: introduce multi-page page bvec helpers

2018-11-18 Thread Ming Lei
On Fri, Nov 16, 2018 at 02:13:05PM +0100, Christoph Hellwig wrote: > > -#define bvec_iter_page(bvec, iter) \ > > +#define mp_bvec_iter_page(bvec, iter) \ > > (__bvec_iter_bvec((bvec), (iter))->bv_page) > > > > -#define bvec_iter_len(bvec,

[Cluster-devel] [PATCH] dlm_controld: fix pkg-config call for cross build

2018-11-18 Thread Valentin Vidic
From: Helmut Grohne dlm fails to cross build from source, because the upstream Makefile hard codes the build architecture pkg-config. The attached patch makes pkg-config substitutable. Signed-off-by: Valentin Vidic --- dlm_controld/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2