[Cluster-devel] [GFS2 PATCH 4/4] gf2: Rename gfs2_trans_{add_unrevoke => remove_revoke}

2019-04-05 Thread Andreas Gruenbacher
Rename gfs2_trans_add_unrevoke to gfs2_trans_remove_revoke: there is no such thing as an "unrevoke" object; all this function does is remove existing revoke objects plus some bookkeeping. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/bmap.c | 4 ++-- fs/gfs2/dir.c | 2 +- fs/gfs2/rgrp.c |

[Cluster-devel] [GFS2 PATCH 3/4] gfs2: Rename sd_log_le_{revoke, ordered}

2019-04-05 Thread Andreas Gruenbacher
Rename sd_log_le_revoke to sd_log_revokes and sd_log_le_ordered to sd_log_ordered: not sure what le stands for here, but it doesn't add clarity, and if it stands for list entry, it's actually confusing as those are both list heads but not list entries. Signed-off-by: Andreas Gruenbacher ---

[Cluster-devel] [GFS2 PATCH 1/2] gfs2: Fix occasional glock use-after-free

2019-04-05 Thread Andreas Gruenbacher
This patch has to do with the life cycle of glocks and buffers. When gfs2 metadata or journaled data is queued to be written, a gfs2_bufdata object is assigned to track the buffer, and that is queued to various lists, including the glock's gl_ail_list to indicate it's on the active items list.

[Cluster-devel] [GFS2 PATCH 2/4] gfs2: Remove unnecessary extern declarations

2019-04-05 Thread Andreas Gruenbacher
Stop declaring our log operations as extern; they are only used locally. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/lops.h | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/gfs2/lops.h b/fs/gfs2/lops.h index 4e81742de7a0c..320fbf28d2fba 100644 --- a/fs/gfs2/lops.h +++

Re: [Cluster-devel] [PATCH 1/2] gfs2: Fix occasional glock use-after-free

2019-04-05 Thread Andreas Gruenbacher
Hi Ross, On Tue, 2 Apr 2019 at 00:59, Andreas Gruenbacher wrote: > thanks for the great analysis. > > On Tue, 26 Mar 2019 at 20:14, Bob Peterson wrote: > > - Original Message - > > > 6. gfs2_log_flush() continues and calls revoke_lo_after_commit() and > > > uses the freed glock (stack

Re: [Cluster-devel] [PATCH v2 1/3] dlm: check if workqueues are NULL before flushing/destroying

2019-04-05 Thread David Teigland
I tried these with one address and had no problem, so I've pushed them to the linux-dlm next branch. Dave