Re: [Cluster-devel] [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread kbuild test robot
Hi Mark, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc4 next-20190813] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mark

[Cluster-devel] [GFS2 PATCH v2] gfs2: untangle the logic in gfs2_drevalidate

2019-08-13 Thread Bob Peterson
Hi, This version 2 patch is the same as the original, but it implements Andreas's suggestion. --- Before this patch, function gfs2_drevalidate was a horrific tangle of unreadable labels, cases and goto statements. This patch tries to simplify the logic and make it more readable. Signed-off-by:

Re: [Cluster-devel] [GFS2 PATCH] gfs2: untangle the logic in gfs2_drevalidate

2019-08-13 Thread Andreas Gruenbacher
On Tue, 6 Aug 2019 at 20:01, Bob Peterson wrote: > > Hi, > > Before this patch, function gfs2_drevalidate was a horrific tangle of > unreadable labels, cases and goto statements. This patch tries to > simplify the logic and make it more readable. > > Signed-off-by: Bob Peterson > --- >

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread Mark Salyzyn
On 8/13/19 1:48 AM, Greg Kroah-Hartman wrote: On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: --- a/include/linux/xattr.h +++ b/include/linux/xattr.h @@ -30,10 +30,10 @@ struct xattr_handler { const char *prefix; int flags; /* fs private flags */ bool

[Cluster-devel] [GFS2 PATCH] gfs2: Fix possible fs name overflows

2019-08-13 Thread Bob Peterson
Hi, This patch fixes three places in which temporary character buffers could overflow due to the addition of the file system id from patch 3792ce973f07. Thanks to Dan Carpenter for pointing it out. Signed-off-by: Bob Peterson --- fs/gfs2/glock.c | 2 +- fs/gfs2/rgrp.c | 2 +- fs/gfs2/util.c

Re: [Cluster-devel] GFS2 deadlock in 4.19 (iomap/writeback?)

2019-08-13 Thread Andreas Gruenbacher
Hi Edwin and all, On Wed, 6 Mar 2019 at 12:08, Edwin Török wrote: > > Hello, > > I've been trying to debug a GFS2 deadlock that we see in our lab quite > frequently with a 4.19 kernel. With 4.4 and older kernels we were not able to > reproduce this. > See below for lockdep dumps and

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > --- a/include/linux/xattr.h > +++ b/include/linux/xattr.h > @@ -30,10 +30,10 @@ struct xattr_handler { > const char *prefix; > int flags; /* fs private flags */ > bool (*list)(struct dentry *dentry); > - int

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread kbuild test robot
-flags-option-to-get-xattr-method-paired-to-__vfs_getxattr/20190813-124612 config: c6x-allyesconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin