Re: [Cluster-devel] [PATCH] mm/filemap: do not allocate cache pages beyond end of file at read

2019-11-25 Thread Linus Torvalds
On Mon, Nov 25, 2019 at 2:53 AM Steven Whitehouse wrote: > > Linus, is that roughly what you were thinking of? So the concept looks ok, but I don't really like the new flags as they seem to be gfs2-specific rather than generic. That said, I don't _gate_ them either, since they aren't in any

Re: [Cluster-devel] [PATCH] mm/filemap: do not allocate cache pages beyond end of file at read

2019-11-25 Thread Steven Whitehouse
Hi, On 22/11/2019 23:59, Andreas Grünbacher wrote: Hi, Am Do., 31. Okt. 2019 um 12:43 Uhr schrieb Steven Whitehouse : Andreas, Bob, have I missed anything here? I've looked into this a bit, and it seems that there's a reasonable way to get rid of the lock taking in ->readpage and ->readpages

Re: [Cluster-devel] [RFC PATCH 0/3] Rework the gfs2 read and page fault locking

2019-11-25 Thread Kirill A. Shutemov
On Sat, Nov 23, 2019 at 12:53:21AM +0100, Andreas Gruenbacher wrote: > Hello, > > this patch series moves the glock lock taking in gfs2 from the > ->readpage and ->readpages inode operations to the ->read_iter file and > ->fault vm operations. To achieve that, we add flags to the >

Re: [Cluster-devel] [RFC PATCH 3/3] gfs2: Rework read and page fault locking

2019-11-25 Thread Kirill A. Shutemov
On Sat, Nov 23, 2019 at 12:53:24AM +0100, Andreas Gruenbacher wrote: > @@ -778,15 +804,51 @@ static ssize_t gfs2_file_direct_write(struct kiocb > *iocb, struct iov_iter *from) > > static ssize_t gfs2_file_read_iter(struct kiocb *iocb, struct iov_iter *to) > { > + struct gfs2_inode *ip; >