Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-09 Thread Dave Chinner
On Thu, Jul 09, 2020 at 10:10:38AM -0700, Darrick J. Wong wrote: > On Thu, Jul 09, 2020 at 06:05:19PM +0100, Matthew Wilcox wrote: > > On Thu, Jul 09, 2020 at 09:09:26AM -0700, Darrick J. Wong wrote: > > > On Thu, Jul 09, 2020 at 12:25:27PM +1000, Dave Chinner wrote: > > > > -*/ > > > > -

[Cluster-devel] [PATCH dlm-tool 1/3] dlm_controld: don't abort node configuration

2020-07-09 Thread Alexander Aring
In case of not having mark value file we don't abort the whole configuration if any error on open fails. We skip this specific setting and jump to the next one since it's not mandatory to have a correct mark setting. It will still appear inside the logs. --- dlm_controld/action.c | 7 ++- 1

[Cluster-devel] [PATCH dlm-tool 2/3] dlm_controld: change enable_waitplock_recovery default

2020-07-09 Thread Alexander Aring
This patch sets the default value of enable_waitplock_recovery to false as it is the same as the kernel configuration default. Note that in this specific case dlm_controld will not set the default value on startup. However this patch syncs the kernel and user land default behaviour. ---

[Cluster-devel] [PATCH dlm-tool 3/3] dlm_controld: add default value handling for unsigned int

2020-07-09 Thread Alexander Aring
This patch adds suppot to handle default values for unsigned int. --- dlm_controld/dlm_daemon.h | 1 + dlm_controld/main.c | 61 +-- 2 files changed, 34 insertions(+), 28 deletions(-) diff --git a/dlm_controld/dlm_daemon.h b/dlm_controld/dlm_daemon.h

[Cluster-devel] [PATCH dlm-tool 0/3] dlm_controld: changes from v2 to v3

2020-07-09 Thread Alexander Aring
Hi, series v2 got applied and my changes for series v3 got dropped. I created this patch series now to sync upstream with the previous v3 series. Every change is now splitted in a separate patch. Thank you. - Alex Alexander Aring (3): dlm_controld: don't abort node configuration

[Cluster-devel] [PATCHv3 dlm-tool 4/4] dlm_controld: add support for waitplock_recovery switch

2020-07-09 Thread Alexander Aring
This patch adds support to set the cluster attribute waitplock_recovery via enable_waitplock_recover arg or config file attribute. --- dlm_controld/action.c | 5 + dlm_controld/dlm.conf.5 | 2 ++ dlm_controld/dlm_daemon.h | 1 + dlm_controld/main.c | 5 + 4 files changed, 13

[Cluster-devel] [PATCHv3 dlm-tool 2/4] dlm_controld: set listen skb mark setting

2020-07-09 Thread Alexander Aring
This patch adds support to set the skb mark value for the in-kernel DLM listen socket. --- dlm_controld/action.c | 2 ++ dlm_controld/dlm.conf.5 | 2 ++ dlm_controld/dlm_daemon.h | 1 + dlm_controld/main.c | 5 + 4 files changed, 10 insertions(+) diff --git

[Cluster-devel] [PATCHv3 dlm-tool 1/4] dlm_controld: add support for unsigned int values

2020-07-09 Thread Alexander Aring
This patch adds support for setting a unsigned integer value. --- dlm_controld/config.c | 25 dlm_controld/dlm_daemon.h | 6 dlm_controld/main.c | 60 ++- 3 files changed, 65 insertions(+), 26 deletions(-) diff --git

[Cluster-devel] [PATCHv3 dlm-tool 3/4] dlm_controld: add support for per nodeid configuration

2020-07-09 Thread Alexander Aring
This patch adds support to make a configuration per nodeid and key-value pairs. As example this patch will introduce the key mark to set via configfs comms per nodeid the SO_MARK socket option. --- dlm_controld/Makefile | 3 +- dlm_controld/action.c | 36 +++--

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-09 Thread Darrick J. Wong
On Thu, Jul 09, 2020 at 06:05:19PM +0100, Matthew Wilcox wrote: > On Thu, Jul 09, 2020 at 09:09:26AM -0700, Darrick J. Wong wrote: > > On Thu, Jul 09, 2020 at 12:25:27PM +1000, Dave Chinner wrote: > > > iomap: Only invalidate page cache pages on direct IO writes > > > > > > From: Dave Chinner >

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-09 Thread Matthew Wilcox
On Thu, Jul 09, 2020 at 09:09:26AM -0700, Darrick J. Wong wrote: > On Thu, Jul 09, 2020 at 12:25:27PM +1000, Dave Chinner wrote: > > iomap: Only invalidate page cache pages on direct IO writes > > > > From: Dave Chinner > > > > The historic requirement for XFS to invalidate cached pages on > >

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-09 Thread Darrick J. Wong
On Thu, Jul 09, 2020 at 12:25:27PM +1000, Dave Chinner wrote: > On Wed, Jul 08, 2020 at 02:54:37PM +0100, Matthew Wilcox wrote: > > On Wed, Jul 08, 2020 at 04:51:27PM +1000, Dave Chinner wrote: > > > On Tue, Jul 07, 2020 at 03:00:30PM +0200, Christoph Hellwig wrote: > > > > On Tue, Jul 07, 2020 at

[Cluster-devel] [PATCH] lseek.2: List gfs2 support for SEEK_HOLE/SEEK_DATA

2020-07-09 Thread Andrew Price
Signed-off-by: Andrew Price --- man2/lseek.2 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/man2/lseek.2 b/man2/lseek.2 index a20b10431..22de446fc 100644 --- a/man2/lseek.2 +++ b/man2/lseek.2 @@ -182,6 +182,9 @@ NFS (since Linux 3.18) .IP * FUSE (since Linux 4.5) .\" commit

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-09 Thread Steven Whitehouse
Hi, On 08/07/2020 17:54, Christoph Hellwig wrote: On Wed, Jul 08, 2020 at 02:54:37PM +0100, Matthew Wilcox wrote: Direct I/O isn't deterministic though. If the file isn't shared, then it works great, but as soon as you get mixed buffered and direct I/O, everything is already terrible. Direct