Re: [Cluster-devel] [PATCH] gfs2: Move iomap_get before taking sd_quota_mutex

2022-05-17 Thread Andreas Gruenbacher
Hi Bob, On Fri, Feb 11, 2022 at 4:51 PM Bob Peterson wrote: > Before this patch quota function bh_get called gfs2_iomap_get after it > had locked the sd_quota_mutex. That's a problem because that holds the > i_rw_mutex, and that lock order is different from other code that > locks i_rw_mutex

[Cluster-devel] [PATCH] *

2022-05-17 Thread Andreas Gruenbacher
Hi Bob, On Fri, Feb 11, 2022 at 4:51 PM Bob Peterson wrote: > Before this patch quota function bh_get called gfs2_iomap_get after it > had locked the sd_quota_mutex. That's a problem because that holds the > i_rw_mutex, and that lock order is different from other code that > locks i_rw_mutex

Re: [Cluster-devel] [PATCH] gfs2: Convert function bh_get to use iomap

2022-05-17 Thread Andreas Gruenbacher
On Fri, Feb 11, 2022 at 4:51 PM Bob Peterson wrote: > Before this patch, function bh_get used block_map to figure out the > block it needed to read in from the quota_change file. This patch > changes it to use iomap directly to make it more efficient. Thanks, I've applied this with minor

Re: [Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-05-17 Thread Andreas Gruenbacher
On Mon, May 9, 2022 at 12:41 PM Andrew Price wrote: > On 29/04/2022 15:08, Andrew Price wrote: > > On 19/04/2022 16:49, Andrew Price wrote: > >> On 05/04/2022 13:08, Andrew Price wrote: > >>> The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to > >>> fs block size") fixes was a