Re: [Cluster-devel] [PATCH v5] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Kees Cook
On Wed, Oct 12, 2022 at 09:23:14AM +1300, Paulo Miguel Almeida wrote: > One-element arrays are deprecated. So, replace one-element array with > fixed size array member in struct dlm_ls, and refactor the rest of the > code, accordingly. > > Link: https://github.com/KSPP/linux/issues/79 > Link:

Re: [Cluster-devel] [PATCH v5] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Gustavo A. R. Silva
On Wed, Oct 12, 2022 at 09:23:14AM +1300, Paulo Miguel Almeida wrote: > One-element arrays are deprecated. So, replace one-element array with > fixed size array member in struct dlm_ls, and refactor the rest of the > code, accordingly. > > Link: https://github.com/KSPP/linux/issues/79 > Link:

[Cluster-devel] [PATCH v5] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Paulo Miguel Almeida
One-element arrays are deprecated. So, replace one-element array with fixed size array member in struct dlm_ls, and refactor the rest of the code, accordingly. Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/228 Link:

Re: [Cluster-devel] [PATCH v4] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Paulo Miguel Almeida
On Tue, Oct 11, 2022 at 01:06:32PM -0700, Kees Cook wrote: > On Wed, Oct 12, 2022 at 09:04:15AM +1300, Paulo Miguel Almeida wrote: > > error = -ENOMEM; > > > > - ls = kzalloc(sizeof(struct dlm_ls) + namelen, GFP_NOFS); > > + ls = kzalloc(sizeof(struct dlm_ls), GFP_NOFS); >

Re: [Cluster-devel] [PATCH v4] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Kees Cook
On Wed, Oct 12, 2022 at 09:04:15AM +1300, Paulo Miguel Almeida wrote: > One-element arrays are deprecated. So, replace one-element array with > fixed size array member in struct dlm_ls, and refactor the rest of the > code, accordingly. > > Link: https://github.com/KSPP/linux/issues/79 > Link:

[Cluster-devel] [PATCH v4] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Paulo Miguel Almeida
One-element arrays are deprecated. So, replace one-element array with fixed size array member in struct dlm_ls, and refactor the rest of the code, accordingly. Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/228 Link:

Re: [Cluster-devel] [PATCH] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Paulo Miguel Almeida
On Tue, Oct 11, 2022 at 02:37:40PM -0500, Gustavo A. R. Silva wrote: > On Wed, Oct 12, 2022 at 08:28:54AM +1300, Paulo Miguel Almeida wrote: > > > > > I didn't add v3 here because the the patch got changed from 'replacing > > [1]-array with flex-array' to 'replacing [1]-array to fixed-size

Re: [Cluster-devel] [PATCH] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Gustavo A. R. Silva
On Wed, Oct 12, 2022 at 08:28:54AM +1300, Paulo Miguel Almeida wrote: > On Tue, Oct 11, 2022 at 02:24:50PM -0500, Gustavo A. R. Silva wrote: > > On Wed, Oct 12, 2022 at 08:15:17AM +1300, Paulo Miguel Almeida wrote: > > > One-element arrays are deprecated. So, replace one-element array with > > >

Re: [Cluster-devel] [PATCH] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Gustavo A. R. Silva
On Wed, Oct 12, 2022 at 08:15:17AM +1300, Paulo Miguel Almeida wrote: > One-element arrays are deprecated. So, replace one-element array with > fixed size array member in struct dlm_ls, and refactor the rest of the > code, accordingly. > > Link: https://github.com/KSPP/linux/issues/79 > Link:

Re: [Cluster-devel] [PATCH] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Paulo Miguel Almeida
On Tue, Oct 11, 2022 at 02:24:50PM -0500, Gustavo A. R. Silva wrote: > On Wed, Oct 12, 2022 at 08:15:17AM +1300, Paulo Miguel Almeida wrote: > > One-element arrays are deprecated. So, replace one-element array with > > fixed size array member in struct dlm_ls, and refactor the rest of the > >

[Cluster-devel] [PATCH] [next] dlm: replace one-element array with fixed size array

2022-10-11 Thread Paulo Miguel Almeida
One-element arrays are deprecated. So, replace one-element array with fixed size array member in struct dlm_ls, and refactor the rest of the code, accordingly. Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/228 Link:

Re: [Cluster-devel] [PATCH v2][next] dlm: Replace one-element array with flexible-array member

2022-10-11 Thread Paulo Miguel Almeida
On Tue, Oct 11, 2022 at 10:20:31AM -0500, David Teigland wrote: > On Mon, Oct 10, 2022 at 03:35:24PM -0700, Kees Cook wrote: > > On Mon, Oct 10, 2022 at 04:00:39PM -0500, David Teigland wrote: > > > On Sat, Oct 08, 2022 at 09:03:28PM -0700, Kees Cook wrote: > > > > On Sun, Oct 09, 2022 at

Re: [Cluster-devel] [PATCH v2][next] dlm: Replace one-element array with flexible-array member

2022-10-11 Thread David Teigland
On Mon, Oct 10, 2022 at 03:35:24PM -0700, Kees Cook wrote: > On Mon, Oct 10, 2022 at 04:00:39PM -0500, David Teigland wrote: > > On Sat, Oct 08, 2022 at 09:03:28PM -0700, Kees Cook wrote: > > > On Sun, Oct 09, 2022 at 03:05:17PM +1300, Paulo Miguel Almeida wrote: > > > > On Sat, Oct 08, 2022 at

[Cluster-devel] [PATCHv2] mm: slab: comment __GFP_ZERO case for kmem_cache_alloc

2022-10-11 Thread Alexander Aring
This patch will add a comment for the __GFP_ZERO flag case for kmem_cache_alloc(). As the current comment mentioned that the flags only matters if the cache has no available objects it's different for the __GFP_ZERO flag which will ensure that the returned object is always zeroed in any case. I