to infinite loops in journal replay, both in the
kernel code and fsck.gfs2 code. This patch re-adds that call.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index edbd461..4a14d50 100644
--- a/fs/gfs2
Hi,
Here is a revised patch based on Steve's feedback:
This patch eliminates function gfs2_set_mode which was only called in
one place, and always returned 0.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/acl.c b/fs/gfs2
Hi,
This patch uses a completion to prevent dlm's recovery process from
referencing and trying to recover a journal before a journal has been
opened.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
test
conditions, like very small resource groups. I don't think Nate uses
this in any of his tests, but it might be worth asking.
I've used it to try to recreate certain failing scenarios, but I haven't
needed it in years. Are we sure we want to get rid of it?
Regards,
Bob Peterson
Red Hat File
in
0x70dc1a7 in 0x70eaf7a in 0x70dbfa9 in
0x70ead7c in
In this case, in indicates indirect blocks, and rb indicates a rgrp bitmap.
This is useful for getting a bigger picture of what that journal descriptor
contains and represents.
Regards,
Bob Peterson
Red Hat File Systems
Signed
Hi,
This patch allows gfs2_edit to print metadata blocks of type LB
(log descriptor continuation blocks) for GFS2. Prior to this, only
GFS1's continuation blocks would print.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/edit
is especially apparent when dealing with nested flocks.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index aec7f73..22ce2f0 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1128,7 +1128,9 @@ void
where the flocks are held in Shared (SH) mode.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 4fc3a30..0740a57 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -981,7 +981,7 @@ static int
where the flocks are held in Shared (SH) mode.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 4fc3a30..0740a57 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -981,7 +981,7 @@ static int
/ holiday this week, but he will
be back on Thursday and Friday (which is a holiday).
I'm all for getting rid of useless parameters, and I've done so on
several occasions in GFS2.
Regards,
Bob Peterson
Red Hat File Systems
Hi,
This patch introduces file read-ahead to pass1.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
gfs2/fsck/metawalk.c | 65 ++--
gfs2/fsck/metawalk.h | 1 +
gfs2/fsck/pass1.c| 1 +
3 files
- Original Message -
Hi,
On 11/07/14 18:41, Bob Peterson wrote:
- Original Message -
(snip)
Use timersub() here perhaps?
Otherwise looks good,
Steve.
Hi Steve,
Thanks for the suggestion. How about this version?
Yes, that looks better. There is probably
Hi,
This patch changes some variables (especially maxlen in function
gfs2_block_map) from unsigned int to size_t. We need 64-bit arithmetic
for very large files (e.g. 1PB) where the variables otherwise get
shifted to all 0's.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob
. Then it tries again, for an increasing amount of time.
Subsequent attempts to gain the try lock don't use _1CB so that
only one callback is issued.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index
, running
fsck.gfs2, and seeing if it can properly repair it.
Another concern is gfs2_convert. I don't know if it makes any assumptions
about the master directory, but it's much less likely. I think it just
assumes the file system is healthy. But fsck.gfs2 is a concern.
Regards,
Bob Peterson
Red
.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index e62e594..9317ddc 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -840,8 +840,10 @@ static struct dentry *__gfs2_lookup(struct inode *dir,
struct
is released as per previous behavior.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 1a349f9..5d4261f 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -2100,8 +2100,13 @@ int gfs2_diradd_alloc_required
of local locks distributes the locks
between the nodes (at least until nodes enter or leave the cluster),
which tends to make each node keep to itself when doing allocations.
Thus, dlm communications are kept to a minimum, which results in
significantly faster block allocations.
Regards,
Bob Peterson
patches depending on those results.
Regards,
Bob Peterson
Red Hat File Systems
/rgrp.c?h=RHEL4
Regards,
Bob Peterson
Red Hat File Systems
FILES = 735760
Patch description:
The minimum block reservation size was 32 blocks. This patch doubles
it to 64 blocks.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/rgrp.h b/fs/gfs2/rgrp.h
index 5d8f085..e2058a7 100644
it's now adaptive, but before I did that, I'd have
to run some performance tests. What do you think?
Regards,
Bob Peterson
Red Hat File Systems
Patch text:
This patch introduces a new block reservation doubling scheme. If we
get
35sec
Run 5 time: 2hr 5min 55sec
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index f98fa37..c9f4f4c 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -97,6 +97,7 @@ struct gfs2_rgrpd {
#define
COUNT FOR OUTPUT FILES = 341769
EXTENT COUNT FOR OUTPUT FILES = 348676
EXTENT COUNT FOR OUTPUT FILES = 348079
So I'm looking for opinions:
(a) Stick with the original reservation doubling patch, or
(b) Go with the additive version.
(c) Any other ideas?
Regards,
Bob Peterson
Red Hat File Systems
for my
tests.
Regards,
Bob Peterson
Red Hat File Systems
on the current metapath buffers. Therefore,
fiemap may call blockmap several times to get the hole size.
The hole size is determined by a new function.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index f0b945a
If an application does a sequence of (1) big write, (2) little write
we don't necessarily want to reset the size hint based on the smaller
size. The fact that they did any big writes implies they may do more,
and therefore we should try to allocate bigger block reservations, even
if the last few
Before this patch, whenever a struct file (opened to allow writes) was
closed, the multi-block reservation structure associated with the inode
was deleted. That's a problem, especially when there are multiple writers.
Applications that do open-write-close will suffer from greater levels
of
with the first patch alone.
This patch set includes all four patches.
Bob Peterson (4):
GFS2: Set of distributed preferences for rgrps
GFS2: Make block reservations more persistent
GFS2: Only increase rs_sizehint
GFS2: If we use up our block reservation, request more next time
fs/gfs2/file.c
This patch tries to use the journal numbers to evenly distribute
which node prefers which resource group for block allocations. This
is to help performance.
---
fs/gfs2/incore.h | 2 ++
fs/gfs2/lock_dlm.c | 2 ++
fs/gfs2/ops_fstype.c | 1 +
fs/gfs2/rgrp.c | 66
a
block-by-block search for the next valid block.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
fs/ioctl.c | 7 ++-
include/linux/buffer_head.h | 4
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/fs/ioctl.c b
is determined by a new function.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
fs/gfs2/bmap.c | 70 --
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
of GFS2). (Which in the
case of a 1PB sparse file is non-trivial, since it involves several
levels of metadata indirection). Combining it with get_block made it
much more efficient.
Making a separate get_block_map_fiemap() function just seems like an
exercise in redundancy.
Regards,
Bob Peterson
Red
- Original Message -
On Wed, Oct 22, 2014 at 08:28:53AM -0400, Bob Peterson wrote:
Yes, I thought about that.
One of my early prototypes had a separate function used by fiemap.
Function __generic_block_fiemap would call get_block() which
returned an indication of a hole as it does
This patch tries to use the journal numbers to evenly distribute
which node prefers which resource group for block allocations. This
is to help performance.
---
fs/gfs2/incore.h | 1 +
fs/gfs2/rgrp.c | 66 +++-
2 files changed, 62
If we run out of blocks for a given multi-block allocation, we obviously
did not reserve enough. We should reserve more blocks for the next
reservation to reduce fragmentation. This patch increases the size hint
for reservations when they run out.
---
fs/gfs2/rgrp.c | 3 +++
fs/gfs2/rgrp.h | 1 +
COUNT FOR OUTPUT FILES = 419736
EXTENT COUNT FOR OUTPUT FILES = 419040
EXTENT COUNT FOR OUTPUT FILES = 422774
EXTENT COUNT FOR OUTPUT FILES = 409281 (Average 419844)
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
Bob Peterson (3):
GFS2: Set
If an application does a sequence of (1) big write, (2) little write
we don't necessarily want to reset the size hint based on the smaller
size. The fact that they did any big writes implies they may do more,
and therefore we should try to allocate bigger block reservations, even
if the last few
a few times for various tests.
Regards,
Bob Peterson
Red Hat File Systems
6 time: 2hr 10min 58sec
EXTENT COUNT FOR OUTPUT FILES = 424329
EXTENT COUNT FOR OUTPUT FILES = 430663
EXTENT COUNT FOR OUTPUT FILES = 430186
EXTENT COUNT FOR OUTPUT FILES = 421635
EXTENT COUNT FOR OUTPUT FILES = 416706
EXTENT COUNT FOR OUTPUT FILES = 418887
Regards,
Bob Peterson
Red Hat
If we run out of blocks for a given multi-block allocation, we obviously
did not reserve enough. We should reserve more blocks for the next
reservation to reduce fragmentation. This patch increases the size hint
for reservations when they run out.
---
fs/gfs2/rgrp.c | 3 +++
fs/gfs2/rgrp.h | 1 +
This patch tries to use the journal numbers to evenly distribute
which node prefers which resource group for block allocations. This
is to help performance.
---
fs/gfs2/incore.h | 1 +
fs/gfs2/rgrp.c | 66 +++-
2 files changed, 62
If an application does a sequence of (1) big write, (2) little write
we don't necessarily want to reset the size hint based on the smaller
size. The fact that they did any big writes implies they may do more,
and therefore we should try to allocate bigger block reservations, even
if the last few
be tolerated, the problem is detected and the journal
may be cleared.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
gfs2/fsck/fs_recovery.c | 54 +++--
1 file changed, 43 insertions(+), 11 deletions
matches the existing
output format.
Signed-off-by: Andrew Price anpr...@redhat.com
---
ACK
Bob Peterson
Red Hat File Systems
;
opts-jsize = GFS2_DEFAULT_JSIZE;
opts-qcsize = GFS2_DEFAULT_QCSIZE;
- opts-rgsize = GFS2_MAX_RGSIZE;
+ opts-rgsize = GFS2_DEFAULT_RGSIZE;
opts-lockproto = lock_dlm;
opts-locktable = ;
opts-confirm = 1;
--
1.9.3
ACK
Bob Peterson
Red Hat File Systems
Hi,
This patch implements a new cookie encoding scheme for encoding, decoding
and filling directory entries. This new scheme prevents duplicate cookies,
so it eliminates the need to sort the entries to prevent duplicates.
Thus, it simplies the code greatly.
Regards,
Bob Peterson
Red Hat File
of a
directory that already exists) but it looks like it already behaves that way.
So I guess so. It may warrant further investigation.
Bob Peterson
Red Hat File Systems
- Original Message -
On Wed, Nov 19, 2014 at 03:33:29PM -0500, Bob Peterson wrote:
- Original Message -
Signed-off-by: Al Viro v...@zeniv.linux.org.uk
---
fs/gfs2/inode.c |5 +
1 file changed, 5 insertions(+)
diff --git a/fs/gfs2/inode.c b/fs/gfs2
, const char *msg, int error)
--
1.7.10.4
ACK
Bob Peterson
Red Hat File Systems
)
- kvfree(hc);
- else
+ if (likely(!ip-i_hash_cache)) {
ip-i_hash_cache = hc;
+ hc = NULL;
+ }
spin_unlock(inode-i_lock);
+ kvfree(hc);
return ip-i_hash_cache;
}
--
1.7.10.4
ACK
Bob Peterson
Red Hat File Systems
:
This patch changes the order in which the blocks are processed by function
gfs2_before_commit. Before, it was processing them in the wrong order such
that the blocks would be layed out and written in reverse order. This
changes the order to the correct order.
Regards,
Bob Peterson
Red Hat File
- Original Message -
As you can see, the blocks are reverse-sorted. This patch changes the
order so that they're written in sorted order. Log headers written with
the patch look more like this:
Does that mean that this patch got the ordering the wrong way around then?
- Original Message -
Hi Bob,
On 22/01/15 20:41, Bob Peterson wrote:
Hi,
This patch changes the old block_map structure for fsck.gfs2 to the
simpler bitmap structure so that we have a 1:1 correspondence. This
was done to reduce memory requirements of fsck.gfs2.
I'm curious
Hi,
This bug was spotted by coverity. The fsck.gfs2 should include a line
to report the number of journal sequence errors fixed. It was coded
improperly so that it was never displayed. This patch fixes the code
so that the message will be printed properly.
Regards,
Bob Peterson
Red Hat File
Hi,
This patch fixes a rare code path that's doing use-after-free
I spotted in pass2.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/pass2.c b/gfs2/fsck/pass2.c
index 27b7336..4ea322a 100644
--- a/gfs2/fsck/pass2.c
+++ b
,
but if the block is reused, it may be repurposed as a leaf block.
That may confuse subsequent processing. Another reason to call
reprocess_inode is when the goal block changes to a value outside
the resource group, due to block allocations for repairs.
Regards,
Bob Peterson
Red Hat File Systems
Signed
value back to NULL to ensure it's not reused. This is just a precaution
I spotted while debugging, and it's worth doing.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/fs_recovery.c b/gfs2/fsck/fs_recovery.c
index 3d8fe98
Hi,
This patch checks for the GFS2_DIF_SYSTEM bit on system dinodes. If the
bit is not set, the dinode is assumed to be corrupt and rebuilt.
If the jindex is rebuilt, it needs to be re-read.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff
. This allows us to remove a dummied-up rgrp kludge in the code.
However, if the replayed journal block is part of an rgrp, we need to
refresh the rgrp based on the values rewritten from the journal.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff
today's
blockmap that's 4:1.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/pass5.c b/gfs2/fsck/pass5.c
index b2e8adf..2b8536d 100644
--- a/gfs2/fsck/pass5.c
+++ b/gfs2/fsck/pass5.c
@@ -12,94 +12,6 @@
#include fsck.h
#include
Hi,
This patch just removes a goto that did nothing.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9054002..73c72253 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -543,10 +543,7
- Original Message -
- Original Message -
Hi Bob,
On 22/01/15 20:41, Bob Peterson wrote:
Hi,
This patch changes the old block_map structure for fsck.gfs2 to the
simpler bitmap structure so that we have a 1:1 correspondence. This
was done to reduce memory
Hi,
This patch adds a call to function gfs2_rs_alloc to make sure a
reservation structure has been allocated before attempting to
reserve blocks.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
fs/gfs2/aops.c | 3 +++
1 file changed, 3
or
gfs2_file_aio_write. In the failing scenario, it's going through
sendfile. I suppose I could patch sendfile as an alternative, but
the advantage here is that this patch will do it only if a block
allocation is needed.
Regards,
Bob Peterson
Red Hat File Systems
- Original Message -
Hi Bob,
On Mon, 16 Feb 2015 09:20:56 -0500 (EST) Bob Peterson rpete...@redhat.com
wrote:
This patch adds Bob Peterson as a maintainer of the GFS2 file system.
It also changes the development repository to a shared location rather
than Steve Whitehouse's
Hi,
This patch adds a GFS2-specific function for splice_write which
first calls function gfs2_rs_alloc to make sure a reservation
structure has been allocated before attempting to reserve blocks.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
Hi,
This patch adds Bob Peterson as a maintainer of the GFS2 file system.
It also changes the development repository to a shared location rather
than Steve Whitehouse's private location.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
ACK
Looks right.
Bob Peterson
Red Hat File Systems
),
+ len, filename);
}
/**
--
1.9.3
Nice trick (strangely, I've never used that construct), but we could just as
well get rid of the whole function altogether.
Bob Peterson
Red Hat File Systems
- Original Message -
Print a nicely formatted summary of some of the more interesting
configure options. Required some tweaking of earlier configure stages
for accuracy.
Signed-off-by: Andrew Price anpr...@redhat.com
---
Hi,
ACK
Bob Peterson
Red Hat File Systems
anyway, the initializers can
be removed to achieve the intended result.
Signed-off-by: Andrew Price anpr...@redhat.com
---
ACK
Bob Peterson
Red Hat File Systems
of that
indirect block. This patch allows it to finish out the rest of the
undo work properly.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index cd224fe..1875b24 100644
--- a/gfs2/fsck
Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/pass2.c b/gfs2/fsck/pass2.c
index 1559d8e..bdcf77c 100644
--- a/gfs2/fsck/pass2.c
+++ b/gfs2/fsck/pass2.c
@@ -468,7 +468,8 @@ static int basic_dentry_checks(struct gfs2_inode *ip,
struct
Hi,
This patch changes pass3 so that it prints out the directory inode
number when it finds a directory containing a bad block.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/pass3.c b/gfs2/fsck/pass3.c
index 9582b5b
into account the fact that the hash table could just
unexpectly double, throwing off all the pointers. This patch attempts
to correct that by fixing up the pointers as necessary.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck
D2. Note, though, that if the
corruption is found later in the cycle (after undo is possible) the duplicate
reference MUST remain and be resolved by pass1b.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck
tree? Then you can
get the credit.
Regards,
Bob Peterson
Red Hat File Systems
/gfs2/rgrp.h | 10 +-
fs/gfs2/xattr.c | 2 +-
9 files changed, 89 insertions(+), 34 deletions(-)
--
1.8.1.4
Hi,
ACK. Looks okay to me.
Regards,
Bob Peterson
Red Hat File Systems
Hi,
Since the only caller of function __gfs2_glock_remove_from_lru locks the
same spin_lock as gfs2_glock_remove_from_lru, the functions can be combined.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/glock.c b/fs/gfs2
+++---
fs/gfs2/rgrp.c | 20 ++
fs/gfs2/rgrp.h | 3 ++-
fs/gfs2/xattr.c | 2 +-
10 files changed, 133 insertions(+), 65 deletions(-)
--
1.8.1.4
Hi,
ACK to all three.
Now pushed to the for-next branch of the linux-gfs2.git git tree.
Regards,
Bob Peterson
Song cson...@gatech.edu
---
fs/gfs2/glock.c | 47 ---
1 file changed, 28 insertions(+), 19 deletions(-)
Hi,
I've now added this patch to the for-next branch of the linux-gfs2.git
tree. Thanks.
Regards,
Bob Peterson
Red Hat File Systems
;
- }
+ if (!ip)
+ return NULL;
+
+ ip-i_flags = 0;
+ ip-i_gl = NULL;
+ ip-i_rgd = NULL;
+ ip-i_res = NULL;
return ip-i_inode;
}
--
1.9.3
ACK,
Bob Peterson
Red Hat File Systems
;
--
1.9.3
Hi,
Is this a memory leak (albeit a small one) or did I miss something?
I don't see where the memory allocate by strndup is ever freed.
Regards,
Bob Peterson
Red Hat File Systems
new patches.
To clone the new tree, do something like this:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
There are currently three patches pushed to the new for-next branch:
0108044 Add myself (Bob Peterson) as a maintainer of GFS2 (Bob Peterson)
9717c00 GFS2
Hi,
Now in the for-next tree of the linux-gfs2.git repo.
Regards,
Bob Peterson
- Original Message -
When removing a default acl or setting an access acl that is entirely
represented in the file mode, we end up with acl == NULL in gfs2_set_acl().
In
that case, bring gfs2 in line
to me.
ACK to the series.
Regards,
Bob Peterson
Red Hat File Systems
!
--
~Randy
Hi,
My apologies. I've pushed an addendum patch that fixes the problem to
the for-next branch of the linux-gfs2.git git tree.
Regards,
Bob Peterson
changed, 13 insertions(+), 5 deletions(-)
Hi,
ACK
Bob Peterson
Red Hat File Systems
sense to me.
Regards,
Bob Peterson
Red Hat File Systems
=for-nextid=086cc672e1cb600b9c17688a4aa44560db858c03
Regards,
Bob Peterson
Red Hat File Systems
- Original Message -
Follow the same style used for the other functions in the same file.
Signed-off-by: Antonio Ospite a...@ao2.it
Cc: Steven Whitehouse swhit...@redhat.com
Cc: Bob Peterson rpete...@redhat.com
Cc: cluster-devel@redhat.com
---
fs/gfs2/inode.c | 4 ++--
1 file
://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-nextid=a63b7bbc2175901d79fa36ba734499655c077f0d
Regards,
Bob Peterson
Red Hat File Systems
of the linux-gfs2 git tree.
FYI: I removed Resolves: for upstream.
Regards,
Bob Peterson
Red Hat File Systems
in the for-next branch of the linux-gfs2
tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-nextid=01e64ee40ad741037352d1d6202eaa432f833eb4
Regards,
Bob Peterson
Red Hat File Systems
Frederick f...@skynet.be
Hi,
Thanks. The v3 version of the patch is now in the for-next branch of the
linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-nextid=e50ead480fac63ede9e0b656cd29c1820f7af9de
Regards,
Bob Peterson
Red Hat File Systems
Hi,
Please consider pulling the following changes,
Bob Peterson
GFS2: merge window
Here is a list of patches we've accumulated for GFS2 for the current upstream
merge window. Most of the patches fix GFS2 quotas, which were
- Original Message -
On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson rpete...@redhat.com wrote:
12 files changed, 184 insertions(+), 95 deletions(-)
Oh, and this was incorrect. You had apparently limited the statistics
to the fs/gfs2 directory, and thus missed the changes
Hi,
Linus has pulled the latest set of patches from the for-next branch of
the linux-gfs2.git tree, so I rebased the tree based on Linus's master.
So the current tree is back to having no unmerged GFS2 patches.
Regards,
Bob Peterson
Red Hat File Systems
processing occurring on a different CPU.
Signed-off-by: Bob Peterson rpete...@redhat.com
---
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 6af2396..f39eedc 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1850,14 +1850,19 @@ static bool gfs2_rgrp_congested(const struct gfs2_rgrpd
*rgd, int
401 - 500 of 2233 matches
Mail list logo