+void attr_kill_to_mode(struct inode *inode, struct iattr *attr)
This function badly needs a kerneldoc description. Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)
We should at least add a generic_ prefix to indicate it's a generic
On Mon, Jan 07, 2008 at 12:39:25AM -0500, Wendy Cheng wrote:
+#define DEBUG 0
+#define fo_printk(x...) ((void)(DEBUG printk(x)))
Please don't introduce more debugging helpers but use the existing
ones.
+extern __u32 in_aton(const char *str);
This is properly declared in linux/inet.h
+
Ok, I played around with this and cleaned up the ip/path codepathes to
be entirely setup which helped the code quite a bit. Also a few other
cleanups and two bugfixes (postive error code returned and missing
path_release) fell out of it. I still don't like what's going on in
fs/lockd/svcsubs.c,
On Tue, Jan 08, 2008 at 03:57:45PM -0500, Wendy Cheng wrote:
Christoph Hellwig wrote:
Ok, I played around with this and cleaned up the ip/path codepathes to
be entirely setup which helped the code quite a bit. Also a few other
Thanks for doing this :) . In the middle of running
On Wed, Jan 09, 2008 at 06:02:15PM +, Christoph Hellwig wrote:
On Tue, Jan 08, 2008 at 03:57:45PM -0500, Wendy Cheng wrote:
Christoph Hellwig wrote:
Ok, I played around with this and cleaned up the ip/path codepathes to
be entirely setup which helped the code quite a bit. Also a few
On Fri, May 29, 2009 at 08:50:10PM +0100, Steven Whitehouse wrote:
This is extremly inefficient. We'd be much better off just storing
the dev_t and introducing a __trace_bdevname to expand a bdevname
into the tracer buffer. It's been on my todo list for a while and
I'll look into it next
On Fri, Jun 05, 2009 at 02:52:16PM +0100, Steven Whitehouse wrote:
+static int gfs2_get_sb(struct file_system_type *fs_type, int flags,
+const char *dev_name, void *data, struct vfsmount *mnt)
+{
+ struct super_block *s;
+ struct gfs2_sbd *sdp;
+ int ret;
+
On Fri, Jun 05, 2009 at 03:17:43PM +0100, Steven Whitehouse wrote:
This is pretty ugly. Even if this is how the old gfs2meta filesystem
worked I would prefer to only allow it if mounted as type gfs2meta, not
for normal gfs2 mount and gradually phase it out.
Which bit is ugly? We need to
On Fri, Oct 09, 2009 at 12:01:16PM -0400, Jason Baron wrote:
hi,
I'd like to move the gfs2 tracepoints to the the common
include/trace/events directory along with all of the other trace events.
It makes understanding what tracepoints are available easier, and I see
no reason why gfs2 should
On Mon, Oct 12, 2009 at 12:00:37PM +0200, Ingo Molnar wrote:
yeah. I have no objection to adding it to include/trace/. Tracepoints
are a fundamentally global business.
Subsystems can opt to hide their tracepoints locally, but it's better to
have a global view about what's out there, so
on
at remount time.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/gfs2/incore.h
===
--- linux-2.6.orig/fs/gfs2/incore.h 2009-10-30 07:43:42.246023792 +0100
+++ linux-2.6/fs/gfs2/incore.h 2009-10-30 07:44:11.173255988
I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.
All the patches are extremly whitespace mangled. And I don't think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers. So please try
On Mon, Dec 21, 2009 at 09:22:41AM +, Steven Whitehouse wrote:
Hi,
Looks fairly harmless, even though I don't entirely see the point. Do
you want me to add this to me tree?
We also have a _RET_IP_ macro that does the same and has a much more
useful name. And given that we need the
On Fri, Feb 05, 2010 at 09:49:54AM +, Steven Whitehouse wrote:
Hi,
On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote:
Useful for tracking down where specific IOs are being issued
from.
Signed-off-by: Dave Chinner dchin...@redhat.com
---
fs/gfs2/log.c|6 ++
gfs2 only needs the quotactl code, not the generic quota implementation.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/gfs2/Kconfig
===
--- linux-2.6.orig/fs/gfs2/Kconfig 2010-03-03 14:48:00.292026869 +0100
We need to report both the accounting and enforcing flags if we are
in enforcing mode.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: xfs/fs/gfs2/quota.c
===
--- xfs.orig/fs/gfs2/quota.c2010-05-04 23:16:59.718256886 +0200
On Tue, May 25, 2010 at 09:21:27AM +0100, Steven Whitehouse wrote:
From: Bob Peterson rpete...@redhat.com
The previous patch I wrote for reclaiming unlinked dinodes
had some shortcomings and did not prevent all hangs.
This version is much cleaner and more logical, and has
passed very
On Mon, Jun 07, 2010 at 12:34:14PM -0500, David Teigland wrote:
IIRC, nfs recently moved to using a mount helper after *not* using one for
many years. It would be interesting to ask them about their motivations.
That's not correct at all. NFS has required special mount code since
day 1 and
On Wed, Sep 08, 2010 at 04:35:20PM +0100, Steven Whitehouse wrote:
From bc9fb728211162a24afd341c9ffb85e7b459fb8d Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Wed, 8 Sep 2010 16:02:13 +0100
Subject: GFS2: Make . and .. qstrs constant
Rather than calculating the
using 512b blocks.
Oops, thanks for fixing this up.
Reviewed-by: Christoph Hellwig h...@lst.de
It seems all filesystems but XFS ignore O_SYNC for fallocate, and never
make sure the size update transaction made it to disk.
Given that a fallocate without FALLOC_FL_KEEP_SIZE very much is a data
operation (it adds new blocks that return zeroes) that seems like a
fairly nasty surprise for
On Wed, Nov 16, 2011 at 11:54:13AM +0100, Jan Kara wrote:
Yeah, only that nobody calls that fsync() automatically if the fd is
O_SYNC if I'm right. But maybe calling fdatasync() on the range which was
fallocated from sys_fallocate() if the fd is O_SYNC would do the trick for
most
On Wed, Nov 16, 2011 at 02:39:15PM +0100, Jan Kara wrote:
This would work fine with XFS and be equivalent to what it does for
O_DSYNC now. But I'd rather see every filesystem do the right thing
and make sure the update actually is on disk when doing O_(D)SYNC
operations.
OK, I don't
On Wed, Nov 16, 2011 at 04:57:55PM +0100, Jan Kara wrote:
I agree with you that userspace shouldn't have to call fsync. What I
meant is that sys_fallocate() or do_fallocate() can call
generic_write_sync(file, pos, len), and that would be completely
transparent to userspace.
That's different
Having RCU for modification mostly workloads never is a good idea, so
I don't think it makes sense to mention it here.
If you care about the overhead it's worth trying to use per-cpu lists,
though.
On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote:
From: Cong Wang amw...@redhat.com
nfs and cifs define some helper functions for sockaddr,
they can use the generic functions for union inet_addr too.
Since some dlm code needs to compare -sin_port, introduce a
generic function
@@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct
sockaddr *rhs)
{
I think your new sockaddr_equal should be equivalent to to this
srcip_matches, that is it should warn about and return false for unknown
address families.
On Fri, Nov 15, 2013 at 12:29:48PM +0800, Jeff Liu wrote:
Hi Folks,
This patch is trying to introduce a new list helper to retrieve the
last entry or return NULL if the list is empty corresponding to it,
which is inspired by Jiri Pirko's list_first_entry_or_null().
How did we end up with
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/hfsplus/acl.h |9 +--
fs/hfsplus/dir.c |1 +
fs/hfsplus/inode.c |3 +-
fs/hfsplus/posix_acl.c | 161 +---
fs/hfsplus/xattr.c |5 +-
fs/hfsplus/xattr.h |2
f2fs has some weird mode bit handling, so still using the old
chmod code for now.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/f2fs/acl.c | 140 +--
fs/f2fs/acl.h |1 +
fs/f2fs/file.c |1 +
fs/f2fs/namei.c |2 +
fs/f2fs
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/btrfs/acl.c | 135 --
fs/btrfs/ctree.h |7 +--
fs/btrfs/inode.c |7 ++-
fs/btrfs/xattr.c |5 +-
fs/btrfs/xattr.h |2 -
5 files changed, 29 insertions(+), 127 deletions
With the -set_acl inode operation we can implement the Posix ACL
xattr handlers in generic code instead of duplicating them all
over the tree.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/xattr_acl.c | 95 +++
include/linux
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/reiserfs/xattr_acl.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c
index 06c04f7..6f721ea 100644
--- a/fs/reiserfs/xattr_acl.c
+++ b/fs/reiserfs
On Tue, Dec 03, 2013 at 12:00:07AM +0100, Jan Kara wrote:
Hum, this changes the cluster locking. Previously ocfs2_acl_get() used
from ocfs2_acl_chmod() grabbed cluster wide inode lock. Now getting of ACL
isn't protected by the inode lock. That being said the cluster locking
around setattr
On Wed, Dec 04, 2013 at 12:12:37PM +, Steven Whitehouse wrote:
error = posix_acl_equiv_mode(acl, mode);
+ if (error 0)
Andy Price has pointed out a missing return error; here
- if (error = 0) {
- posix_acl_release(acl);
+
On Fri, Dec 06, 2013 at 10:37:34AM +0900, Jaegeuk Kim wrote:
f2fs caches a new mode bit for a while to make the consistency between
xattr's acl mode and the inode mode.
Can you explain what exactly you're trying to do there? I've been
trying to unwrap what's going on and can't really see the
This will allow moving all the Posix ACL handling into the VFS and clean
up tons of cruft in the filesystems.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
include/linux/fs.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/fs.h b/include
With the -set_acl inode operation we can implement the Posix ACL
xattr handlers in generic code instead of duplicating them all
over the tree.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/xattr_acl.c | 102
Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux,
and create inodes with the proper mode instead of fixing it up later.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Dave Chinner dchin
Factor out the code to get an ACL either from the inode or disk from
check_acl, so that it can be used elsewhere later on.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/namei.c| 24 +++-
fs/posix_acl.c
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/nfs/inode.c |4 -
fs/nfs/nfs3acl.c | 287 +---
fs/nfs/nfs3proc.c | 26 +++--
fs/nfs/nfs3super.c |3 +
include/linux/nfs_fs.h | 10 +-
5 files changed, 76 insertions
This contains some major refactoring for the create path so that
inodes are created with the right mode to start with instead of
fixing it up later.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/ocfs2/acl.c | 234 ++-
fs/ocfs2/acl.h
And instead convert tmpfs to use the new generic ACL code, with two stub
methods provided for in-memory filesystems.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/Kconfig |6 +-
fs/Makefile |1 -
fs/generic_acl.c| 184
Rename the current posix_acl_chmod to __posix_acl_chmod and add
a fully featured ACL chmod helper that uses the -set_acl inode
operation.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/9p/acl.c |2 +-
fs/btrfs/acl.c|2
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Vyacheslav Dubeyko sl...@dubeyko.com
---
fs/hfsplus/acl.h |9 +--
fs/hfsplus/dir.c |1 +
fs/hfsplus/inode.c |3 +-
fs/hfsplus/posix_acl.c | 168 +---
fs/hfsplus
Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/reiserfs/acl.h |4 +-
fs/reiserfs/file.c |1
On Thu, Dec 12, 2013 at 08:06:09PM +0100, Andreas Gruenbacher wrote:
+ /*
+* A filesystem can force a ACL callback by just never filling the
+* ACL cache. But normally you'd fill the cache either at inode
+* instantiation time, or on the first -get_acl call.
+*
+*
This series consolidates the various cut'n'pasted Posix ACL implementations
into a single common one based on the -get_acl method Linus added a while
ago and a new -set_acl counterpart.
This remove ~1800 lines of code and provides a single place to implement
various nasty little gems of the
With the -set_acl inode operation we can implement the Posix ACL
xattr handlers in generic code instead of duplicating them all
over the tree.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/posix_acl.c | 102
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/reiserfs/xattr_acl.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c
index 06c04f7..6f721ea 100644
--- a/fs
Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/reiserfs/acl.h |4 +-
fs/reiserfs/file.c |1
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/ext2/acl.c | 188 --
fs/ext2/acl.h |8 +-
fs/ext2/file.c |1 +
fs/ext2/inode.c |2 +-
fs/ext2/namei.c |2 +
fs/ext2/xattr.c |8 +-
fs/ext2
Remove the boilerplate code to marshall and unmarhall ACL objects into
xattrs and operate on the posix_acl objects directly. Also move all
the ACL handling code into nfs?acl.c where it belongs.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/nfsd/acl.h | 16 ++--
fs/nfsd/nfs2acl.c
This contains some major refactoring for the create path so that
inodes are created with the right mode to start with instead of
fixing it up later.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/ocfs2/acl.c | 234 ++-
fs/ocfs2/acl.h
f2fs has some weird mode bit handling, so still using the old
chmod code for now.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jaegeuk Kim jaegeuk@samsung.com
---
fs/f2fs/acl.c | 174 ++-
fs/f2fs/acl.h |7 +--
fs/f2fs
Rename the current posix_acl_chmod to __posix_acl_chmod and add
a fully featured ACL chmod helper that uses the -set_acl inode
operation.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/9p/acl.c |2 +-
fs/btrfs/acl.c|2
This series consolidates the various cut'n'pasted Posix ACL implementations
into a single common one based on the -get_acl method Linus added a while
ago and a new -set_acl counterpart.
This remove ~1800 lines of code and provides a single place to implement
various nasty little gems of the
Factor out the code to get an ACL either from the inode or disk from
check_acl, so that it can be used elsewhere later on.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/namei.c| 24 +++-
fs/posix_acl.c
Copy the scheme I introduced to btrfs many years ago to only use the
xattr handler for ACLs, but pass plain attrs straight through.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Dave Kleikamp dave.kleik...@oracle.com
---
fs/jfs/acl.c | 105
-by: Christoph Hellwig h...@lst.de
---
fs/hfsplus/xattr.c | 87 ++--
1 file changed, 3 insertions(+), 84 deletions(-)
diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
index bf88baa..0b4a5c9 100644
--- a/fs/hfsplus/xattr.c
+++ b/fs/hfsplus/xattr.c
This contains some major refactoring for the create path so that
inodes are created with the right mode to start with instead of
fixing it up later.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/gfs2/acl.c | 234 +++
fs/gfs2/acl.h
And instead convert tmpfs to use the new generic ACL code, with two stub
methods provided for in-memory filesystems.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/Kconfig |6 +-
fs/Makefile |1 -
fs/generic_acl.c| 184
Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux,
and create inodes with the proper mode instead of fixing it up later.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Dave Chinner dchin
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/Makefile|2 +-
fs/posix_acl.c | 180 +---
fs/xattr_acl.c | 180
3 files changed, 174 insertions(+), 188 deletions(-)
delete
Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/btrfs/acl.c | 142 +++---
fs/btrfs/ctree.h |7
Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/jffs2/acl.c | 141
fs/jffs2/acl.h
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Vyacheslav Dubeyko sl...@dubeyko.com
---
fs/hfsplus/acl.h |9 +--
fs/hfsplus/dir.c |1 +
fs/hfsplus/inode.c |3 +-
fs/hfsplus/posix_acl.c | 168 +---
fs/hfsplus
Rename the current posix_acl_created to __posix_acl_create and add
a fully featured helper to set up the ACLs on file creation that
uses get_acl().
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jan Kara j...@suse.cz
---
fs/9p/acl.c |2 +-
fs/btrfs/acl.c
On Sat, Dec 21, 2013 at 08:07:51PM +0300, Vyacheslav Dubeyko wrote:
-static int can_set_xattr(struct inode *inode, const char *name,
- const void *value, size_t value_len)
This function works for all handlers. So, I don't think that it makes sense
to delete it.
On Mon, Jan 06, 2014 at 05:16:01PM -0500, Bob Peterson wrote:
Hi,
This patch calls get_write_access in function gfs2_setattr_chown,
which merely increases inode-i_writecount for the duration of the
function. That will ensure that any file closes won't delete the
inode's multi-block
On Mon, Feb 03, 2014 at 01:03:32PM -0800, Linus Torvalds wrote:
Now, to be honest, pushing it down one more level (to
generic_permission()) will actually start causing some trouble. In
particular, gfs2_permission() fundamentally does not have a dentry for
several of the callers.
Looking over
, *flp);
-
Can you keep the tracepoint and modify it to not need the file_lock
pointer? It really helped me with some debugging lately.
Otherwise looks fine,
Reviewed-by: Christoph Hellwig h...@lst.de
On Sat, Aug 23, 2014 at 10:41:14AM -0400, Jeff Layton wrote:
In later patches, we're going to add a new lock_manager_operation to
finish setting up the lease while still holding the i_lock. To do
this, we'll need to pass a little bit of info in the fcntl setlease
case (primarily an fasync
be freed.
Ensure that that doesn't occur by taking the i_lock before trying
to check the lease.
Looks good. Also looks way cleaner than before by being just a tad more
verbose..
Reviewed-by: Christoph Hellwig h...@lst.de
...@primarydata.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
always set that at the same time so it will have the same
semantics.
Signed-off-by: Jeff Layton jlay...@primarydata.com
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Sat, Aug 23, 2014 at 10:41:12AM -0400, Jeff Layton wrote:
Some of the latter paragraphs seem ambiguous and just plain wrong.
In particular the break_lease comment makes no sense. We call
break_lease (and break_deleg) from all sorts of vfs-layer functions,
so there is clearly such a method.
On Sun, Aug 24, 2014 at 06:08:01AM -0400, Jeff Layton wrote:
Can you just return -EEXIST if reusing an existing one and make it a
normal private pointer a we use elsewhere?
That sounds a little confusing...
We have two pointers we pass down to generic_setlease: the file_lock
itself
I like this change a lot! But one caveat:
+ /*
+ * Despite the fact that it's an int return function, __f_setown never
+ * returns an error. Just ignore any error return here, but spew a
+ * WARN_ON_ONCE in case this ever changes.
+ */
+
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
Some comments on further work I'd like to see in this area, though:
+ spin_lock(inode-i_lock);
+ time_out_leases(inode);
for (before = inode-i_flock;
((fl = *before) != NULL) IS_LEASE(fl
On Sat, Aug 23, 2014 at 10:41:17AM -0400, Jeff Layton wrote:
There was only one place where we still could free a file_lock while
holding the i_lock -- lease_modify. Add a new list_head argument to the
lm_change operation, pass in a private list when calling it, and fix
those callers to
One more wishlist item in addition to the one mentioned in the patches:
- add a return value to lm_break so that the lock manager can tell the
core code you can delete this lease right now. That gets rid of
the games with the timeout which require all kinds of race avoidance
code in
On Sun, Aug 24, 2014 at 09:06:34AM -0700, Christoph Hellwig wrote:
We really should split a lm_release from lm_change, the way it is
used is highly confusing. In addition I think a lot of code
currently in lease_modify should move here instead, e.g. something like:
At this point the old
On Sun, Aug 24, 2014 at 09:19:53PM -0400, Jeff Layton wrote:
I don't think this is a good idea. The errors in __f_setown come from
the security modules, and they could change easily. If you can convince
the LSM people to change their file_set_fowner routine to return void
we could change
On Sun, Aug 24, 2014 at 09:43:01PM -0400, Jeff Layton wrote:
- add a return value to lm_break so that the lock manager can tell the
core code you can delete this lease right now. That gets rid of
the games with the timeout which require all kinds of race avoidance
code in the
On Thu, Sep 04, 2014 at 08:38:27AM -0400, Jeff Layton wrote:
GFS2 and NFS have setlease routines that always just return -EINVAL.
Turn that into a generic routine that can live in fs/libfs.c.
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Thu, Sep 04, 2014 at 02:25:35PM -0400, Trond Myklebust wrote:
Actually, it looks as if when you compile with !CONFIG_FILE_LOCKING,
then fcntl_setlease() returns the value '0' (which would be
success!). The word confusing only begins to describe it all.
That's incorrect for sure, we should
I still very much disagree with the s_inode_fields indirection. Please
find a patch below to remove it, and use a get_dquots super_block
operation instead. This leads to less and better readable code,
and serves 4 bytes in every inode in the system. Additionally the
indirection could easily be
On Fri, Oct 17, 2014 at 09:24:28PM +0200, Jan Kara wrote:
I don't see the 4-bytes per inode saving, what am I missing? Frankly, I
don't see a difference in readability but since you and Al agree on that I
concede to your taste :)
It's the removal of s_inode_fields that saves 4 bytes.
On Sat, Oct 18, 2014 at 09:26:24PM +0200, Jan Kara wrote:
But that was in the superblock, not in the inode...
You're right! Sorry for the confusion.
This looks like a big indicator that get_blocks is the wrong
interface for fiemap.
On Tue, Oct 21, 2014 at 04:38:26PM +0200, Jan Kara wrote:
Currently all filesystems supporting VFS quota support user and group
quotas. With introduction of project quotas this is going to change so
make sure filesystem isn't called for quota type it doesn't support by
introduction of a
On Wed, Oct 22, 2014 at 08:28:53AM -0400, Bob Peterson wrote:
Yes, I thought about that.
One of my early prototypes had a separate function used by fiemap.
Function __generic_block_fiemap would call get_block() which
returned an indication of a hole as it does today. When it saw
the hole,
Looks good,
Acked-by: Christoph Hellwig h...@lst.de
;
+ case PRJQUOTA:
+ return FS_QUOTA_PDQ_ENFD;
+ }
+ return 0;
What's the limit_ in the name supposed to mean?
Otherwise looks good:
Reviewed-by: Christoph Hellwig h...@lst.de
-off-by: Jan Kara j...@suse.cz
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
On Fri, Jan 16, 2015 at 01:47:37PM +0100, Jan Kara wrote:
+EXPORT_SYMBOL(dquot_quota_enable);
+EXPORT_SYMBOL(dquot_quota_disable);
I can't find any modular users of this (in fact none outside this
file), so I'd suggest to keep these local.
+static void xfs_qm_fill_state(struct qc_type_state *tstate,
Normal xfs style would be to keep the static void on a separate line,
as well as the arguments, e.g.
static void
xfs_qm_fill_state(
struct qc_type_state*tstate,
+ struct xfs_mount *mp,
+
On Fri, Jan 16, 2015 at 01:47:43PM +0100, Jan Kara wrote:
Call -quota_sync method from Q_XQUOTASYNC for better userspace
compatibility.
Q_XQUOTASYNC never did the equivalent to -quota_sync, but rather was
the equivalent to sys_syncfs which also happens to write out quotas.
Unless you have a
1 - 100 of 976 matches
Mail list logo
