Re: [Cluster-devel] [RFC PATCH 1/5] new helper: iov_iter_rw()

On Mon, Mar 16, 2015 at 05:36:05PM +, Al Viro wrote: On Mon, Mar 16, 2015 at 04:33:49AM -0700, Omar Sandoval wrote: Get either READ or WRITE out of iter-type. Umm... + * Get one of READ or WRITE out of iter-type without any other flags OR'd in + * with it. + */ +static

Re: [Cluster-devel] [PATCH 04/21] fs: Replace CURRENT_TIME with current_fs_time() for inode timestamps

s_time(). Also, > current_fs_time() will be transitioned along with vfs to be > y2038 safe. > > Signed-off-by: Deepa Dinamani <deepa.ker...@gmail.com> > Cc: David Sterba <dste...@suse.com> for the btrfs bits Reviewed-by: David Sterba <dste...@suse.com>

Re: [Cluster-devel] [PATCH 4/7] mm: introduce memalloc_nofs_{save, restore} API

On Tue, Mar 07, 2017 at 04:09:56PM +0100, Michal Hocko wrote: > On Mon 06-03-17 13:22:14, Andrew Morton wrote: > > On Mon, 6 Mar 2017 14:14:05 +0100 Michal Hocko wrote: > [...] > > > --- a/include/linux/gfp.h > > > +++ b/include/linux/gfp.h > > > @@ -210,8 +210,16 @@ struct

Re: [Cluster-devel] vmalloc with GFP_NOFS

On Wed, May 09, 2018 at 03:42:22PM +0200, Michal Hocko wrote: > On Tue 24-04-18 13:25:42, Michal Hocko wrote: > [...] > > > As a suggestion, could you take > > > documentation about how to convert to the memalloc_nofs_{save,restore} > > > scope api (which I think you've written about e-mails at

Re: [Cluster-devel] [PATCH v8 06/10] iomap: Add page_write_end iomap hook

On Tue, Jun 05, 2018 at 02:17:38PM +0200, Andreas Grünbacher wrote: > 2018-06-05 14:07 GMT+02:00 David Sterba : > > On Mon, Jun 04, 2018 at 09:31:19PM +0200, Andreas Gruenbacher wrote: > >> --- a/fs/iomap.c > >> +++ b/fs/iomap.c > >> @@ -181,16 +181,22 @@ i

Re: [Cluster-devel] [PATCH v8 06/10] iomap: Add page_write_end iomap hook

On Mon, Jun 04, 2018 at 09:31:19PM +0200, Andreas Gruenbacher wrote: > --- a/fs/iomap.c > +++ b/fs/iomap.c > @@ -181,16 +181,22 @@ iomap_write_begin(struct inode *inode, loff_t pos, > unsigned len, unsigned flags, > > static int > iomap_write_end(struct inode *inode, loff_t pos, unsigned len,

Re: [Cluster-devel] [PATCH v8 03/10] iomap: Complete partial direct I/O writes synchronously

On Mon, Jun 04, 2018 at 09:31:16PM +0200, Andreas Gruenbacher wrote: > @@ -1062,8 +1063,9 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > if (ret < 0) > iomap_dio_set_error(dio, ret); > > + smp_mb__before_atomic(); > if (!atomic_dec_and_test(>ref)) {

Re: [Cluster-devel] [PATCH V10 12/19] block: allow bio_for_each_segment_all() to iterate over multi-page bvec

On Thu, Nov 15, 2018 at 04:52:59PM +0800, Ming Lei wrote: > diff --git a/block/blk-zoned.c b/block/blk-zoned.c > index 13ba2011a306..789b09ae402a 100644 > --- a/block/blk-zoned.c > +++ b/block/blk-zoned.c > @@ -123,6 +123,7 @@ static int blk_report_zones(struct gendisk *disk, > sector_t sector, >

Re: [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS

nsigned everywhere. > fs/btrfs/ioctl.c| 13 + For the btrfs bits Acked-by: David Sterba and besides the signedness, the rest of the changes look good to me.

Re: [PATCH 2/4] vfs: create a generic checking function for FS_IOC_FSSETXATTR

On Tue, Jun 25, 2019 at 03:57:25AM -0700, Christoph Hellwig wrote: > On Fri, Jun 21, 2019 at 04:56:29PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Create a generic checking function for the incoming FS_IOC_FSSETXATTR > > fsxattr values so that we can standardize some of the

Re: [PATCH 2/4] vfs: create a generic checking function for FS_IOC_FSSETXATTR

On Tue, Jun 25, 2019 at 10:16:16AM -0700, Darrick J. Wong wrote: > On Tue, Jun 25, 2019 at 07:02:48PM +0200, David Sterba wrote: > > On Tue, Jun 25, 2019 at 03:57:25AM -0700, Christoph Hellwig wrote: > > > On Fri, Jun 21, 2019 at 04:56:29PM -0700, Darrick J. Wong wrote: >

Re: [Cluster-devel] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr

-t...@android.com > Cc: linux-security-mod...@vger.kernel.org > Cc: sta...@vger.kernel.org # 4.4, 4.9, 4.14 & 4.19 > --- > v8: > - Documentation reported 'struct xattr_gs_flags' rather than > 'struct xattr_gs_flags *args' as argument to get and set methods. For btrfs > fs/btrfs/xattr.c | 36 +- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH v8 17/25] btrfs: Convert from readpages to readahead

On Wed, Feb 26, 2020 at 09:05:07AM -0800, Christoph Hellwig wrote: > On Tue, Feb 25, 2020 at 01:48:30PM -0800, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > > to optimise fetching a batch of pages at

Re: [Cluster-devel] [PATCH v4 00/12] Change readahead API

On Sat, Feb 01, 2020 at 07:12:28AM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > I would particularly value feedback on this from the gfs2 and ocfs2 > maintainers. They have non-trivial changes, and a review on patch 5 > would be greatly appreciated. > > This series adds a

Re: [Cluster-devel] [PATCH v7 00/23] Change readahead API

On Wed, Feb 19, 2020 at 01:00:39PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This series adds a readahead address_space operation to eventually > replace the readpages operation. The key difference is that > pages are added to the page cache as they are allocated (and >

Re: [Cluster-devel] [PATCH v7 00/23] Change readahead API

On Thu, Feb 20, 2020 at 02:39:09PM -0800, Matthew Wilcox wrote: > > > - Now passes an xfstests run on ext4! > > > > On btrfs it still chokes on the first test btrfs/001, with the following > > warning, the test is stuck there. > > Thanks. The warning actually wasn't the problem, but it did

Re: [Cluster-devel] [PATCH v10 17/25] btrfs: Convert from readpages to readahead

ucharski Sorry for late reply, Reviewed-by: David Sterba

Re: [Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

On Mon, Jul 13, 2020 at 07:20:50AM -0500, Goldwyn Rodrigues wrote: > On 9:46 13/07, Christoph Hellwig wrote: > > Failing to invalid the page cache means data in incoherent, which is > > a very bad state for the system. Always fall back to buffered I/O > > through the page cache if we can't

Re: [Cluster-devel] [PATCH 11/27] block: add a bdev_write_cache helper

bd-srv.c | 2 +- > drivers/block/xen-blkback/xenbus.c | 2 +- > drivers/target/target_core_iblock.c | 8 ++-- For > fs/btrfs/disk-io.c | 3 +-- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 07/27] btrfs: use bdev_max_active_zones instead of open coding it

On Wed, Apr 06, 2022 at 08:04:56AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig As it's a standalone patch I can take it (possibly with other similar prep btrfs patches) in current development cycle to relieve the inter-tree dependencies.

Re: [Cluster-devel] [PATCH 10/27] block: add a bdev_nonrot helper

| 2 +- > drivers/target/target_core_file.c | 3 +-- > drivers/target/target_core_iblock.c | 2 +- For > fs/btrfs/volumes.c | 4 ++-- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 23/27] block: add a bdev_max_discard_sectors helper

e_device.c | 8 +++- For > fs/btrfs/extent-tree.c | 4 ++-- > fs/btrfs/ioctl.c| 2 +- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD

vers/md/raid5-cache.c| 6 +-- > drivers/mmc/core/queue.c| 2 +- > drivers/nvme/target/io-cmd-bdev.c | 2 +- > drivers/target/target_core_file.c | 2 +- > drivers/target/target_core_iblock.c | 2 +- For > fs/btrfs/extent-tree.c | 4 +- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 24/27] block: add a bdev_discard_granularity helper

| 5 ++--- > drivers/block/drbd/drbd_nl.c| 9 + > drivers/block/drbd/drbd_receiver.c | 3 +-- > drivers/block/loop.c| 2 +- > drivers/target/target_core_device.c | 3 +-- For > fs/btrfs/ioctl.c| 12 ++++ Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it

On Sat, Apr 09, 2022 at 06:50:24AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 25/27] block: add a bdev_discard_granularity helper

tersen > Acked-by: Christoph Böhmwalder [btrfs] This is for drbd > Acked-by: Ryusuke Konishi > Acked-by: David Sterba [btrfs]

Re: [Cluster-devel] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

-- > drivers/mmc/core/queue.c| 1 - > drivers/mtd/mtd_blkdevs.c | 1 - > drivers/nvme/host/core.c| 6 ++ > drivers/s390/block/dasd_fba.c | 1 - > drivers/scsi/sd.c | 2 -- > drivers/target/target_core_device.c | 2 +- For > fs/btrfs/extent-tree.c | 4 ++-- > fs/btrfs/ioctl.c| 2 +- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 27/27] direct-io: remove random prefetches

added the prefetch, 65dd2aa90aa1 ("dio: optimize cache misses in the submission path") and also remove #include as there are no more uses of prefetch in the file. With that Reviewed-by: David Sterba

Re: [Cluster-devel] [PATCH v2] fs: remove unnecessary conditional

On Fri, Apr 08, 2022 at 02:11:36AM +, cgel@gmail.com wrote: > From: Lv Ruyi > > iput() has already handled null and non-null parameter, so it is no > need to use if(). > > This patch remove all unnecessary conditional in fs subsystem. > No functional changes. You'd need to split i by

Re: [Cluster-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio

On Wed, Jun 08, 2022 at 04:02:42PM +0100, Matthew Wilcox (Oracle) wrote: > Use filemap_migrate_folio() to do the bulk of the work, and then copy > the ordered flag across if needed. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: David Ste

Re: [Cluster-devel] [PATCH v2 08/19] btrfs: Convert btree_migratepage to migrate_folio

On Wed, Jun 08, 2022 at 04:02:38PM +0100, Matthew Wilcox (Oracle) wrote: > Use a folio throughout this function. migrate_page() will be converted > later. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: David Sterba

Re: [Cluster-devel] [PATCH v2 10/19] mm/migrate: Convert migrate_page() to migrate_folio()

igned-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- > drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 4 +-- For > fs/btrfs/disk-io.c | 2 +- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio

On Thu, Jun 09, 2022 at 06:40:28PM +0100, Matthew Wilcox wrote: > On Thu, Jun 09, 2022 at 06:33:23PM +0200, David Sterba wrote: > > On Wed, Jun 08, 2022 at 04:02:42PM +0100, Matthew Wilcox (Oracle) wrote: > > > Use filemap_migrate_folio() to do the bulk of the work, and then copy

Re: [Cluster-devel] [PATCH 07/23] btrfs: Convert extent_write_cache_pages() to use filemap_get_folios_tag()

On Thu, Sep 01, 2022 at 03:01:22PM -0700, Vishal Moola (Oracle) wrote: > Converted function to use folios throughout. This is in preparation for > the removal of find_get_pages_range_tag(). Now also supports large > folios. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 06/23] btrfs: Convert btree_write_cache_pages() to use filemap_get_folio_tag()

On Thu, Sep 01, 2022 at 03:01:21PM -0700, Vishal Moola (Oracle) wrote: > Converted function to use folios throughout. This is in preparation for > the removal of find_get_pages_range_tag(). > > Signed-off-by: Vishal Moola (Oracle) Acked-by: David Sterba

Re: [Cluster-devel] [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio

/afs/dir.c | 10 +- > fs/afs/dir_edit.c| 2 +- > fs/afs/write.c | 4 ++-- For > fs/btrfs/disk-io.c | 2 +- Acked-by: David Sterba

Re: [Cluster-devel] [PATCH v2 00/19] bio: check return values of bio_add_page

On Thu, Mar 30, 2023 at 03:43:42AM -0700, Johannes Thumshirn wrote: > We have two functions for adding a page to a bio, __bio_add_page() which is > used to add a single page to a freshly created bio and bio_add_page() which is > used to add a page to an existing bio. > > While __bio_add_page() is

Re: [Cluster-devel] [PATCH v2 00/19] bio: check return values of bio_add_page

On Thu, Mar 30, 2023 at 04:41:58PM +, Johannes Thumshirn wrote: > On 30.03.23 17:52, David Sterba wrote: > > On Thu, Mar 30, 2023 at 03:43:42AM -0700, Johannes Thumshirn wrote: > >> We have two functions for adding a page to a bio, __bio_add_page() which is > >>