Re: [Cluster-devel] Re: gfs2-utils: master - gfs_controld: Remove three unused functions

2009-10-16 Thread Steven Whitehouse
Hi, On Wed, 2009-10-14 at 12:53 -0500, David Teigland wrote: On Wed, Oct 14, 2009 at 02:55:04PM +, Steven Whitehouse wrote: gfs_controld: Remove three unused functions These functions are not called from anywhere and appear to be left over from earlier times. They were just added

Re: [Cluster-devel] Re: gfs2-utils: master - gfs_controld: Remove three unused functions

2009-10-16 Thread Steven Whitehouse
Hi, On Fri, 2009-10-16 at 10:59 -0500, David Teigland wrote: On Fri, Oct 16, 2009 at 03:56:05PM +0100, Steven Whitehouse wrote: Hi, On Wed, 2009-10-14 at 12:53 -0500, David Teigland wrote: On Wed, Oct 14, 2009 at 02:55:04PM +, Steven Whitehouse wrote: gfs_controld: Remove three

Re: [Cluster-devel] Re: gfs2-utils: master - gfs_controld: Remove three unused functions

2009-10-19 Thread Steven Whitehouse
Hi, On Fri, 2009-10-16 at 11:33 -0500, David Teigland wrote: On Fri, Oct 16, 2009 at 05:01:18PM +0100, Steven Whitehouse wrote: Hi, On Fri, 2009-10-16 at 10:59 -0500, David Teigland wrote: On Fri, Oct 16, 2009 at 03:56:05PM +0100, Steven Whitehouse wrote: Hi, On Wed, 2009

Re: [Cluster-devel] [PATCH] GFS2: Improve statfs and quota usability, try 3

2009-10-21 Thread Steven Whitehouse
Hi, Now in the -nmw tree. Thanks, Steve. On Tue, 2009-10-20 at 02:39 -0500, Benjamin Marzinski wrote: GFS2 now has three new mount options, statfs_quantum, quota_quantum and statfs_percent. statfs_quantum and quota_quantum simply allow you to set the tunables of the same name. Setting

[Cluster-devel] Re: linux-next: Tree for October 26 (gfs2)

2009-10-26 Thread Steven Whitehouse
Hi, On Mon, 2009-10-26 at 08:43 -0700, Randy Dunlap wrote: On Mon, 26 Oct 2009 17:21:04 +1100 Stephen Rothwell wrote: Hi all, Changes since 20091016: on i386: (.text+0x723a8b): undefined reference to `__divdi3' super.c::gfs2_statfs_change(): percent = (100 *

[Cluster-devel] Re: [PATCH] GFS2: remove division from new statfs code

2009-10-27 Thread Steven Whitehouse
Hi, Now in the -nmw git tree. Thanks, Steve. On Mon, 2009-10-26 at 13:29 -0500, Benjamin Marzinski wrote: It's not necessary to do any 64bit division for the statfs sync code, so remove it. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com --- fs/gfs2/super.c | 17

[Cluster-devel] Re: [PATCH] gfs2: add barrier/nobarrier mount options

2009-10-30 Thread Steven Whitehouse
Hi, Thanks for the patch. I've pushed it to the -nmw tree now. I've also added a two-liner of my own to display the nobarrier option in /proc/mounts, Steve. On Fri, 2009-10-30 at 08:03 +0100, Christoph Hellwig wrote: Currently gfs2 issues barrier unconditionally. There are various reasons to

Re: [Cluster-devel] Re: [PATCH] misc: use a proper range for minor number dynamic allocation

2009-11-10 Thread Steven Whitehouse
Hi, On Mon, 2009-11-09 at 17:03 -0600, David Teigland wrote: On Mon, Nov 09, 2009 at 01:28:36PM -0800, Andrew Morton wrote: On Fri, 23 Oct 2009 21:28:17 -0200 Thadeu Lima de Souza Cascardo casca...@holoscopio.com wrote: The current dynamic allocation of minor number for misc devices

[Cluster-devel] GFS2: Clean up recovery code

2009-11-10 Thread Steven Whitehouse
The following patch cleans up the recovery code and fixes a few bugs along the way. The bugs are: o An incorrect assumption about the size of the journal o An issue where the superblock was being used to store variables local to the recovery process which would cause a problem if multiple

[Cluster-devel] Re: [PATCH 2/2] dlm: Add down/up_write_non_owner to keep lockdep happy

2009-11-12 Thread Steven Whitehouse
Hi, On Thu, 2009-11-12 at 17:45 +0100, Peter Zijlstra wrote: On Thu, 2009-11-12 at 11:14 -0600, David Teigland wrote: up_write_non_owner() addresses this trace, which as you say, is from doing the down and up from different threads (which is the intention): That's really something I

[Cluster-devel] Re: [PATCH 2/2] dlm: Add down/up_write_non_owner to keep lockdep happy

2009-11-13 Thread Steven Whitehouse
Hi, On Thu, 2009-11-12 at 12:34 -0600, David Teigland wrote: On Thu, Nov 12, 2009 at 05:24:12PM +, Steven Whitehouse wrote: Nov 12 15:10:01 chywoon kernel: [ INFO: possible recursive locking detected ] That recursive locking trace is something different. up_write_non_owner

[Cluster-devel] GFS2: Move glock ref count drop out of finish_xmote

2009-11-20 Thread Steven Whitehouse
that the culprit is at the end of finish_xmote. This patch removes the ref count drop from the end of finish_xmote and moves it into the callers of that function. This will ensure that in future the ref count cannot be dropped too early. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

Re: [Cluster-devel] [RFC] Proposal to align autotool versions

2009-11-24 Thread Steven Whitehouse
Hi, On Tue, 2009-11-24 at 14:33 +0100, Fabio M. Di Nitto wrote: Hi guys, I just completed testing of autotools in F13/rawhide and they seem to fulfill perfectly what we need so far. Fedora13 has: libtool 2.2.6 (doesn´t carry the bug for which we were forcing 2.2.7) autoconf 2.64

[Cluster-devel] GFS2: Extra early pre-pull patch posting

2009-11-25 Thread Steven Whitehouse
Due to the larger than usual content of new items in this patch set I'm posting it a bit earlier than normal so that there is more time for review. There are a few bug fixes in this set, but most of the content is new code relating to xattrs and quotas. The ACL support is cleaned up and support

[Cluster-devel] [PATCH 02/30] GFS2: Fix -o meta mounts for subsequent mounts (i.e. all but the first one)

2009-11-25 Thread Steven Whitehouse
. In addition this also fixes a bug where it was possible (but certainly not desirable) to set different ro/rw options for the meta root when mounted via the gfs2meta fs compared with the original mount. Signed-off-by: Steven Whitehouse swhit...@redhat.com Cc: Alexander Viro av...@redhat.com --- fs/gfs2

[Cluster-devel] [PATCH 03/30] GFS2: Fix up system xattrs

2009-11-25 Thread Steven Whitehouse
This code has been shamelessly stolen from XFS at the suggestion of Christoph Hellwig. I've not added support for cached ACLs so far... watch for that in a later patch, although this is designed in such a way that they should be easy to add. Signed-off-by: Steven Whitehouse swhit...@redhat.com Cc

[Cluster-devel] [PATCH 04/30] VFS: Add forget_all_cached_acls()

2009-11-25 Thread Steven Whitehouse
This is required for cluster filesystems which want to use cached ACLs so that they can invalidate the cache when required. Signed-off-by: Steven Whitehouse swhit...@redhat.com Cc: Alexander Viro av...@redhat.com Cc: Christoph Hellwig h...@infradead.org --- include/linux/posix_acl.h | 14

[Cluster-devel] [PATCH 05/30] GFS2: Use forget_all_cached_acls()

2009-11-25 Thread Steven Whitehouse
Invalidate all the cached ACLs when we drop the glock. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/glops.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 6985eef..78554ac 100644 --- a/fs/gfs2/glops.c +++ b

[Cluster-devel] [PATCH 06/30] GFS2: Use gfs2_set_mode() instead of munge_mode()

2009-11-25 Thread Steven Whitehouse
These two functions do the same thing, so lets only use one of them. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/acl.c | 46 +++--- 1 files changed, 11 insertions(+), 35 deletions(-) diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index

[Cluster-devel] [PATCH 07/30] GFS2: Clean up ACLs

2009-11-25 Thread Steven Whitehouse
To prepare for support for caching of ACLs, this cleans up the GFS2 ACL support by pushing the xattr code back into xattr.c and changing the acl_get function into one which only returns ACLs so that we can drop the caching function into it shortly. Signed-off-by: Steven Whitehouse swhit

[Cluster-devel] [PATCH 08/30] GFS2: Add cached ACLs support

2009-11-25 Thread Steven Whitehouse
The other patches in this series have been building towards being able to support cached ACLs like other filesystems. The only real difference with GFS2 is that we have to invalidate the cache when we drop a glock, but that is dealt with in earlier patches. Signed-off-by: Steven Whitehouse swhit

[Cluster-devel] [PATCH 09/30] VFS: Use GFP_NOFS in posix_acl_from_xattr()

2009-11-25 Thread Steven Whitehouse
GFS2 needs to call this from under a glock, so we need GFP_NOFS and I suspect that other filesystems might require this too. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/xattr_acl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/xattr_acl.c b/fs

[Cluster-devel] [PATCH 10/30] GFS2: Alter arguments of gfs2_quota/statfs_sync

2009-11-25 Thread Steven Whitehouse
These two functions are altered so that gfs2_quota_sync may in future be called directly from the VFS. The GFS2 superblock changes to a VFS super block and there is an addition of an int argument which is currently ignored. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c

[Cluster-devel] [PATCH 11/30] GFS2: Hook gfs2_quota_sync into VFS via gfs2_quotactl_ops

2009-11-25 Thread Steven Whitehouse
The plan is to add further operations to the gfs2_quotactl_ops in future patches. The sync operation is easy, so we start with that one. We plan to use the XFS quota control functions because they more closely match the GFS2 ones. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2

[Cluster-devel] [PATCH 12/30] GFS2: Remove obsolete code in quota.c

2009-11-25 Thread Steven Whitehouse
There is no point in testing for GLF_DEMOTE here, we might as well always release the glock at that point. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/glock.h |9 - fs/gfs2/quota.c | 13 + 2 files changed, 5 insertions(+), 17 deletions(-) diff

[Cluster-devel] [PATCH 13/30] GFS2: Add get_xstate quota function

2009-11-25 Thread Steven Whitehouse
This allows querying of the quota state via the XFS quota API. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 6aaa6c5..e7114be 100644

[Cluster-devel] [PATCH 14/30] GFS2: Add proper error reporting to quota sync via sysfs

2009-11-25 Thread Steven Whitehouse
For some reason, the errors were not making it to userspace. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/sys.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index be1b8ac..c5dad1e 100644 --- a/fs/gfs2/sys.c

[Cluster-devel] [PATCH 15/30] GFS2: Remove constant argument from qdsb_get()

2009-11-25 Thread Steven Whitehouse
The create argument to qdsb_get() was only ever set to true, so this patch removes that argument. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index

[Cluster-devel] [PATCH 16/30] GFS2: Remove constant argument from qd_get()

2009-11-25 Thread Steven Whitehouse
This function was only ever called with the create argument set to true, so we can remove it. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index f790f5a

[Cluster-devel] [PATCH 17/30] GFS2: Clean up gfs2_adjust_quota() and do_glock()

2009-11-25 Thread Steven Whitehouse
new comments, and I hope that the code is easier to understand now. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c | 82 +- 1 files changed, 26 insertions(+), 56 deletions(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2

[Cluster-devel] [PATCH 18/30] GFS2: Add get_xquota support

2009-11-25 Thread Steven Whitehouse
This adds support for viewing the current GFS2 quota settings via the XFS quota API. The setting of quotas will be addressed in a later patch. Fields which are not supported here are left set to zero. Signed-off-by: Steven Whitehouse swhit...@redhat.com Reviewed-by: Bob Peterson rpete

[Cluster-devel] [PATCH 19/30] GFS2: Add set_xquota support

2009-11-25 Thread Steven Whitehouse
This patch adds the ability to set GFS2 quota limit and warning levels via the XFS quota API. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c | 198 +++--- 1 files changed, 172 insertions(+), 26 deletions(-) diff --git

[Cluster-devel] [PATCH 20/30] VFS: Export dquot_send_warning

2009-11-25 Thread Steven Whitehouse
it for use by filesystems which do not use the dquot code. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/quota/Kconfig |2 +- fs/quota/dquot.c | 93 + fs/quota/quota.c | 93

[Cluster-devel] [PATCH 21/30] GFS2: Use dquot_send_warning()

2009-11-25 Thread Steven Whitehouse
This adds support to GFS2 to send quota warnings via netlink. Also it removes a stray \r which was left over from when the code used to print warnings on the console. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/quota.c | 10 +- 1 files changed, 9 insertions(+), 1

[Cluster-devel] [PATCH 22/30] GFS2: Improve statfs and quota usability

2009-11-25 Thread Steven Whitehouse
-by: Benjamin Marzinski bmarz...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/incore.h |4 +++ fs/gfs2/ops_fstype.c | 14 -- fs/gfs2/quota.c | 21 +-- fs/gfs2/quota.h |2 + fs/gfs2/super.c | 69

[Cluster-devel] [PATCH 23/30] GFS2: remove division from new statfs code

2009-11-25 Thread Steven Whitehouse
From: Benjamin Marzinski bmarz...@redhat.com It's not necessary to do any 64bit division for the statfs sync code, so remove it. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/super.c | 17 + 1 files

[Cluster-devel] [PATCH 24/30] GFS2: add barrier/nobarrier mount options

2009-11-25 Thread Steven Whitehouse
barrier option to turn it back on at remount time. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/incore.h |1 + fs/gfs2/ops_fstype.c |2 ++ fs/gfs2/super.c | 14 ++ 3 files changed, 17 insertions(+), 0

[Cluster-devel] [PATCH 25/30] GFS2: Display nobarrier option in /proc/mounts

2009-11-25 Thread Steven Whitehouse
Since the default is barriers on, this only displays the nobarrier option when that is active. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/super.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 5e4b314

[Cluster-devel] GFS2 git tree

2009-12-07 Thread Steven Whitehouse
Hi, Linus has pulled the -nmw tree. I'll leave it a few days before I start adding patches into the tree to avoid any confusion with those still trying to merge from linux-next, but don't let that delay you in posting any patches. If they are fixes, then they can go into the -fixes tree right

[Cluster-devel] GFS2: Metadata address space clean up

2009-12-07 Thread Steven Whitehouse
This is a heads up on a patch I'm working on to clean up the metadata address space which is used in GFS2. This is a preliminary version which passes a few basic tests. I'll probably make a few more changes before the final version. Since the start of GFS2, an extra inode has been used to store

[Cluster-devel] GFS2: Ensure uptodate inode size when using O_APPEND

2009-12-07 Thread Steven Whitehouse
another node coming in and extending the file in the mean time. On the other hand, when used with file locking this will ensure that the expected results are obtained. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 4eb308a..a6abbae 100644

[Cluster-devel] GFS2: Remove loopy umount code

2009-12-08 Thread Steven Whitehouse
This is a follow up to the patch I posted yesterday and does the next bit of the changes. From 69a14ddaf57449c3f6ecfe96a898df5ded1a4256 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Tue, 8 Dec 2009 15:45:50 + Subject: GFS2: Remove loopy umount code

[Cluster-devel] GFS2: Fix locking bug in rename

2009-12-09 Thread Steven Whitehouse
From 07bb4585daae6008fd3ad0f3f081e318a4266d1d Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Wed, 9 Dec 2009 13:55:12 + Subject: GFS2: Fix locking bug in rename The rename code was taking a resource group lock in cases where it wasn't actually needed, this caused

[Cluster-devel] GFS2: Fix gfs2_xattr_acl_chmod()

2009-12-21 Thread Steven Whitehouse
From a49cd198c9ed316255acc25a937ea147d03bccaa Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Mon, 21 Dec 2009 13:55:28 + Subject: GFS2: Fix gfs2_xattr_acl_chmod() The ref counting for the bh returned by gfs2_ea_find() was wrong. This patch ensures that we always

[Cluster-devel] git trees

2010-01-08 Thread Steven Whitehouse
Hi, After some delay due to a couple of tricky issues, I'm now back updating the GFS2 git trees again. I will probably send a pull request for the fixes tree fairly shortly now, I'm just giving it a day or two in -next first. At the moment -fixes and -nmw are identical, but I will start pushing

[Cluster-devel] GFS2: Use MAX_LFS_FILESIZE for meta inode size

2010-01-08 Thread Steven Whitehouse
From 2a6833f27a0ed34ae169dc61961552c414263770 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Fri, 8 Jan 2010 13:44:49 + Subject: GFS2: Use MAX_LFS_FILESIZE for meta inode size Using ~0ULL was cauing sign issues in filemap_fdatawrite_range, so use MAX_LFS_FILESIZE

[Cluster-devel] GFS2: Metadata address space clean up

2010-01-08 Thread Steven Whitehouse
From 89bf4bea39ab65e0aa608cf5927d4d9b9e189c19 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Tue, 8 Dec 2009 12:12:13 + Subject: GFS2: Metadata address space clean up Since the start of GFS2, an extra inode has been used to store the metadata belonging to each

[Cluster-devel] GFS2: Remove loopy umount code

2010-01-08 Thread Steven Whitehouse
From 086332de5db343f8029d4436725090c42fcac7c7 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Fri, 8 Jan 2010 16:14:29 + Subject: GFS2: Remove loopy umount code As a consequence of the previous patch, we can now remove the loop which used to be required due

[Cluster-devel] [PATCH 4/4] GFS2: Use MAX_LFS_FILESIZE for meta inode size

2010-01-11 Thread Steven Whitehouse
Using ~0ULL was cauing sign issues in filemap_fdatawrite_range, so use MAX_LFS_FILESIZE instead. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/meta_io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index

[Cluster-devel] [PATCH 3/4] GFS2: Fix gfs2_xattr_acl_chmod()

2010-01-11 Thread Steven Whitehouse
The ref counting for the bh returned by gfs2_ea_find() was wrong. This patch ensures that we always drop the ref count to that bh correctly. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/xattr.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions

[Cluster-devel] [PATCH 1/4] GFS2: Ensure uptodate inode size when using O_APPEND

2010-01-11 Thread Steven Whitehouse
another node coming in and extending the file in the mean time. On the other hand, when used with file locking this will ensure that the expected results are obtained. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/file.c | 38 -- 1 files

[Cluster-devel] [PATCH 2/4] GFS2: Fix locking bug in rename

2010-01-11 Thread Steven Whitehouse
The rename code was taking a resource group lock in cases where it wasn't actually needed, this caused problems if the rename was resulting in an inode being unlinked. The patch ensures that we only take the rgrp lock early if it is really needed. Signed-off-by: Steven Whitehouse swhit

[Cluster-devel] GFS2: Pre-pull patch posting (fixes)

2010-01-11 Thread Steven Whitehouse
Here are four small fixes for GFS2. Assuming that nobody spots any errors, I'll be sending a pull request for these shortly, Steve.

[Cluster-devel] GFS2: Pull request (fixes)

2010-01-11 Thread Steven Whitehouse
-fixes.git master Steven Whitehouse (4): GFS2: Ensure uptodate inode size when using O_APPEND GFS2: Fix locking bug in rename GFS2: Fix gfs2_xattr_acl_chmod() GFS2: Use MAX_LFS_FILESIZE for meta inode size fs/gfs2/file.c | 38

[Cluster-devel] GFS2 git trees

2010-01-12 Thread Steven Whitehouse
Hi, Linus pulled the -fixes tree last night, so I'm just about to rebase both GFS2 git trees to the new upstream kernel, Steve.

Re: [Cluster-devel] [PATCH] gfs2: Fix refcnt leak on gfs2_follow_link() error path

2010-01-12 Thread Steven Whitehouse
Hi, Thanks for the patch. I've pushed it into the GFS2 -fixes tree, Steve. On Tue, 2010-01-12 at 03:36 +0900, OGAWA Hirofumi wrote: If -follow_link handler return the error, it should decrement nd-path refcnt. This patch fix it. Signed-off-by: OGAWA Hirofumi hirof...@mail.parknet.co.jp

[Cluster-devel] GFS2: Wait for unlock completion on umount

2010-01-14 Thread Steven Whitehouse
This patch adds a wait on umount between the point at which we dispose of all glocks and the point at which we unmount the lock protocol. This ensures that we've received all the replies to our unlock requests before we stop the locking. Signed-off-by: Steven Whitehouse swhit...@redhat.com

[Cluster-devel] GFS2: Fix previous patch

2010-01-29 Thread Steven Whitehouse
This fixes the rgrp patch, Steve. From ea0d7284f2f2bd56386e6c4810bf970e50472054 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Fri, 29 Jan 2010 15:20:34 + Subject: [PATCH 1/3] GFS2: Fix previous patch The do_div() call needs to remain. Signed-off-by: Steven

[Cluster-devel] GFS2: Extend umount wait coverage to full glock lifetime

2010-01-29 Thread Steven Whitehouse
From 0f76b65f50e4f17324ba184dd074c35788928ba7 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Fri, 29 Jan 2010 15:21:27 + Subject: [PATCH 2/3] GFS2: Extend umount wait coverage to full glock lifetime Although all glocks are, by the time of the umount glock wait

[Cluster-devel] GFS2: Use GFP_NOFS for alloc structure

2010-01-29 Thread Steven Whitehouse
From 04988c7ee83641ca732910aff427ab08b0faa557 Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Fri, 29 Jan 2010 15:48:57 + Subject: [PATCH 3/3] GFS2: Use GFP_NOFS for alloc structure This is called under a glock, so its a good plan to use GFP_NOFS Signed-off

[Cluster-devel] [PATCH 1/4] GFS2: Fix refcnt leak on gfs2_follow_link() error path

2010-02-02 Thread Steven Whitehouse
From: OGAWA Hirofumi hirof...@mail.parknet.co.jp If -follow_link handler return the error, it should decrement nd-path refcnt. This patch fix it. Signed-off-by: OGAWA Hirofumi hirof...@mail.parknet.co.jp Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/ops_inode.c |3 ++- 1

[Cluster-devel] [PATCH 4/4] GFS2: Use GFP_NOFS for alloc structure

2010-02-02 Thread Steven Whitehouse
This is called under a glock, so its a good plan to use GFP_NOFS Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/rgrp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 46534a5..503b842 100644 --- a/fs/gfs2/rgrp.c

[Cluster-devel] [PATCH 2/4] GFS2: Don't withdraw on partial rindex entries

2010-02-02 Thread Steven Whitehouse
process may see partial entries. On grows, this is fine. The process can simply ignore the the partial entires. Previously, the code withdrew when it saw partial entries. Now it simply ignores them. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com Signed-off-by: Steven Whitehouse swhit

[Cluster-devel] [PATCH 3/4] GFS2: Fix previous patch

2010-02-02 Thread Steven Whitehouse
The do_div() call needs to remain. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/rgrp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 6702b82..46534a5 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -591,6

[Cluster-devel] [GFS2] Pull request (fixes)

2010-02-02 Thread Steven Whitehouse
() error path Steven Whitehouse (2): GFS2: Fix previous patch GFS2: Use GFP_NOFS for alloc structure fs/gfs2/ops_inode.c |3 ++- fs/gfs2/rgrp.c |8 ++-- 2 files changed, 4 insertions(+), 7 deletions(-)

[Cluster-devel] GFS2: Pre-pull patch posting (fixes)

2010-02-04 Thread Steven Whitehouse
Hi, Here are a couple of patches which between them fix a problem where occasionally it was possible for the GFS2 module to be unloaded before all the glocks were deallocated, which, needless to say, made the slab allocator unhappy, Steve.

[Cluster-devel] [PATCH 1/2] GFS2: Wait for unlock completion on umount

2010-02-04 Thread Steven Whitehouse
This patch adds a wait on umount between the point at which we dispose of all glocks and the point at which we unmount the lock protocol. This ensures that we've received all the replies to our unlock requests before we stop the locking. Signed-off-by: Steven Whitehouse swhit...@redhat.com

[Cluster-devel] [PATCH 2/2] GFS2: Extend umount wait coverage to full glock lifetime

2010-02-04 Thread Steven Whitehouse
catch all glocks. It does make it a bit more invasive, but it seems the only sensible solution at the moment. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/glock.c |4 fs/gfs2/glock.h |2 +- fs/gfs2/lock_dlm.c |6 +++--- fs/gfs2/ops_fstype.c | 10

[Cluster-devel] GFS2: Pull request (fixes)

2010-02-04 Thread Steven Whitehouse
/linux-2.6-block are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-fixes.git master Steven Whitehouse (2): GFS2: Wait for unlock completion on umount GFS2: Extend umount wait coverage to full glock lifetime fs/gfs2/glock.c

Re: [Cluster-devel] [PATCH 1/4] gfs2: add IO submission trace points

2010-02-05 Thread Steven Whitehouse
Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: Useful for tracking down where specific IOs are being issued from. Signed-off-by: Dave Chinner dchin...@redhat.com --- fs/gfs2/log.c|6 ++ fs/gfs2/lops.c |6 ++ fs/gfs2/trace_gfs2.h | 41

Re: [Cluster-devel] [PATCH 2/4] gfs2: ordered writes are backwards

2010-02-05 Thread Steven Whitehouse
Hi, This looks good. There is an argument for trying to sort the buffers as we write them (in case the application writes them out of order) but this seems a sensible change to catch 90% of cases. I'm just about to give this a quick test and I'll push this one in straight away if it looks good on

Re: [Cluster-devel] [PATCH 3/4] gfs2: ordered buffer writes are not sync

2010-02-05 Thread Steven Whitehouse
Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: Currently gfs2 ordered buffer writes use WRITE_SYNC_PLUG as the IO type being dispatched. They aren't sync writes; we issue all the IO pending, then wait for it all. IOWs, this is async IO with a bulk wait on the end. We should use

Re: [Cluster-devel] [PATCH 4/4] gfs2: introduce AIL lock

2010-02-05 Thread Steven Whitehouse
Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: THe log lock is currently used to protect the AIL lists and the movements of buffers into and out of them. The lists are self contained and no log specific items outside the lists are accessed when starting or emptying the AIL lists.

Re: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

2010-02-08 Thread Steven Whitehouse
Hi, Now in the GFS2 -nmw git tree. Thanks, Steve. On Fri, 2010-02-05 at 18:25 -0500, Abhijith Das wrote: Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one. --Abhi - Abhijith Das a...@redhat.com wrote: From: Abhijith Das

[Cluster-devel] GFS2: Fix bmap allocation corner-case bug

2010-02-11 Thread Steven Whitehouse
for the metadata are returned. By changing the exit condition of this loop, we ensure that a minimum of one data block will always be returned. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 6d47379..583e823 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2

[Cluster-devel] [PATCH 2/2] GFS2: Fix bmap allocation corner-case bug

2010-02-12 Thread Steven Whitehouse
for the metadata are returned. By changing the exit condition of this loop, we ensure that a minimum of one data block will always be returned. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/bmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs

[Cluster-devel] [GFS2] Pre-pull patch posting (fixes)

2010-02-12 Thread Steven Whitehouse
Hi, Here are a couple of GFS2 fixes. Both are one-liners, Steve.

[Cluster-devel] [PATCH 1/2] GFS2: Fix error code

2010-02-12 Thread Steven Whitehouse
From: Abhijith Das a...@redhat.com We need this one-liner to signal the mount helper of the 'insufficient journals' condition. Signed-off-by: Abhijith Das a...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/ops_fstype.c |2 +- 1 files changed, 1 insertions

[Cluster-devel] GFS2: Pull request (fixes)

2010-02-12 Thread Steven Whitehouse
/.../bp/bp are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-2.6-fixes.git master Abhijith Das (1): GFS2: Fix error code Steven Whitehouse (1): GFS2: Fix bmap allocation corner-case bug fs/gfs2/bmap.c |2 +- fs/gfs2

[Cluster-devel] GFS2: -nmw git tree

2010-02-13 Thread Steven Whitehouse
Hi, Linus has pulled a couple of fixes, so I've rebased the -nmw git tree again, Steve.

[Cluster-devel] [dlm] Two small sysfs patches

2010-02-17 Thread Steven Whitehouse
Hi, Please queue the following two patches for the next merge window for dlm. The first one adds a new sysfs variable so that the lockspace can be obtained without resorting to parsing the initial line of the sysfs message. The second one removes some obsolete code relating to one of the sysfs

[Cluster-devel] [PATCH 1/2] dlm: Send lockspace name with uevents

2010-02-17 Thread Steven Whitehouse
Although it is possible to get this information from the path, its much easier to provide the lockspace as a seperate env variable. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/dlm/lockspace.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git

[Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup

2010-02-17 Thread Steven Whitehouse
We don't need to look up the lockspace in this particular case since we already have a pointer to it (which was being dereferenced in order to do the lookup in the first place). Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/dlm/lockspace.c |6 +- 1 files changed, 1

[Cluster-devel] dlm: Remove/bypass astd

2010-02-17 Thread Steven Whitehouse
effects of network latency. Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/dlm/Makefile|3 +- fs/dlm/ast.c | 165 fs/dlm/ast.h | 26 fs/dlm/lock.c | 16 - fs/dlm/lockspace.c | 17 +- fs

Re: [Cluster-devel] dlm: Remove/bypass astd

2010-02-17 Thread Steven Whitehouse
be an option for userspace applications, but that's a different story altogether, of course Chrissie Yes, I've left the userspace interface code alone for now. That continues to work in the original way. My main concern is with the kernel interface at the moment, Steve. On 17/02/10 13:23, Steven

Re: [Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup

2010-02-18 Thread Steven Whitehouse
Hi, On Wed, 2010-02-17 at 15:12 -0500, David Teigland wrote: On Wed, Feb 17, 2010 at 09:41:35AM +, Steven Whitehouse wrote: We don't need to look up the lockspace in this particular case since we already have a pointer to it (which was being dereferenced in order to do the lookup

Re: [Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup

2010-02-19 Thread Steven Whitehouse
Hi, On Thu, 2010-02-18 at 16:04 -0500, David Teigland wrote: On Thu, Feb 18, 2010 at 09:16:03AM +, Steven Whitehouse wrote: I'm not sure what more I can say here this is a sysfs file store function and one of the reasons for using it is that sysfs looks after the ref counting

[Cluster-devel] [PATCH 4/5] GFS2: ordered writes are backwards

2010-03-01 Thread Steven Whitehouse
to 50MB/s for cfq. Signed-off-by: Dave Chinner dchin...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/lops.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index de97632..adc260f 100644 --- a/fs/gfs2/lops.c

[Cluster-devel] [PATCH 5/5] GFS2: print glock numbers in hex

2010-03-01 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch changes glock numbers from printing in decimal to hex. Since DLM prints corresponding resource IDs in hex, it makes debugging easier. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs

[Cluster-devel] [PATCH 2/5] GFS2: Remove loopy umount code

2010-03-01 Thread Steven Whitehouse
there is no longer any danger of the inode invalidation calling back into the glock code (and from there back into the inode code). Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/glock.c | 33 ++--- fs/gfs2/incore.h |1 - fs/gfs2/ops_fstype.c |4

[Cluster-devel] GFS2: Pull request

2010-03-02 Thread Steven Whitehouse
Dave Chinner (1): GFS2: ordered writes are backwards Steven Whitehouse (2): GFS2: Metadata address space clean up GFS2: Remove loopy umount code fs/gfs2/aops.c |4 +- fs/gfs2/glock.c | 75 ++- fs/gfs2

Re: [Cluster-devel] [PATCH] gfs2: do not select QUOTA

2010-03-03 Thread Steven Whitehouse
Hi, Looks good. Since I'm waiting for Linus to pull at the moment, I'll wait for that to happen and send this in the next batch of patches, Steve. On Wed, 2010-03-03 at 08:53 -0500, Christoph Hellwig wrote: gfs2 only needs the quotactl code, not the generic quota implementation.

[Cluster-devel] GFS2 -nmw git tree

2010-03-09 Thread Steven Whitehouse
Hi, Now that 2.6.34-rc1 is out, I've redone the -nmw git tree. There is only one small patch in it at the moment. No doubt there will be more in the not too distant future, Steve.

[Cluster-devel] GFS2: Pre-pull patch posting

2010-03-11 Thread Steven Whitehouse
Here are three small (but important!) fixes to GFS2. Steve.

[Cluster-devel] [PATCH 2/3] GFS2: Allow the number of committed revokes to temporarily be negative

2010-03-11 Thread Steven Whitehouse
that it mataches the actual number of revokes. Signed-off-by: Benjamin Marzinski bmarz...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/incore.h |2 +- fs/gfs2/log.c|3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/gfs2/incore.h b

[Cluster-devel] [PATCH 1/3] GFS2: do not select QUOTA

2010-03-11 Thread Steven Whitehouse
From: Christoph Hellwig h...@infradead.org gfs2 only needs the quotactl code, not the generic quota implementation. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/Kconfig |1 - 1 files changed, 0 insertions(+), 1 deletions

[Cluster-devel] [PATCH 3/3] GFS2: Skip check for mandatory locks when unlocking

2010-03-11 Thread Steven Whitehouse
(). gfs2_lock() should skip the check for mandatory locks when unlocking a file. Signed-off-by: Sachin Prabhu spra...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com --- fs/gfs2/file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/file.c b/fs

[Cluster-devel] GFS2: Pull request (fixes)

2010-03-11 Thread Steven Whitehouse
Hi, Please consider pulling the following small fixes, Steve. -- The following changes since commit 57d54889cd00db2752994b389ba714138652e60c: Linus Torvalds (1): Linux 2.6.34-rc1 are available in the git

[Cluster-devel] GFS2: New truncate sequence

2010-03-12 Thread Steven Whitehouse
from userspace results in a segfault). Signed-off-by: Steven Whitehouse swhit...@redhat.com Cc: Nick Piggin npig...@suse.de diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 0c1d0b8..371bea5 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -698,8 +698,11 @@ out: return 0

[Cluster-devel] GFS2 nmw git treee

2010-03-23 Thread Steven Whitehouse
Hi, I've rebased this now that I have a couple of new patches since the last pull. I'm still working on the new truncate patches and I'll post an updated set of those patches once I've tracked down a couple of issues I've found in testing, Steve.

<    1   2   3   4   5   6   7   8   9   10   >