Re: [Cluster-devel] RFC: iomap write invalidation

2020-07-20 Thread Goldwyn Rodrigues
Hi Christoph, On 9:46 13/07, Christoph Hellwig wrote: > Hi all, > > this series has two parts: the first one picks up Dave's patch to avoid > invalidation entierly for reads, picked up deep down from the btrfs iomap > thread. The second one falls back to buffered writes if invalidation fails

Re: [Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

2020-07-13 Thread Goldwyn Rodrigues
ellwig Thanks. This will help btrfs. The current next tree contains the iomap changes I recomended and would need to be reverted in order to incorporate this. Once this is in the next tree I will (re)format the btrfs iomap dio patches. Reviewed-by: Goldwyn Rodrigues > --- > fs/ext4/file.c | 2

[Cluster-devel] [PATCH 6/6] btrfs: split btrfs_direct_IO to read and write part

2020-07-08 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues The read and write versions don't have anything in common except for the call to iomap_dio_rw. So split this function, and merge each half into its only caller. Originally proposed by Christoph Hellwig Signed-off-by: Goldwyn Rodrigues --- fs/btrfs/ctree.h | 4

[Cluster-devel] [PATCH 4/6] fs: remove dio_end_io()

2020-07-08 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues Since we removed the last user of dio_end_io(), remove the helper function dio_end_io(). Reviewed-by: Nikolay Borisov Reviewed-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig Signed-off-by: Goldwyn Rodrigues --- fs/direct-io.c | 19

[Cluster-devel] [PATCH 0/6 v11] btrfs direct-io using iomap

2020-07-08 Thread Goldwyn Rodrigues
This is an effort to use iomap for direct I/O in btrfs. This would change the call from __blockdev_direct_io() to iomap_dio_rw(). These are remanants of the series which was revoked due to page invalidation errors and adds patches in iomap for proper buffered fallback. The main objective is to

[Cluster-devel] [PATCH 5/6] btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK

2020-07-08 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues Since we now perform direct reads using i_rwsem, we can remove this inode flag used to co-ordinate unlocked reads. The truncate call takes i_rwsem. This means it is correctly synchronized with concurrent direct reads. Reviewed-by: Nikolay Borisov Reviewed-by: Johannes

[Cluster-devel] [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-08 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues For direct I/O, add the flag IOMAP_DIO_RWF_NO_STALE_PAGECACHE to indicate that if the page invalidation fails, return back control to the filesystem so it may fallback to buffered mode. Reviewed-by: Darrick J. Wong Signed-off-by: Goldwyn Rodrigues --- fs/iomap/direct

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-07 Thread Goldwyn Rodrigues
On 7:01 07/07, Darrick J. Wong wrote: > On Tue, Jul 07, 2020 at 08:49:52AM -0500, Goldwyn Rodrigues wrote: > > On 13:57 07/07, Matthew Wilcox wrote: > > > On Tue, Jul 07, 2020 at 07:43:46AM -0500, Goldwyn Rodrigues wrote: > > > > On 9:53 01/07, Christoph Hellwig w

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-07 Thread Goldwyn Rodrigues
On 13:57 07/07, Matthew Wilcox wrote: > On Tue, Jul 07, 2020 at 07:43:46AM -0500, Goldwyn Rodrigues wrote: > > On 9:53 01/07, Christoph Hellwig wrote: > > > On Mon, Jun 29, 2020 at 02:23:49PM -0500, Goldwyn Rodrigues wrote: > > > > From: Goldwyn Rodrigues > &

Re: [Cluster-devel] always fall back to buffered I/O after invalidation failures, was: Re: [PATCH 2/6] iomap: IOMAP_DIO_RWF_NO_STALE_PAGECACHE return if page invalidation fails

2020-07-07 Thread Goldwyn Rodrigues
On 9:53 01/07, Christoph Hellwig wrote: > On Mon, Jun 29, 2020 at 02:23:49PM -0500, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > For direct I/O, add the flag IOMAP_DIO_RWF_NO_STALE_PAGECACHE to indicate > > that if the page invalidation

Re: [Cluster-devel] [PATCH 5/6] iomap: add a page_done callback

2018-07-13 Thread Goldwyn Rodrigues
On 18:41 19/06, Christoph Hellwig wrote: > This will be used by gfs2 to attach data to transactions for the journaled > data mode. But the concept is generic enough that we might be able to > use it for other purposes like encryption/integrity post-processing in the > future. > > Based on a

[Cluster-devel] GFS2 hangs on running bonnie

2010-08-25 Thread Goldwyn Rodrigues
Hi, I am trying to run bonnie on GFS2 but it hangs on every instance of its run. The kernel is 2.6.35.3 on an i686x2 processor. gfs2 is formatted with lock_nolock and mounted locally. The backtrace of the process is - [20937.467142] bonnie++ S 130a 0 22275 11549 0x0080