[Cluster-devel] [PATCH] dlm: NULL check before kmem_cache_destroy is not needed

[Wen Yang]

kmem_cache_destroy(NULL) is safe, so removes NULL check before
freeing the mem. This patch also fix ifnullfree.cocci warnings.

Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
CC: Julia Lawall <julia.law...@lip6.fr>
CC: Christine Caulfield <ccaul...@redhat.com>
CC: David Teigland <teigl...@redhat.com>
CC: cluster-devel@redhat.com
CC: linux-ker...@vger.kernel.org
---
 fs/dlm/memory.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/dlm/memory.c b/fs/dlm/memory.c
index 7cd24bccd4fe..37be29f21d04 100644
--- a/fs/dlm/memory.c
+++ b/fs/dlm/memory.c
@@ -38,10 +38,8 @@ int __init dlm_memory_init(void)
 
 void dlm_memory_exit(void)
 {
-       if (lkb_cache)
-               kmem_cache_destroy(lkb_cache);
-       if (rsb_cache)
-               kmem_cache_destroy(rsb_cache);
+       kmem_cache_destroy(lkb_cache);
+       kmem_cache_destroy(rsb_cache);
 }
 
 char *dlm_allocate_lvb(struct dlm_ls *ls)
@@ -86,8 +84,7 @@ void dlm_free_lkb(struct dlm_lkb *lkb)
                struct dlm_user_args *ua;
                ua = lkb->lkb_ua;
                if (ua) {
-                       if (ua->lksb.sb_lvbptr)
-                               kfree(ua->lksb.sb_lvbptr);
+                       kfree(ua->lksb.sb_lvbptr);
                        kfree(ua);
                }
        }
-- 
2.19.1