Re: [Cluster-devel] [GFS2 PATCH] gfs2: fix trans slab error when withdraw occurs inside log_flush

2020-06-09 Thread Andreas Gruenbacher
On Tue, Jun 9, 2020 at 4:15 PM Bob Peterson wrote: > - Original Message - > > I'm not sure quite what the aim is here... are you sure that it is ok to > > move something to the AIL list if there has been a withdrawal? If the > > log flush has not completed correctly then we should not be

Re: [Cluster-devel] [GFS2 PATCH] gfs2: fix trans slab error when withdraw occurs inside log_flush

2020-06-09 Thread Bob Peterson
- Original Message - > I'm not sure quite what the aim is here... are you sure that it is ok to > move something to the AIL list if there has been a withdrawal? If the > log flush has not completed correctly then we should not be moving > anything to the AIL lists I think, > > Steve.

Re: [Cluster-devel] [GFS2 PATCH] gfs2: fix trans slab error when withdraw occurs inside log_flush

2020-06-09 Thread Steven Whitehouse
Hi, On 09/06/2020 14:55, Bob Peterson wrote: Hi, Log flush operations (gfs2_log_flush()) can target a specific transaction. But if the function encounters errors (e.g. io errors) and withdraws, the transaction was only freed it if was queued to one of the ail lists. If the withdraw occurred

[Cluster-devel] [GFS2 PATCH] gfs2: fix trans slab error when withdraw occurs inside log_flush

2020-06-09 Thread Bob Peterson
Hi, Log flush operations (gfs2_log_flush()) can target a specific transaction. But if the function encounters errors (e.g. io errors) and withdraws, the transaction was only freed it if was queued to one of the ail lists. If the withdraw occurred before the transaction was queued to the ail1