Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-19 Thread Andreas Gruenbacher
On Tue, Jan 19, 2021 at 7:18 PM Bob Peterson wrote: > - Original Message - > > On Tue, Jan 19, 2021 at 4:44 PM Bob Peterson wrote: > > > Sure, the recovery workers' bio allocations and submitting may be > > > serialized, > > > but that's where it ends. The recovery workers don't prevent

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-19 Thread Bob Peterson
- Original Message - > On Tue, Jan 19, 2021 at 4:44 PM Bob Peterson wrote: > > Sure, the recovery workers' bio allocations and submitting may be > > serialized, > > but that's where it ends. The recovery workers don't prevent races with > > each > > other when using the variable common to

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-19 Thread Andreas Gruenbacher
On Tue, Jan 19, 2021 at 4:44 PM Bob Peterson wrote: > Sure, the recovery workers' bio allocations and submitting may be serialized, > but that's where it ends. The recovery workers don't prevent races with each > other when using the variable common to all of them: sdp->sd_log_bio. > This is the

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-19 Thread Bob Peterson
- Original Message - > On Mon, Jan 4, 2021 at 5:09 PM Bob Peterson wrote: > > > > Hi, > > > > - Original Message - > > > Hi, > > > > > > On 22/12/2020 20:38, Bob Peterson wrote: > > > > Hi, > > > > > > > > Before this patch, journal recovery was done by a workqueue function > > >

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-19 Thread Andreas Gruenbacher
On Mon, Jan 4, 2021 at 5:09 PM Bob Peterson wrote: > > Hi, > > - Original Message - > > Hi, > > > > On 22/12/2020 20:38, Bob Peterson wrote: > > > Hi, > > > > > > Before this patch, journal recovery was done by a workqueue function that > > > operated on a per-journal basis. The problem

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-04 Thread Bob Peterson
Hi, - Original Message - > Hi, > > On 22/12/2020 20:38, Bob Peterson wrote: > > Hi, > > > > Before this patch, journal recovery was done by a workqueue function that > > operated on a per-journal basis. The problem is, these could run > > simultaneously > > which meant that they could

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2021-01-04 Thread Steven Whitehouse
Hi, On 22/12/2020 20:38, Bob Peterson wrote: Hi, Before this patch, journal recovery was done by a workqueue function that operated on a per-journal basis. The problem is, these could run simultaneously which meant that they could all use the same bio, sd_log_bio, to do their writing to all

Re: [Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2020-12-22 Thread Andreas Gruenbacher
On Tue, Dec 22, 2020 at 9:39 PM Bob Peterson wrote: > > Hi, > > Before this patch, journal recovery was done by a workqueue function that > operated on a per-journal basis. The problem is, these could run > simultaneously > which meant that they could all use the same bio, sd_log_bio, to do

[Cluster-devel] [GFS2 PATCH] gfs2: make recovery workqueue operate on a gfs2 mount point, not journal

2020-12-22 Thread Bob Peterson
Hi, Before this patch, journal recovery was done by a workqueue function that operated on a per-journal basis. The problem is, these could run simultaneously which meant that they could all use the same bio, sd_log_bio, to do their writing to all the various journals. These operations overwrote