Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-16 Thread Mark Salyzyn
On 8/15/19 3:27 PM, James Morris wrote: On Thu, 15 Aug 2019, Mark Salyzyn wrote: Good Idea, but using the same argument structure for set and get I would be concerned about the loss of compiler protection for the buffer argument; Agreed, I missed that. Sadly, the pattern of struct

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread James Morris
On Thu, 15 Aug 2019, Mark Salyzyn wrote: > Good Idea, but using the same argument structure for set and get I would be > concerned about the loss of compiler protection for the buffer argument; Agreed, I missed that. > struct getxattr_args { > struct dentry *dentry; > struct inode

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread Mark Salyzyn
On 8/15/19 12:20 PM, James Morris wrote: On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: --- a/include/linux/xattr.h +++ b/include/linux/xattr.h @@ -30,10 +30,10 @@ struct xattr_handler { const char *prefix; int

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2019 at 05:20:36AM +1000, James Morris wrote: > On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: > > > On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > > > --- a/include/linux/xattr.h > > > +++ b/include/linux/xattr.h > > > @@ -30,10 +30,10 @@ struct xattr_handler { >

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-15 Thread James Morris
On Tue, 13 Aug 2019, Greg Kroah-Hartman wrote: > On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > > --- a/include/linux/xattr.h > > +++ b/include/linux/xattr.h > > @@ -30,10 +30,10 @@ struct xattr_handler { > > const char *prefix; > > int flags; /* fs private flags */

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread Mark Salyzyn
On 8/13/19 1:48 AM, Greg Kroah-Hartman wrote: On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: --- a/include/linux/xattr.h +++ b/include/linux/xattr.h @@ -30,10 +30,10 @@ struct xattr_handler { const char *prefix; int flags; /* fs private flags */ bool

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 12:32:49PM -0700, Mark Salyzyn wrote: > --- a/include/linux/xattr.h > +++ b/include/linux/xattr.h > @@ -30,10 +30,10 @@ struct xattr_handler { > const char *prefix; > int flags; /* fs private flags */ > bool (*list)(struct dentry *dentry); > - int

Re: [Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-13 Thread kbuild test robot
Hi Mark, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[Cluster-devel] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-12 Thread Mark Salyzyn
Add a flag option to get xattr method that could have a bit flag of XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then set in the __vfs_getxattr path. This handles the case of a union filesystem driver that is being requested by the security layer to report back the xattr data.