Re: [Cluster-devel] [PATCH] GFS2: Fix potential NULL dereference in gfs2_alloc_inode

2015-03-02 Thread Andreas Gruenbacher
On 03/02/2015 05:30 PM, Andrew Price wrote: > On 02/03/15 16:17, Steven Whitehouse wrote: >> Hi, >> >> On 02/03/15 16:15, Andrew Price wrote: > Ah, so it is. Self-NACK then. The patch itself is still worth it though, it's not self-evident ip and &ip->i_inode are the same. Andreas

Re: [Cluster-devel] [PATCH] GFS2: Fix potential NULL dereference in gfs2_alloc_inode

2015-03-02 Thread Andrew Price
On 02/03/15 16:17, Steven Whitehouse wrote: Hi, On 02/03/15 16:15, Andrew Price wrote: Return NULL when ip is NULL instead of dereferencing it. Signed-off-by: Andrew Price --- fs/gfs2/super.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/super.c

Re: [Cluster-devel] [PATCH] GFS2: Fix potential NULL dereference in gfs2_alloc_inode

2015-03-02 Thread Steven Whitehouse
Hi, On 02/03/15 16:15, Andrew Price wrote: Return NULL when ip is NULL instead of dereferencing it. Signed-off-by: Andrew Price --- fs/gfs2/super.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 1666382..37c59ee 1006

[Cluster-devel] [PATCH] GFS2: Fix potential NULL dereference in gfs2_alloc_inode

2015-03-02 Thread Andrew Price
Return NULL when ip is NULL instead of dereferencing it. Signed-off-by: Andrew Price --- fs/gfs2/super.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 1666382..37c59ee 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @