Re: [Cluster-devel] [PATCH] GFS2: Improve readability of gfs2_alloc_inode

2015-03-03 Thread Bob Peterson
- Original Message - Returning ip-i_inode when ip is NULL is safe as i_inode is the first member in struct gfs2_inode, but that's not immediately obvious. Reorganize gfs2_alloc_inode to avoid any doubt. Signed-off-by: Andrew Price anpr...@redhat.com --- Re-sending with a more

[Cluster-devel] [PATCH] GFS2: Improve readability of gfs2_alloc_inode

2015-03-02 Thread Andrew Price
Returning ip-i_inode when ip is NULL is safe as i_inode is the first member in struct gfs2_inode, but that's not immediately obvious. Reorganize gfs2_alloc_inode to avoid any doubt. Signed-off-by: Andrew Price anpr...@redhat.com --- Re-sending with a more appropriate commit log based on Andreas'