Re: [Cluster-devel] [PATCH] gfs2: Put bitmap buffers in put_super

2018-11-06 Thread Andreas Gruenbacher
Hi Steve, On Tue, 6 Nov 2018 at 11:15, Steven Whitehouse wrote: > While that looks like a good fix for now, we should look at this again > in due course. Why do we have a ref to the rgrp buffers held here in the > first place? Unless the buffers are pinned in the journal there should > not be a

Re: [Cluster-devel] [PATCH] gfs2: Put bitmap buffers in put_super

2018-11-06 Thread Steven Whitehouse
Hi, While that looks like a good fix for now, we should look at this again in due course. Why do we have a ref to the rgrp buffers held here in the first place? Unless the buffers are pinned in the journal there should not be a ref held, otherwise they cannot respond to memory pressure,

[Cluster-devel] [PATCH] gfs2: Put bitmap buffers in put_super

2018-11-06 Thread Andreas Gruenbacher
gfs2_put_super calls gfs2_clear_rgrpd to destroy the gfs2_rgrpd objects attached to the resource group glocks. That function should release the buffers attached to the gfs2_bitmap objects (bi_bh), but the call to gfs2_rgrp_brelse for doing that is missing. When gfs2_releasepage later runs across