Re: [Cluster-devel] [PATCH] mkfs.gfs2: Don't use optimal_io_size when equal to minimum

2020-05-27 Thread Andrew Price
On 27/05/2020 11:07, Steven Whitehouse wrote: By default, I can't see any reason why we'd want a block sizes less than 4k. We might want to allow someone to do that for special cases, but generally the lower block sizes cause issue with larger file sizes, due to the increased height of the

Re: [Cluster-devel] [PATCH] mkfs.gfs2: Don't use optimal_io_size when equal to minimum

2020-05-27 Thread Steven Whitehouse
Hi, On 27/05/2020 11:02, Andrew Price wrote: On 27/05/2020 09:53, Steven Whitehouse wrote: Hi, On 27/05/2020 09:29, Andrew Price wrote: Some devices report an optimal_io_size of 512 instead of 0 when it's not larger than the minimum_io_size. Currently mkfs.gfs2 uses the non-zero value to

Re: [Cluster-devel] [PATCH] mkfs.gfs2: Don't use optimal_io_size when equal to minimum

2020-05-27 Thread Andrew Price
On 27/05/2020 09:53, Steven Whitehouse wrote: Hi, On 27/05/2020 09:29, Andrew Price wrote: Some devices report an optimal_io_size of 512 instead of 0 when it's not larger than the minimum_io_size. Currently mkfs.gfs2 uses the non-zero value to choose the block size, which is almost certainly

Re: [Cluster-devel] [PATCH] mkfs.gfs2: Don't use optimal_io_size when equal to minimum

2020-05-27 Thread Steven Whitehouse
Hi, On 27/05/2020 09:29, Andrew Price wrote: Some devices report an optimal_io_size of 512 instead of 0 when it's not larger than the minimum_io_size. Currently mkfs.gfs2 uses the non-zero value to choose the block size, which is almost certainly not what we want when it's 512. Update the

[Cluster-devel] [PATCH] mkfs.gfs2: Don't use optimal_io_size when equal to minimum

2020-05-27 Thread Andrew Price
Some devices report an optimal_io_size of 512 instead of 0 when it's not larger than the minimum_io_size. Currently mkfs.gfs2 uses the non-zero value to choose the block size, which is almost certainly not what we want when it's 512. Update the suitability check for optimal_io_size to avoid using