Re: [Cluster-devel] [PATCH 0/3] dlm: fix various incorrect behaviors

2018-11-16 Thread Kees Cook
On Fri, Nov 9, 2018 at 9:15 AM, Tycho Andersen  wrote:
> On Wed, Nov 07, 2018 at 04:20:42PM -0600, David Teigland wrote:
>> On Fri, Nov 02, 2018 at 02:18:19PM -0600, Tycho Andersen wrote:
>> > Hi,
>> >
>> > here's a series to fix some bugs I noticed in the DLM. The third patch
>> > in the series and maybe the first should probably go to stable, assuming
>> > everyone agrees they're indeed bugs.
>> >
>> > Thanks,
>> >
>> > Tycho
>> >
>> > Tycho Andersen (3):
>> >   dlm: fix invalid free
>> >   dlm: don't allow zero length names
>> >   dlm: don't leak kernel pointer to userspace
>> >
>> >  fs/dlm/lockspace.c | 2 +-
>> >  fs/dlm/member.c| 5 +++--
>> >  fs/dlm/user.c  | 2 +-
>> >  3 files changed, 5 insertions(+), 4 deletions(-)
>>
>> I've pushed these to linux-dlm next.
>
> Great, thanks! Should we send 1 and 3 to stable?

Yes please! :)

-- 
Kees Cook



Re: [Cluster-devel] [PATCH 0/3] dlm: fix various incorrect behaviors

2018-11-09 Thread Tycho Andersen
On Wed, Nov 07, 2018 at 04:20:42PM -0600, David Teigland wrote:
> On Fri, Nov 02, 2018 at 02:18:19PM -0600, Tycho Andersen wrote:
> > Hi,
> > 
> > here's a series to fix some bugs I noticed in the DLM. The third patch
> > in the series and maybe the first should probably go to stable, assuming
> > everyone agrees they're indeed bugs.
> > 
> > Thanks,
> > 
> > Tycho
> > 
> > Tycho Andersen (3):
> >   dlm: fix invalid free
> >   dlm: don't allow zero length names
> >   dlm: don't leak kernel pointer to userspace
> > 
> >  fs/dlm/lockspace.c | 2 +-
> >  fs/dlm/member.c| 5 +++--
> >  fs/dlm/user.c  | 2 +-
> >  3 files changed, 5 insertions(+), 4 deletions(-)
> 
> I've pushed these to linux-dlm next.

Great, thanks! Should we send 1 and 3 to stable?

Tycho



Re: [Cluster-devel] [PATCH 0/3] dlm: fix various incorrect behaviors

2018-11-07 Thread David Teigland
On Fri, Nov 02, 2018 at 02:18:19PM -0600, Tycho Andersen wrote:
> Hi,
> 
> here's a series to fix some bugs I noticed in the DLM. The third patch
> in the series and maybe the first should probably go to stable, assuming
> everyone agrees they're indeed bugs.
> 
> Thanks,
> 
> Tycho
> 
> Tycho Andersen (3):
>   dlm: fix invalid free
>   dlm: don't allow zero length names
>   dlm: don't leak kernel pointer to userspace
> 
>  fs/dlm/lockspace.c | 2 +-
>  fs/dlm/member.c| 5 +++--
>  fs/dlm/user.c  | 2 +-
>  3 files changed, 5 insertions(+), 4 deletions(-)

I've pushed these to linux-dlm next.
Dave



[Cluster-devel] [PATCH 0/3] dlm: fix various incorrect behaviors

2018-11-05 Thread Tycho Andersen
Hi,

here's a series to fix some bugs I noticed in the DLM. The third patch
in the series and maybe the first should probably go to stable, assuming
everyone agrees they're indeed bugs.

Thanks,

Tycho

Tycho Andersen (3):
  dlm: fix invalid free
  dlm: don't allow zero length names
  dlm: don't leak kernel pointer to userspace

 fs/dlm/lockspace.c | 2 +-
 fs/dlm/member.c| 5 +++--
 fs/dlm/user.c  | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.17.1