Re: [Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

On Wed, Apr 13, 2016 at 11:59 PM, Al Viro wrote: > On Wed, Apr 13, 2016 at 11:43:19PM -0500, Steve French wrote: >> If you are planning to merge it in next few weeks (they fix bugs, and >> are safe so why not), I can simply just back out my changes from >> cifs-2.6.git

Re: [Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

On Wed, Apr 13, 2016 at 11:43:19PM -0500, Steve French wrote: > If you are planning to merge it in next few weeks (they fix bugs, and > are safe so why not), I can simply just back out my changes from > cifs-2.6.git for-next branch and let you merge the trivial checkpatch > cleanup attached. Do

Re: [Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

If you prefer merging those out of your tree, you can add my Reviewed-by if needed (for the three cifs patches) On Wed, Apr 13, 2016 at 11:43 PM, Steve French wrote: > If you are planning to merge it in next few weeks (they fix bugs, and > are safe so why not), I can simply

Re: [Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

If you are planning to merge it in next few weeks (they fix bugs, and are safe so why not), I can simply just back out my changes from cifs-2.6.git for-next branch and let you merge the trivial checkpatch cleanup attached. On Wed, Apr 13, 2016 at 11:37 PM, Al Viro

Re: [Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

On Wed, Apr 13, 2016 at 11:26:24PM -0500, Steve French wrote: > Thanks for spotting this - merged into cifs-2.6.git. checkpatch > spotted and old indentation issue so I cleaned that up in a followon > patch that I will send. *ugh* And in the meanwhile I'd picked those into my queue... Could

Re: [Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

Thanks for spotting this - merged into cifs-2.6.git. checkpatch spotted and old indentation issue so I cleaned that up in a followon patch that I will send. On Wed, Apr 13, 2016 at 5:30 PM, Andreas Gruenbacher wrote: > Use strcmp(str, name) instead of strncmp(str, name,

[Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

Use strcmp(str, name) instead of strncmp(str, name, strlen(name)) for checking if str and name are the same (as opposed to name being a prefix of str) in the gexattr and setxattr inode operations. Signed-off-by: Andreas Gruenbacher --- fs/cifs/xattr.c | 24

[Cluster-devel] [PATCH 1/8] cifs: Fix xattr name checks

Use strcmp(str, name) instead of strncmp(str, name, strlen(name)) for checking if str and name are the same (as opposed to name being a prefix of str) in the gexattr and setxattr inode operations. Signed-off-by: Andreas Gruenbacher --- fs/cifs/xattr.c | 24