[Cluster-devel] [PATCH 10/15] GFS2: Deletion of unnecessary checks before two function calls

[Steven Whitehouse]

From: Markus Elfring <elfr...@users.sourceforge.net>

The functions iput() and put_pid() test whether their argument is NULL
and then return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Signed-off-by: Steven Whitehouse <swhit...@redhat.com>

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 8f0c19d..a23524a 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -836,8 +836,7 @@ void gfs2_holder_reinit(unsigned int state, unsigned flags, 
struct gfs2_holder *
        gh->gh_flags = flags;
        gh->gh_iflags = 0;
        gh->gh_ip = _RET_IP_;
-       if (gh->gh_owner_pid)
-               put_pid(gh->gh_owner_pid);
+       put_pid(gh->gh_owner_pid);
        gh->gh_owner_pid = get_pid(task_pid(current));
 }
 
-- 
1.8.3.1