Re: [Cluster-devel] [PATCH 4/9] shmem: remove shmem_get_partial_folio

2023-01-18 Thread Brian Foster
On Wed, Jan 18, 2023 at 05:43:58PM +0100, Christoph Hellwig wrote: > On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote: > > This all seems reasonable to me at a glance, FWIW, but I am a little > > curious why this wouldn't split up into two changes. I.e., switch this > > over to

Re: [Cluster-devel] [PATCH 4/9] shmem: remove shmem_get_partial_folio

2023-01-18 Thread Christoph Hellwig
On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote: > This all seems reasonable to me at a glance, FWIW, but I am a little > curious why this wouldn't split up into two changes. I.e., switch this > over to filemap_get_entry() to minimally remove the FGP_ENTRY dependency > without a

Re: [Cluster-devel] [PATCH 4/9] shmem: remove shmem_get_partial_folio

2023-01-18 Thread Brian Foster
On Wed, Jan 18, 2023 at 10:43:24AM +0100, Christoph Hellwig wrote: > Add a new SGP_FIND mode for shmem_get_partial_folio that works like > SGP_READ, but does not check i_size. Use that instead of open coding > the page cache lookup in shmem_get_partial_folio. Note that this is > a behavior

[Cluster-devel] [PATCH 4/9] shmem: remove shmem_get_partial_folio

2023-01-18 Thread Christoph Hellwig
Add a new SGP_FIND mode for shmem_get_partial_folio that works like SGP_READ, but does not check i_size. Use that instead of open coding the page cache lookup in shmem_get_partial_folio. Note that this is a behavior change in that it reads in swap cache entries for offsets outside i_size,