Re: [Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-05-17 Thread Andreas Gruenbacher
On Mon, May 9, 2022 at 12:41 PM Andrew Price wrote: > On 29/04/2022 15:08, Andrew Price wrote: > > On 19/04/2022 16:49, Andrew Price wrote: > >> On 05/04/2022 13:08, Andrew Price wrote: > >>> The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to > >>> fs block size") fixes was a

Re: [Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-05-09 Thread Andrew Price
On 29/04/2022 15:08, Andrew Price wrote: On 19/04/2022 16:49, Andrew Price wrote: On 05/04/2022 13:08, Andrew Price wrote: The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to fs block size") fixes was a little confusing as the user saw "Input/output error" which masked the

Re: [Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-04-29 Thread Andrew Price
On 19/04/2022 16:49, Andrew Price wrote: On 05/04/2022 13:08, Andrew Price wrote: The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to fs block size") fixes was a little confusing as the user saw "Input/output error" which masked the -EINVAL that sb_issue_discard() returned.

Re: [Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-04-19 Thread Andrew Price
On 05/04/2022 13:08, Andrew Price wrote: The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to fs block size") fixes was a little confusing as the user saw "Input/output error" which masked the -EINVAL that sb_issue_discard() returned. sb_issue_discard() can fail for various

[Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-04-05 Thread Andrew Price
The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to fs block size") fixes was a little confusing as the user saw "Input/output error" which masked the -EINVAL that sb_issue_discard() returned. sb_issue_discard() can fail for various reasons, so we should return its return