Re: [Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-03-09 Thread Alexey Dobriyan
On Mon, Mar 2, 2015 at 7:46 AM, Mateusz Guzik wrote: > On Mon, Mar 02, 2015 at 05:38:29AM +0100, Mateusz Guzik wrote: >> On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote: >> > On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote: >> > > Freezing and thawing are separate syst

Re: [Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-03-04 Thread Alexey Dobriyan
On Mon, Mar 2, 2015 at 7:38 AM, Mateusz Guzik wrote: > As explained below, this one task name is already very useful and likely > covers majority of real life use cases. > > While working in support we were getting a lot of vmcores where hung task > detector panicked the kernel because a lot of t

Re: [Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-03-02 Thread Dave Chinner
On Mon, Mar 02, 2015 at 05:38:29AM +0100, Mateusz Guzik wrote: > On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote: > > On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote: > > > Freezing and thawing are separate system calls, task which is supposed > > > to thaw filesystem/s

Re: [Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-03-02 Thread Mateusz Guzik
On Mon, Mar 02, 2015 at 05:38:29AM +0100, Mateusz Guzik wrote: > On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote: > > On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote: > > > Freezing and thawing are separate system calls, task which is supposed > > > to thaw filesystem/s

Re: [Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-03-02 Thread Mateusz Guzik
On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote: > On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote: > > Freezing and thawing are separate system calls, task which is supposed > > to thaw filesystem/superblock can disappear due to crash or not thaw > > due to a bug. At l

Re: [Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-02-28 Thread Dave Chinner
On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote: > Freezing and thawing are separate system calls, task which is supposed > to thaw filesystem/superblock can disappear due to crash or not thaw > due to a bug. At least record task name (we can't take task_struct > reference) to make

[Cluster-devel] [PATCH v3] fs: record task name which froze superblock

2015-02-28 Thread Alexey Dobriyan
Freezing and thawing are separate system calls, task which is supposed to thaw filesystem/superblock can disappear due to crash or not thaw due to a bug. At least record task name (we can't take task_struct reference) to make support engineer's life easier. Hopefully 16 bytes per superblock isn't