Re: [Cluster-devel] [PATCH v7 2/5] fs: Turn __generic_write_end into a void function

2019-04-30 Thread Darrick J. Wong
On Tue, Apr 30, 2019 at 12:09:31AM +0200, Andreas Gruenbacher wrote: > The VFS-internal __generic_write_end helper always returns the value of > its @copied argument. This can be confusing, and it isn't very useful > anyway, so turn __generic_write_end into a function returning void > instead.

Re: [Cluster-devel] [PATCH v7 2/5] fs: Turn __generic_write_end into a void function

2019-04-30 Thread Christoph Hellwig
On Tue, Apr 30, 2019 at 12:09:31AM +0200, Andreas Gruenbacher wrote: > The VFS-internal __generic_write_end helper always returns the value of > its @copied argument. This can be confusing, and it isn't very useful > anyway, so turn __generic_write_end into a function returning void > instead. >

[Cluster-devel] [PATCH v7 2/5] fs: Turn __generic_write_end into a void function

2019-04-29 Thread Andreas Gruenbacher
The VFS-internal __generic_write_end helper always returns the value of its @copied argument. This can be confusing, and it isn't very useful anyway, so turn __generic_write_end into a function returning void instead. Signed-off-by: Andreas Gruenbacher --- fs/buffer.c | 6 +++---