If there is only one RG in the filesystem
gfs2_grow will make a subtraction using a
null pointer to check the RG size returning
a invalide RG size value.
This patch avoid this substraction if there is
only one RG in the filesystem.
---
gfs2/mkfs/main_grow.c |6 +-
1 files changed, 5
ACK
On 08/08/11 15:01, Lon Hohberger wrote:
Resolves: rhbz#678467
Signed-off-by: Lon Hohbergerl...@redhat.com
---
rgmanager/src/resources/fs.sh.in|3 ++-
rgmanager/src/resources/netfs.sh|3 ++-
rgmanager/src/resources/utils/fs-lib.sh | 12 ++--
3 files
Hi,
For a long time now I've been working on a series of patches that
allow fsck.gfs2 to analyze and fix GFS (GFS1) file systems as well
as GFS2 file systems. There are several reasons to do this:
1. There is no gfs_fsck in upstream, RHEL6, Fedora or newer, which
means that anyone who has an
From f4326def0744e6a01a5e7665eb4f8261d6996af7 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 08:41:36 -0500
Subject: [PATCH 01/44] fsck.gfs2: Make functions consistently use sdp rather
than sbp
For years, the fsck.gfs2 tool used two different variable names
From e85543c0c03fcaeb4ada7ee7b4ecbef361b16ffc Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 10:48:35 -0500
Subject: [PATCH 04/44] libgfs2: Make check_sb and read_sb operate on gfs1
file systems
This patch adds allow_gfs1 parameters to the read_sb and
From 32a60225151e08ec6291e43dec2ab8ac7f24db21 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 09:45:36 -0500
Subject: [PATCH 03/44] libgfs1: Add a centralized gfs1 variable to superblock
variables
This patch adds a gfs1 variable to the in-core superblock
From e02f2523bfd3b3cc12b07cabdcc388b88c0ba769 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 11:23:47 -0500
Subject: [PATCH 05/44] libgfs2: add generic risize function, move gfs1
structures to libgfs2
This patch moves a number of gfs1-specific structures
From 7bb269a5158f81c6c5d9190c4f76d73a83e3c9d7 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 12:46:29 -0500
Subject: [PATCH 06/44] fsck.gfs2: Check for blocks wrongly inside resource
groups
It's not enough to range_check blocks in order to call them valid.
From a2fc75cad03602f8582a744c6a14ddae3a85cffd Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 12:58:04 -0500
Subject: [PATCH 07/44] fsck.gfs2: Rename function check_leaf to
check_ealeaf_block
This patch renames function check_leaf_block to check_ealeaf_block
From dfa63a3b56e71b8607098cb02e5162fc01aa8bab Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 13:28:08 -0500
Subject: [PATCH 08/44] fsck.gfs2: eliminate vestigial buffer_head variable in
check_leaf
This patch eliminates a variable bh from all the check_leaf
From 55e442c79adec0fa7f6d4e7f6700f14a630d4e3e Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:01:18 -0500
Subject: [PATCH 09/44] fsck.gfs2: Rename the nlink functions to make them
more intuitive
Part of fsck's checks is to verify the count of links for
From da57639e65b148bb4d2a3c6a9d98623b8ad18b04 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:21:06 -0500
Subject: [PATCH 10/44] fsck.gfs2: Keep di_nlink in sync when adding links for
lost+found
When adding a .. entry to a directory newly linked to
From 0dc5622515a2e888efd89cb33e7c2fe600f895a5 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:38:19 -0500
Subject: [PATCH 11/44] fsck.gfs2: directory entry count was only 16 bits in
check_entries
When counting directory links, fsck.gfs2 was using a 16-bit
From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:44:46 -0500
Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic
This patch changes the logic of the code from being triple-negative
to
From fa744b806ad8655c9ed3a18fcbec1c7992735be5 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 14:47:49 -0500
Subject: [PATCH 13/44] dirent_repair needs to mark the buffer as modified
This patch adds a call to bmodified to function dirent_repair. Without
From 0307db694e7316ab93071239704428ba5e346fcb Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 15:16:01 -0500
Subject: [PATCH 14/44] fsck.gfs2: Ask to reclaim unlinked meta on a per-rgrp
basis only
Before this patch, fsck.gfs2 would ask for every unlinked
From 37b96d287c82e81b5626948a80b52d62bb2b8612 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 15:44:19 -0500
Subject: [PATCH 15/44] fsck.gfs2: Factor out function to add .. entry when
linking to lost+found
This function factors out a section of code from
From 97b0253e2347b87f29ecf5d5fefbb08655358bb2 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 16:11:48 -0500
Subject: [PATCH 16/44] libgfs2: Use __FUNCTION__ rather than __FILE__ for
debug messages
This patch changes the debug output of gfs2-utils to use
From 0f424f6c6a2b4fda8c5b9b2bc1cb246d868d3fec Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 16:20:14 -0500
Subject: [PATCH 17/44] fsck.gfs2: Don't stop invalidating blocks if an
invalid one is found
When fsck found a duplicate reference to a block it
From 50e59f2cd489e7b0200bb098f1c11c30977d5e28 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Mon, 8 Aug 2011 16:44:47 -0500
Subject: [PATCH 18/44] fsck.gfs2: Find and clear duplicate references that
are leaf blocks
Duplicate references that were in leaf blocks were never
From ce30310b12df03b34d1e430e69e483bf1ee10b64 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 10:08:21 -0500
Subject: [PATCH 21/44] fsck.gfs2: split function check_leaf_blks to make it
more understandable
This patch splits function check_leaf_blks into two
From 4768302284585037fada762a1bc5107f9212de71 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 09:23:05 -0500
Subject: [PATCH 19/44] fsck.gfs2: Move function check_num_ptrs from
metawalk.c to pass1.c
This patch moves function check_num_ptrs from metawalk.c to
From 866622b4d90e112c9e7690e0ec61af79b827fd3d Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 11:38:18 -0500
Subject: [PATCH 22/44] fsck.gfs2: Shorten output
This patch shortens some of the output of fsck.gfs2, thereby making
the output files smaller and more
From eebc8a12e1995b01b73e10f1eca2afe5395c4d72 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 12:36:04 -0500
Subject: [PATCH 23/44] fsck.gfs2: Make output messages more sensible
This patch changes several fsck output messages so that they make more
sense.
From 7a2fc9138955e93fd525f5ec035e7ab2b57f0a8c Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 12:45:18 -0500
Subject: [PATCH 24/44] fsck.gfs pass2: Refactor function set_dotdor_dir
This patch refactors function set_dotdot_dir to make it more readable.
From c88ec089aeddd42c88faa17f5dd9ecb7119e2d61 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 12:48:36 -0500
Subject: [PATCH 25/44] fsck.gfs pass2: When deleting an inode, delete its
extended attributes
When pass2 decided to delete a bad/corrupt dinode from
From 61c30e4c549d5de8e9a668b9e34bde071ed704ce Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 13:01:05 -0500
Subject: [PATCH 26/44] fsck.gfs pass2: Only delete metadata if bad (not
invalid) inode
In pass2, all metadata was deleted for inodes that were marked
From a97bc6cd2ecb804664968385e10de3b25e3bdb55 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 13:27:01 -0500
Subject: [PATCH 27/44] fsck.gfs pass3: Refactor mark_and_return_parent
This patch refactors pass3 function mark_and_return_parent. Before
it was so
From d60a5514fd59bb5f29af684a4fe3958fee597ca5 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 14:07:21 -0500
Subject: [PATCH 28/44] fsck.gfs2: misc cosmetic changes
This patch is just cosmetic changes. It cleans up comments and code
but there should be no
From 98ccc0cb40a604a943e029f1a475dd911807c22b Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 14:22:12 -0500
Subject: [PATCH 29/44] fsck.gfs2: check_leaf_blks: Don't use old_leaf if it
was a duplicate
In function check_leaf_blks fsck.gfs2 keeps track of the
From 06a9b623e46dfc8ea2008b8d32267f5f28708316 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 15:29:35 -0500
Subject: [PATCH 30/44] fsck.gfs2: Add find_remove_dup and
free_block_if_notdup
This patch adds a couple new functions to util.c: find_remove_dup
and
From 34c9992770cb54114e8806663526cb1baa235ecb Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Tue, 9 Aug 2011 15:51:34 -0500
Subject: [PATCH 31/44] fsck.gfs2: don't free previous rgrp list when trying
to repair rgrps
In cases where fsck.gfs2 is trying to repair damaged
From b3a08a2127d565609c0edaba400525b8737ab324 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 10:21:00 -0500
Subject: [PATCH 32/44] libgfs2: eliminate gfs1_readi in favor of gfs2_readi
This patch eliminates function gfs1_readi because it's nearly
identical
From 1cd46c9abb1d1498d9b18afae4f6f978d71d648d Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 10:25:19 -0500
Subject: [PATCH 33/44] libgfs2: when adding a new GFS1 block, mark buffers
modified
When adding new blocks to the file system for GFS1, function
From bc534f1d55b9b80b795356f7c5e3bc170bd75919 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 10:33:49 -0500
Subject: [PATCH 34/44] libgfs2: when mapping gfs1 dinode blocks, use dinode
buffer
When function gfs1_block_map found a block for a stuffed file it
From 83fd3a6dd7abf86de7c670fe4a869dff1ddd8582 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 13:12:54 -0500
Subject: [PATCH 35/44] libgfs2: move block_map functions to fsck.gfs2
Since the blockmap functions were only used in fsck.gfs2 they don't
have a
From 8f63c5404cb4731593c7dd2ecc958af5d5b68d9f Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 14:07:45 -0500
Subject: [PATCH 36/44] libgfs2: eliminate gfs1_rindex_read in favor of
rindex_read
Now that function rindex_read is able to handle gfs1 file
From 1b5b46eb51f0784152792fe4f446bb8f78712665 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 14:20:11 -0500
Subject: [PATCH 37/44] libgfs2: combine ri_update and gfs1_ri_update
Since gfs1_ri_update is nearly identical to ri_update, I decided to
combine the
From a839d64d24bd61c951177e981a88e678912a495f Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 14:49:35 -0500
Subject: [PATCH 38/44] libgfs2: combine gfs_inode_read and gfs_inode_get
Functions gfs_inode_read and gfs_inode_get were nearly identical.
They did
From 6fc9e595a6eb140c097cf0aafe203c40d44a8863 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 15:27:10 -0500
Subject: [PATCH 39/44] libgfs2: move gfs1 functions from edit to libgfs2
This patch moves some gfs1-specific functions from gfs2_edit to
libgfs2 so
From 6861c4a24df7120264e31848395059ce06181026 Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Wed, 10 Aug 2011 15:30:25 -0500
Subject: [PATCH 40/44] gfs2_edit savemeta: save_inode_data backwards for gfs1
The logic in gfs2_edit savemeta was wrong for saving inode blocks.
This
From 0de28d19f6bcdfd6bb987079c698776ce769596f Mon Sep 17 00:00:00 2001
From: Bob Peterson rpete...@redhat.com
Date: Thu, 11 Aug 2011 12:25:38 -0500
Subject: [PATCH 43/44] fsck.gfs2: four-step duplicate elimination process
This patch reforms the duplicate block reference processing by
introducing
On Wed, Aug 10, 2011 at 10:56:38PM -0400, Chris Feist wrote:
12 files changed, 53 insertions(+), 11 deletions(-)
mode change 100644 = 100755 rgmanager/src/resources/apache.sh
mode change 100644 = 100755 rgmanager/src/resources/clusterfs.sh
mode change 100644 = 100755
43 matches
Mail list logo
