Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-12 Thread Steven Whitehouse
Hi, On Fri, 2012-11-09 at 10:30 -0500, David Teigland wrote: > On Fri, Nov 09, 2012 at 09:45:17AM +, Steven Whitehouse wrote: > > > + if (test_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags) && > > > + (!gl->gl_lvb[0] || gl->gl_state != LM_ST_EXCLUSIVE)) { > > I'm still not happy with using !gl->

[Cluster-devel] [PATCH] gfs2-utils: Added a new script called gfs2_lockcapture to gfs2-utils that will capture lockdump data(including dlm lock) for the mounted GFS2 filesystems on a cluster node. The

2012-11-12 Thread Shane Bradley
From: root Signed-off-by: root --- gfs2/lockgather/Makefile.am |2 +- gfs2/lockgather/gfs2_lockcapture | 1078 ++ 2 files changed, 1079 insertions(+), 1 deletions(-) create mode 100644 gfs2/lockgather/gfs2_lockcapture diff --git a/gfs2/lockgather/M

[Cluster-devel] [PATCH] gfs2-utils: Added a new script called gfs2_lockcapture that will capture lockdump data.

2012-11-12 Thread Shane Bradley
The script gfs2_lockcapture will capture lockdump data(including dlm debug data) for the mounted GFS2 filesystems on a cluster node. In addition to the debug data, uname -a, hostname, date, mount, ps, etc are gathered. The script contains many configurable optons which include the number of iterati

Re: [Cluster-devel] [PATCH] gfs2-utils: Added a new script called gfs2_lockcapture that will capture lockdump data.

2012-11-12 Thread Andrew Price
Hi Shane, This has now been pushed to gfs2-utils.git: https://lists.fedorahosted.org/pipermail/cluster-commits/2012-November/003006.html Thanks, Andy On 12/11/12 14:06, Shane Bradley wrote: The script gfs2_lockcapture will capture lockdump data(including dlm debug data) for the mounted GFS2

Re: [Cluster-devel] [PATCH] gfs2: skip dlm_unlock calls in unmount

2012-11-12 Thread David Teigland
On Mon, Nov 12, 2012 at 10:44:36AM +, Steven Whitehouse wrote: > > - save 64 bytes of memory for every local lock > > (32 in gfs2_glock, 32 in dlm_rsb) > > > > - save 96 bytes of memory for every remote lock > > (32 in gfs2_glock, 32 in local dlm_rsb, 32 in remote dlm_lkb) > > > > - save

[Cluster-devel] [GFS2 PATCH] GFS2: Eliminate redundant buffer_head manipulation in gfs2_unlink_inode

2012-11-12 Thread Bob Peterson
Hi, Since we now have a dirty_inode that takes care of manipulating the inode buffer and writing from the inode to the buffer, we can eliminate some unnecessary buffer manipulations in gfs2_unlink_inode that are now redundant. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peters

[Cluster-devel] [GFS2 PATCH] GFS2: Use dirty_inode in gfs2_dir_add

2012-11-12 Thread Bob Peterson
Hi, This patch changes the gfs2_dir_add function so that it uses the dirty_inode function (via mark_inode_dirty) rather than manually updating the dinode. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson --- diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 259b088..9a356

[Cluster-devel] [GFS2 PATCH] GFS2: Don't skip rgrps for Orlov's sake if reservation is active

2012-11-12 Thread Bob Peterson
Hi, This patch changes function gfs2_inplace_reserve so that it does not perform the Orlov allocator resource group skipping in cases where we have an active reservation. Skipping an active rgrp is improper and gets our block reservation counts out of sync. Regards, Bob Peterson Red Hat File Sys

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Don't skip rgrps for Orlov's sake if reservation is active

2012-11-12 Thread Steven Whitehouse
Hi, I don't think this makes sense... we will never have an active reservation when the orlov allocator is in use, since it is only ever used for new directory inodes, Steve. On Mon, 2012-11-12 at 13:31 -0500, Bob Peterson wrote: > Hi, > > This patch changes function gfs2_inplace_reserve so tha

[Cluster-devel] gfs2-utils 3.1.5 Released

2012-11-12 Thread Andrew Price
Hi, gfs2-utils 3.1.5 has been released. This version features bug fixes and performance enhancements for fsck.gfs2 in particular, better handling of symlinks in mkfs.gfs2, a small block manipulation language to aid future testing, a gfs2_lockcapture script which replaces gfs2_lockgather, and