Re: [Cluster-devel] [GFS2 PATCH 1/2] GFS2: Make gfs2_clear_inode() queue the final put

2015-12-02 Thread Bob Peterson
- Original Message - > - Original Message - > (snip) > > Please take a look at this > > again and figure out what the problematic cycle of events is, and then > > work out how to avoid that happening in the first place. There is no > > point in replacing one problem with another

Re: [Cluster-devel] [GFS2 PATCH 1/2] GFS2: Make gfs2_clear_inode() queue the final put

2015-12-02 Thread Bob Peterson
- Original Message - (snip) > Please take a look at this > again and figure out what the problematic cycle of events is, and then > work out how to avoid that happening in the first place. There is no > point in replacing one problem with another one, particularly one which > would likely

[Cluster-devel] [PATCH 1/2 v2] gfs2: keep offset when splitting dir leaf blocks

2015-12-02 Thread Benjamin Marzinski
Currently, when gfs2 splits a directory leaf block, the dirents that need to be copied to the new leaf block are packed into the start of it. This is good for space efficiency. However, if gfs2 were to copy those dirents into the exact same offset in the new leaf block as they had in the old

[Cluster-devel] [PATCH 2/2 v2] gfs2: change gfs2 readdir cookie

2015-12-02 Thread Benjamin Marzinski
gfs2 currently returns 31 bits of filename hash as a cookie that readdir uses for an offset into the directory. When there are a large number of directory entries, the likelihood of a collision goes up way too quickly. GFS2 will now return cookies that are guaranteed unique for a while, and then

Re: [Cluster-devel] [GFS2 PATCH 1/2] GFS2: Make gfs2_clear_inode() queue the final put

2015-12-02 Thread Steven Whitehouse
HI, On 01/12/15 15:42, Bob Peterson wrote: - Original Message - Hi, On 25/11/15 14:22, Bob Peterson wrote: - Original Message - Hi, On 19/11/15 18:42, Bob Peterson wrote: This patch changes function gfs2_clear_inode() so that instead of calling gfs2_glock_put directly()