Re: [Cluster-devel] [PATCH] gfs2: hole_size improvement

2018-04-11 Thread Andrew Price
Hi Andreas, I only have a few nitpicks... On 10/04/18 18:39, Andreas Gruenbacher wrote: Rewrite function hole_size so that it computes the entire size of a hole. Previously, the hole size returned wasn't guaranteed to span the entire hole and multiple invocations of hole_size could be needed

Re: [Cluster-devel] [PATCH] gfs2: hole_size improvement

2018-04-11 Thread Andreas Gruenbacher
Hi Andy, On 11 April 2018 at 15:00, Andrew Price wrote: > Hi Andreas, > > I only have a few nitpicks... > > On 10/04/18 18:39, Andreas Gruenbacher wrote: >> >> Rewrite function hole_size so that it computes the entire size of a >> hole. Previously, the hole size returned

Re: [Cluster-devel] WARNING: kobject bug in sysfs_warn_dup

2018-04-11 Thread Dmitry Vyukov
On Thu, Apr 5, 2018 at 4:23 PM, Greg KH wrote: >> >> On 05/04/18 09:52, Dmitry Vyukov wrote: >> >> > On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse >> >> > wrote: >> >> > > Hi, >> >> > > >> >> > > >> >> > > >> >> > > On 05/04/18 09:19, Dmitry

Re: [Cluster-devel] WARNING: kobject bug in sysfs_warn_dup

2018-04-11 Thread Dmitry Vyukov
On Wed, Apr 11, 2018 at 5:04 PM, Dmitry Vyukov wrote: > On Thu, Apr 5, 2018 at 4:23 PM, Greg KH wrote: >>> >> On 05/04/18 09:52, Dmitry Vyukov wrote: >>> >> > On Thu, Apr 5, 2018 at 10:36 AM, Steven Whitehouse >>> >> > wrote: